1
0
Fork 0
fenix/app/src/main/java/org/mozilla/fenix/settings
Elise Richards 023a4983fa
For #10173: login duplicates and save (#11208)
* Extract controller into it's own class. Implement find dupes and filter based on username.

Create edit login controller. Add text watchers and check for duplicates.

Edit controller test

* Find duplicates and save to store

* Retrieve duplicates from AC and check list on username text changed

Move duplicates logic into the controller

* Add glean pings for delete and edit. Move logic for login manipulation into the datastore.

* Use correct threads in controller. Enable save button when applicable.

Save enabled in datastore.

Move login data to datastore

Rebase with password error states

Update metrics to be more specific for edit

* Create logins controller for AC calls

* Interactor and controller methods for edit login. Add edit view to separate out some layout manipulation.

Inflate view in edit fragment. Double layout showing up.

Edit view

Controller tests

Controller tests passing

Interactor tests

Lint and detekt cleanup

* Remove datastore and use storage controller for all logins calls to password storage.

Addressed comments

Lint
:

Rebase - 1
2020-07-16 17:08:04 -05:00
..
about Test settings about/advanced (#12023) 2020-06-26 15:53:30 -07:00
account For #12107: Follow ux mock on Settings --> Account screen 2020-07-14 12:25:21 +03:00
advanced For #12565: Add Locale settings tests & use activity (#12579) 2020-07-16 11:43:27 -07:00
deletebrowsingdata For #9229: Remember options for delete browsing data. 2020-06-19 09:32:37 +03:00
logins For #10173: login duplicates and save (#11208) 2020-07-16 17:08:04 -05:00
quicksettings Test settings about/advanced (#12023) 2020-06-26 15:53:30 -07:00
search Add method to test fragments in roboletric (#12261) 2020-07-06 13:04:43 -07:00
sitepermissions Add method to test fragments in roboletric (#12261) 2020-07-06 13:04:43 -07:00
AccessibilityFragment.kt Replace nullable findPreference 2020-06-18 09:02:58 -04:00
CustomizationFragment.kt Extract radio group logic into helper (#11493) 2020-07-06 17:09:42 -07:00
DataChoicesFragment.kt Replace nullable findPreference 2020-06-18 09:02:58 -04:00
DefaultBrowserPreference.kt Issue #7425 (et al): Cache the list of installed browsers 2020-01-07 18:40:07 -08:00
DropDownListPreference.kt For #8565: Fix updating dropdown preferences in ETP settings! (#8573) 2020-02-24 18:07:02 -08:00
Extensions.kt Add tests for OnSharedPreferenceChangeListener (#12019) 2020-06-26 11:04:46 -07:00
OnSharedPreferenceChangeListener.kt Clean up settings fragments 2019-12-19 14:29:28 -08:00
PairFragment.kt For #6198: Update copy and position of pair QR code scan message. 2020-05-25 17:53:20 -04:00
PhoneFeature.kt Add tests for PhoneFeature (#12021) 2020-06-26 12:12:52 -07:00
PrivateBrowsingFragment.kt For #11534 - Don't check lastUsed mode for screenshots (#11827) 2020-06-22 17:38:58 -07:00
RadioButtonInfoPreference.kt For #7725: Increase info button touch target while keeping size. 2020-06-05 11:57:17 +03:00
RadioButtonPreference.kt Extract radio group logic into helper (#11493) 2020-07-06 17:09:42 -07:00
SecretSettingsFragment.kt Test settings about/advanced (#12023) 2020-06-26 15:53:30 -07:00
SettingsFragment.kt Replace nullable findPreference 2020-06-18 09:02:58 -04:00
SharedPreferenceUpdater.kt Only use Context.settings() function (not getter) (#5335) 2019-09-24 10:33:46 -07:00
StringSharedPreferenceUpdater.kt For #8565: Fix updating dropdown preferences in ETP settings! (#8573) 2020-02-24 18:07:02 -08:00
SupportUtils.kt Issue #12207 - Update "new nightly" link to point to org.mozilla.fenix (#12209) 2020-07-02 12:39:44 -07:00
TextPercentageSeekBarPreference.kt For #10049: Provide correct seek bar value to screen readers. 2020-06-22 13:58:33 -04:00
TrackingProtectionFragment.kt For #7094 - Adds save login exceptions 2020-07-14 14:47:37 -04:00