1
0
Fork 0
fenix/app/src/main/java/org/mozilla/fenix
Elise Richards 023a4983fa
For #10173: login duplicates and save (#11208)
* Extract controller into it's own class. Implement find dupes and filter based on username.

Create edit login controller. Add text watchers and check for duplicates.

Edit controller test

* Find duplicates and save to store

* Retrieve duplicates from AC and check list on username text changed

Move duplicates logic into the controller

* Add glean pings for delete and edit. Move logic for login manipulation into the datastore.

* Use correct threads in controller. Enable save button when applicable.

Save enabled in datastore.

Move login data to datastore

Rebase with password error states

Update metrics to be more specific for edit

* Create logins controller for AC calls

* Interactor and controller methods for edit login. Add edit view to separate out some layout manipulation.

Inflate view in edit fragment. Double layout showing up.

Edit view

Controller tests

Controller tests passing

Interactor tests

Lint and detekt cleanup

* Remove datastore and use storage controller for all logins calls to password storage.

Addressed comments

Lint
:

Rebase - 1
2020-07-16 17:08:04 -05:00
..
addons For #12600 - remove AddonInstalled event when the permission dialog is shown (#12601) r=csadilek,sblatz 2020-07-16 19:40:39 +01:00
browser For #7094 - Adds save login exceptions 2020-07-14 14:47:37 -04:00
cfr For #12157: Don't show two search widget dialogs 2020-07-02 11:22:18 -07:00
collections For #11943: Fix intermittent coroutine failure (#12027) 2020-06-26 15:42:53 -07:00
components For #10173: login duplicates and save (#11208) 2020-07-16 17:08:04 -05:00
crashes Integrate activity for showing past crashes. 2020-05-12 09:14:20 +02:00
customtabs Update Android Components version to 49.0.20200705130154. 2020-07-06 15:21:40 -04:00
downloads For #8775: Removes feature flag for dynamic bottom toolbar 2020-06-09 20:58:17 -07:00
ext No issue: Delete unnecessary to-dos (#12603) 2020-07-16 13:38:07 -05:00
home Address review comments 2020-07-16 10:37:03 -04:00
library For #10173: login duplicates and save (#11208) 2020-07-16 17:08:04 -05:00
loginexceptions For #7094 - Adds save login exceptions 2020-07-14 14:47:37 -04:00
media Update to new feature-media API. 2020-03-29 23:13:13 -07:00
migration Update Kotlin dependency (#10806) 2020-07-15 18:02:58 -07:00
onboarding Extract radio group logic into helper (#11493) 2020-07-06 17:09:42 -07:00
perf Add tests for StartupReportFullyDrawn (#12560) 2020-07-15 23:31:59 -07:00
push Use new AuotPushFeature.getSubscription API 2020-05-29 22:21:31 -04:00
search Fix nav graph and theme tests (#12567) 2020-07-15 18:04:36 -07:00
session For #9100: Follow-up to fix memory leak in NotificationSessionObserver 2020-06-25 16:17:38 -04:00
settings For #10173: login duplicates and save (#11208) 2020-07-16 17:08:04 -05:00
share For #11798: Allow sharing of reader view pages 2020-06-25 14:39:21 -04:00
shortcut Added A-C version 48.0.20200626213814 2020-06-26 19:59:57 -04:00
sync Add tests for sync, wifi, and push (#12581) 2020-07-16 12:25:38 -07:00
tabtray Update TabTrayViewHolder with A-C thumbnail changes. 2020-07-16 12:50:33 -04:00
theme For #8374 - Don't recreate ExternalAppBrowserActivity or finishing activities 2020-06-04 16:44:07 -04:00
trackingprotection Update Android Components version to 49.0.20200705130154. 2020-07-06 15:21:40 -04:00
trackingprotectionexceptions Add helper for underlining text (#12520) 2020-07-15 22:38:46 -07:00
utils For #10173: login duplicates and save (#11208) 2020-07-16 17:08:04 -05:00
whatsnew Fixes #9832 - Change targetSdkVersion to Android 10 (#11014) 2020-07-09 10:50:51 -07:00
widget Feature/#220 language menu (#7070) 2020-01-03 18:15:35 -08:00
wifi Add tests for sync, wifi, and push (#12581) 2020-07-16 12:25:38 -07:00
AppRequestInterceptor.kt For #12118: Add isSubframeRequest parameter for app links 2020-07-16 12:50:33 -04:00
BrowserDirection.kt For #12503: Open addon permissions link in app. 2020-07-15 10:04:40 -04:00
Config.kt Bug 1649400 - part 1: ship org.mozilla.fenix as a nightly product (#12127) 2020-07-01 11:03:10 +02:00
ExperimentsManager.kt For #9488: Add experimentation support 2020-06-04 14:10:22 -07:00
FeatureFlags.kt No issue: Remove feature flag for tips (#12172) 2020-07-01 14:47:40 -07:00
FenixApplication.kt Update Kotlin dependency (#10806) 2020-07-15 18:02:58 -07:00
GlobalDirections.kt Add deep links for settings and home screens 2020-07-16 10:37:03 -04:00
HomeActivity.kt For #10173: login duplicates and save (#11208) 2020-07-16 17:08:04 -05:00
IntentReceiverActivity.kt Added A-C version 48.0.20200626213814 2020-06-26 19:59:57 -04:00
NavHostActivity.kt Add method to test fragments in roboletric (#12261) 2020-07-06 13:04:43 -07:00
StrictModeManager.kt Add tests for StrictModeManager (#12013) 2020-06-29 08:17:07 -07:00