1
0
Fork 0
Commit Graph

232 Commits (f49331de55194a33c2ac1a317d9fc5abf880b6e0)

Author SHA1 Message Date
ekager f49331de55 For #5544: Bare Minimum Logins UI 2019-10-24 10:29:03 -07:00
Sawyer Blatz 2cba624609
No issue: Fixes string issues for l10n (#6158)
Issues found here: https://github.com/mozilla-l10n/android-l10n/pull/89
2019-10-24 08:24:19 -07:00
ValentinTimisica 485ccba189 Fixes #5323: Show a snackbar while browsing data is deleting. (#6105) 2019-10-21 09:57:06 -07:00
Mihai Branescu 2be4d08228 For #6018 - Added back shortcuts button in awesomebar
Refactored logic for adding providers, since shortcut providers should
be alone in the list, while all others can be as list
2019-10-18 14:48:58 +03:00
Mihai Branescu 1490c0178f For #5749 - Update string for ETP onboarding popup 2019-10-15 15:56:59 +03:00
MozLando bb22fb3092 Merge #5507 #5846
5507: For #1383 Added tab title to close button content description r=ekager a=mcarare


### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [x] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features

### After merge
- [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones) of the version currently in development.

### To download an APK when reviewing a PR:
1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture

5846: For #3604 Snackbar messages for closing tabs use closed instead of deleted r=sblatz a=mcarare


### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [x] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [x] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features

### After merge
- [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones) of the version currently in development.

### To download an APK when reviewing a PR:
1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture

Co-authored-by: mcarare <mihai.carare.dev@gmail.com>
2019-10-11 16:28:36 +00:00
mcarare 788e52be0c For #5873 Added on/off indicator for delete browsing data on exit pref 2019-10-09 11:55:37 +03:00
mcarare 1c6aefd82b For #3604 Snackbar messages for closing tabs use closed instead of deleted 2019-10-08 17:06:02 +03:00
Sawyer Blatz 371e2ac3d8
For #514 & #5742: Updates "launch links in private tab" functionality (#5721)
* For #514 & #5742: Updates "launch links in private tab" functionality

* Fixes comments
2019-10-03 12:43:33 -07:00
Sawyer Blatz 097d7c2038
For #5742: Adds strings (#5743) 2019-10-03 09:32:50 -07:00
Sawyer Blatz 785b8b9519
For #5567: Removes search shortcuts button (#5739)
* For #5567: Removes search shortcut button

* No issue: Simplifies logic for displaying shortcuts
2019-10-03 08:53:16 -07:00
Colin Lee de93b05cac For #2754 Add tab cards to share sheet (#5493)
* For #2754 Add tab cards to share sheet

* For #2754: Fix background near rounded corners and ShareButtonAppearanceTest

* Add license to share_tab_item
2019-09-26 14:25:34 -07:00
Mugurell c5330c6880 For 5092 - Show a Snackbar with retry option if sharing to devices fails (#5158)
* For #5092 - Show a Snackbar with retry option if sharing to devices fails

ShareController will contain all the business logic for checking the result
status of the `share to device` operations. When this fails it will show a
snackbar which also offer the possibility to retry the just failed operation.
To allow this even in the event the user has closed the share fragment we'll
use a GlobalScope's coroutine.
Refactored out the TabsSharedCallback from ShareFragment because otherwise we
would have neede to sent through that the just failed operation. After the
refactor the ShareController is solely responsable for showing the right
snackbar and handling the retry actions.

* For #5092 - Refactor ShareControllerTest

* For #5092: Adds color theming of snackbars
2019-09-26 12:30:28 -07:00
Yeon Taek Jeong 59e2c124cb No issue: Update long-press shortcut strings (#5284)
* No issue: Update long-press shortcut strings

* Updates identifiers
2019-09-26 11:57:37 -07:00
mcarare bfe8bf4663 For #1383 Added tab title to close button content description 2019-09-25 10:34:02 +03:00
Mihai Adrian c7c752cabb For #5356 Improves private browsing "common myths" link accessibility (#5479)
Added separate TextView for link text
Used UnderlineSpan to show text as link
Split string private_browsing_placeholder, one for each TextView
Set clickListener on TextView so it can be accessed via Talkback
2019-09-24 10:46:34 -07:00
mihai-adrian 47064a68e0 For #5141 Changed "learn more" link to be accessible to Talkback users 2019-09-20 12:29:02 -07:00
Sawyer Blatz 6f3d7b4ee8 For #5396: Adds "always launch in private mode" to settings 2019-09-20 08:33:07 -07:00
Colin Lee 1aa4f5a519 For #255: Toggle Media Autoplay 2019-09-19 15:13:04 -07:00
Jeff Boek 976c840047 For #3077 - Replaces connect another device dialog with a scree 2019-09-18 17:24:43 -07:00
Sawyer Blatz 50cd2920d3
For #5371: Updates search engine settings string (#5393) 2019-09-18 11:26:44 -07:00
Emily Kager a68fabd3a7 For #1749 - Update to new ETP Settings Strings (#5395) 2019-09-18 10:36:09 -07:00
Emily Kager 95e4f2d754 No issue: Land strings for login management 2019-09-18 08:06:20 -07:00
Sawyer Blatz e247870b9f
For #5277: Updates string for delete browsing data (#5309) 2019-09-13 10:18:25 -07:00
Mihai Adrian bc16061939 For #3371: Show snackbar message when share fails with crash (#5210) 2019-09-12 09:26:24 -07:00
Emily Kager 80d8c76453 No issue: Land new ETP Strings 2019-09-11 16:11:42 -07:00
Jeff Boek e092dfd684 For #5047 - Addresses nits
- Changes MainScope to viewLifecycleScope
- Fixes string name/comment to better describe what it is
- Adds disabled state to the add button
2019-09-11 16:10:54 -07:00
Jeff Boek d18ec49704 For #5047 - Wires up dialog to webAppUseCases 2019-09-11 16:10:54 -07:00
Sawyer Blatz 53b3f105ca For #4155: Sets pastedText default value 2019-09-11 09:03:17 -07:00
Sawyer Blatz 52fd327bc0 For #4155: Adds tests for browser toolbar popup menu 2019-09-11 09:03:17 -07:00
Sawyer Blatz fdd2b59fb8 For #4155: Adds popup menu for browser toolbar 2019-09-11 09:03:17 -07:00
Sawyer Blatz 2653b5966e
For #964: Adds ability to disable each suggestion provider (#5096)
* For #964: Adds ability to disable each suggestion provider

* Fix nit
2019-09-05 14:45:44 -07:00
Sawyer Blatz 23095ae274 For #4155: Adds strings for long press popup (#5112) 2019-09-04 17:15:06 -07:00
Emily Kager fd1c512b2e No issue: Land strings for delete browsing data on quit 2019-09-04 15:45:10 -07:00
Yeon Taek Jeong fba37ee6e6
For #419: Add strings for "Add private browsing shortcut" feature (#5109) 2019-09-04 15:44:22 -07:00
Jeff Boek c9a8eae031 For i5047 - Adds strings for the add to homescreen dialog 2019-09-04 15:18:44 -07:00
mihai-adrian 0fc42a8a09 For #4892: Replaced straight single quote with curly apostrophe in contractions 2019-09-04 14:10:05 +02:00
Sawyer Blatz 09dcdb079d For #4474: Adds what's new button to home screen menu (#5088)
* For #4474: Adds what's new button to home screen menu

* For #4474: Adds tests for what's new button
2019-09-03 15:16:29 -05:00
Tiger Oakes f740d4382a Closes #773 - Add shortcuts to homescreen (#4925) 2019-08-29 14:45:11 -05:00
Yeon Taek Jeong cc5408d717
For #2053: Add persistent notification to close all private browsing tabs (#4913) 2019-08-28 12:55:24 -07:00
ekager b07df9698a For #4868 - Update content description of tabs button with number of tabs 2019-08-23 09:21:32 -07:00
Emily Kager 44421392bf Adds experiments preferences strings 2019-08-21 19:55:26 -07:00
Emily Kager a6483c528b No issue: Land strings for Delete Browsing Data on Quit 2019-08-21 19:55:26 -07:00
Emily Kager 1b2757be98 No issue: Land new string for delete browsing data prompt (#4859) 2019-08-21 11:17:34 -07:00
Emily Kager aa4ed36e46 No issue: Land new strings for ETP and delete browsing data 2019-08-21 10:59:12 +02:00
Yeon Taek Jeong 6f899c7fb5
For #2834: Delete all Private Tabs redesign (#4787) 2019-08-20 13:10:08 -07:00
Colin Lee a514cb3f8c No issue: Add OSS licenses link to About page 2019-08-07 12:40:10 -07:00
Jeff Boek cf169da2fc For #4557 #3860 - Add string for collection empty state 2019-08-06 21:36:54 -07:00
Emily Kager 0604e9858d Closes #3939 - Adds strings for delete browsing history 2019-08-06 16:06:56 -07:00
Emily Kager b20c381af9 For #1749 - Land ETP Strings 2019-08-06 14:55:47 -07:00