1
0
Fork 0
Commit Graph

29 Commits (ee1f040e537e888a75cedad0abee066dfc7d1b1f)

Author SHA1 Message Date
Tiger Oakes ee1f040e53 No issue: Move signedIn tracking to BookmarksSharedViewModel (#4755) 2019-09-27 08:57:38 -07:00
Tiger Oakes e3c60faf24 Move BookmarkNode extensions to helper class (#4752) 2019-09-24 09:17:29 -07:00
Sawyer Blatz cd533854e6
No issue: Only use iconTint in XML for bookmark menus (#5145) 2019-09-10 09:04:05 -07:00
Grisha Kruglov 231924f5eb Fix breaking services APIs changes 2019-09-05 13:38:15 +02:00
Colin Lee 709588572a
For #5055: Crash when opening bookmarks (#5058) 2019-08-31 17:41:50 -05:00
Mugurell 645674c9bd Closes #4396 - Add a Bookmarks Controller (#4593)
* For #4396 - Rename BookmarkInteractor methods

Following the naming model used in other Interactors this too will use reactive
method names in the form of "on..." instead of the previous imperative model.

Kept the imperative naming model for the methods from `SelectionInteractor` as
they are a new addition and I'm not sure about the future direction.

* For #4396 - Add a BookmarkController

It abstracts the Fragment behavior in a contract through which various
Interactors can inform about the specific View changes and can ask for
modifications in their container Fragment.

This contract and it's implementation - `DefaultBookmarkController` are the
result of extracting the container Fragment's business logic from
`BookmarkFragmentInteractor` in it's own standalone component.

* For #4396 - Refactored Bookmark related tests

Added a new `BookmarkControllerTest` tests class which complements the new
`BookmarkController` to ensure that it properly operates on `BookmarkFragment`

Also refactored the existing `BookmarkFragmentInteractorTest` to accommodate
`BookmarkFragmentInteractor`'s now more specialized behavior.
2019-08-19 08:34:57 -07:00
Nikit Bhandari 671727c3e8 For #4341 use camelCase for views referenced from code 2019-08-03 09:25:55 -07:00
Jonathan Almeida ec96d134ff No issue: Fix breaking AccountObserver API 2019-08-02 13:40:50 -04:00
Tiger Oakes 2467588c4a Create shared custom view for library items 2019-07-30 12:26:15 -04:00
Tiger Oakes c2e6e25bef Fixes #4005 - Move getColorFromAttr to Context 2019-07-26 16:44:11 -04:00
Colin Lee 3dc20543e3
For #4128: Migrate Bookmarks to LibState (#4254) 2019-07-25 21:55:51 -05:00
Tiger Oakes ef8d9604ae No issue: Normalize license header comment (#3909) 2019-07-12 11:38:15 -07:00
Grisha Kruglov fe51bbcf7b Update FxA integration to new APIs 2019-07-11 13:19:37 +02:00
Colin Lee 6bb67a9de7
For #3364: Set bookmark root titles onResume (#3828) 2019-07-03 13:13:53 -05:00
Tiger Oakes 30930cdc88 Import variables referred to by path 2019-06-25 13:57:34 -07:00
Tiger Oakes d01bb8c442 Use lifecycleScope for collections fragments 2019-06-25 13:56:15 -07:00
Colin Lee 94e99cf877
For #3364: Edit bookmarks should show corrected bookmarks tree (#3446) 2019-06-25 14:19:33 -05:00
Colin Lee f1088222b4
For #3203: Updates edit bookmarks to have user friendly names (#3372)
Co-authored-by: Colin Lee <mncolinlee@gmail.com>
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>"
2019-06-12 14:10:43 -05:00
Colin Lee 1e6da54263 For #3238: fixes race condition crash, nav destination unknown 2019-06-06 15:46:34 -07:00
Jeff Boek f26c402f0a For #2395 - Properly takes you back to where you start authentication on completion 2019-06-05 10:47:21 -07:00
Sawyer Blatz b8c04e02e9 For #2327: Fixes nits 2019-05-30 11:45:39 -07:00
Sawyer Blatz fe50e88fc8 For #2327: Adds error state syncing 2019-05-30 11:45:39 -07:00
Sawyer Blatz 334868c283 For #2224: Removes select bookmark and fixes crash 2019-05-15 11:46:46 -07:00
Jeff Boek c5e5ef4b25
Teases apart ViewModel dependencies (#2499)
* No Issue - pulls render outside of the viewmodel

* No Issue - Properly subscribes to the changesObservable

* No Issue - Fixes ViewModel tests
2019-05-14 23:16:48 -07:00
Colin Lee ccbc14a71f For #1994: Re-architect state handling code (#2382) 2019-05-09 23:06:12 +00:00
Sawyer Blatz 46924544b6 For #1975 & #1627: Refactors getSessionById in BrowserFragment 2019-04-25 16:51:03 -07:00
Sawyer Blatz 29832c5e84 For #724: Consolidates colors 2019-04-15 12:22:03 -05:00
Emily Kager d7272d29de For #1408 - Set Toolbar titles in code (vs in navgraph) 2019-04-09 16:36:14 -07:00
Colin Lee b54d4d1d58 Closes #1312, #1236, #1237, #1238, #1239: Creating, Editing, and Deleting Bookmarks and Bookmark Folders 2019-04-08 14:48:36 -05:00