1
0
Fork 0
Commit Graph

26 Commits (e601fe7c9f92e78962210c1551a1ebf06f5a9ead)

Author SHA1 Message Date
Jeff Boek e601fe7c9f For #4326 - Updates codebase to support latest version of ktlint 2019-08-21 13:50:51 -07:00
Emily Kager c1b1c2f332 For #3967 - Invokes pending deletion with more bookmark actions (#4522) 2019-08-21 08:36:41 -07:00
Mugurell 645674c9bd Closes #4396 - Add a Bookmarks Controller (#4593)
* For #4396 - Rename BookmarkInteractor methods

Following the naming model used in other Interactors this too will use reactive
method names in the form of "on..." instead of the previous imperative model.

Kept the imperative naming model for the methods from `SelectionInteractor` as
they are a new addition and I'm not sure about the future direction.

* For #4396 - Add a BookmarkController

It abstracts the Fragment behavior in a contract through which various
Interactors can inform about the specific View changes and can ask for
modifications in their container Fragment.

This contract and it's implementation - `DefaultBookmarkController` are the
result of extracting the container Fragment's business logic from
`BookmarkFragmentInteractor` in it's own standalone component.

* For #4396 - Refactored Bookmark related tests

Added a new `BookmarkControllerTest` tests class which complements the new
`BookmarkController` to ensure that it properly operates on `BookmarkFragment`

Also refactored the existing `BookmarkFragmentInteractorTest` to accommodate
`BookmarkFragmentInteractor`'s now more specialized behavior.
2019-08-19 08:34:57 -07:00
Grisha Kruglov 634ee184a6 No issue: add some BookmarkFragmentInteractor tests 2019-08-09 17:27:58 -07:00
Sawyer Blatz da06b0fb15
For #4508: Treats warnings as errors (#4543) 2019-08-07 14:00:53 -07:00
Tiger Oakes 3c1ce90f6f Fixes #2379 - Generic library selection 2019-08-06 11:10:50 -07:00
Colin Lee 33e881ca8a For #1539: Only allow delete when folders multi-selected (#4062) 2019-08-02 10:11:21 -07:00
Jeff Boek e7ec6246fd For #4137 - Fixes HistoryStoreTest 2019-07-31 14:35:33 -07:00
Jeff Boek af449c84d5 For #4137 - Fixes HistoryInteractorTest 2019-07-31 14:35:33 -07:00
Colin Lee 3dc20543e3
For #4128: Migrate Bookmarks to LibState (#4254) 2019-07-25 21:55:51 -05:00
Emily Kager ae3d187909 For #3987 - Convert History to Lib-State and add tests 2019-07-17 17:23:09 -07:00
Tiger Oakes ef8d9604ae No issue: Normalize license header comment (#3909) 2019-07-12 11:38:15 -07:00
Colin Lee 15d887e41f
For #2251 - Add bookmark adapter diffutil (#3936)
* For #2251 - Add bookmark adapter diffutil

* For #2251 - Fix unit tests for bookmark adapter diffutil
2019-07-08 14:00:25 -05:00
Colin Lee f1088222b4
For #3203: Updates edit bookmarks to have user friendly names (#3372)
Co-authored-by: Colin Lee <mncolinlee@gmail.com>
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>"
2019-06-12 14:10:43 -05:00
Jeff Boek c5e5ef4b25
Teases apart ViewModel dependencies (#2499)
* No Issue - pulls render outside of the viewmodel

* No Issue - Properly subscribes to the changesObservable

* No Issue - Fixes ViewModel tests
2019-05-14 23:16:48 -07:00
Sawyer Blatz e1cdeffe8c
For #563: Restyles history management (#2378) 2019-05-10 09:58:54 -07:00
Colin Lee ccbc14a71f For #1994: Re-architect state handling code (#2382) 2019-05-09 23:06:12 +00:00
Colin Lee 78f8354fbb Fix build breakage over FragmentScenario integration 2019-05-08 10:27:24 -05:00
Colin Lee 96b68948b5
For #1710: Create scaffolding for Robolectric tests (#2282) 2019-05-07 16:36:37 -05:00
Colin Lee a60d2c071c
For #1967: Multi-selection toolbar should disappear after deleting (#2202) 2019-05-01 13:51:37 -05:00
Colin Lee bc1b7e0b43 For #1539: Add bookmark multi-select features 2019-04-12 13:35:28 -05:00
Colin Lee b54d4d1d58 Closes #1312, #1236, #1237, #1238, #1239: Creating, Editing, and Deleting Bookmarks and Bookmark Folders 2019-04-08 14:48:36 -05:00
Grisha Kruglov 0bcad0d364 History UI limits: visit type & time
These are temporary limitations to make History UI somewhat functional,
until we get relevant UI and API changes in place.
2019-04-04 16:16:45 -07:00
Colin Lee bd81e72239 Fixes #916, fixes #917, fixes #920: Save, share, and delete bookmarks 2019-04-01 16:16:08 -05:00
Jeff Boek 9227f67545 Fixes HsitoryCOmponentTest 2019-03-25 16:04:19 -05:00
Colin Lee 5cf61c95db Fixes #589: Add sample unit tests for a component 2019-02-20 09:20:40 -08:00