Suraj Shah
66a8c04967
Fixes #4488 : Shows snackbar on bookmark deletion from edit fragment ( #4792 )
...
* Fixes #4488
Updates changelog
* Removes wildcard imports.
* Removes custom label in use, replaces with let
2019-08-28 10:12:39 -07:00
Emily Kager
a65f220b39
For #4921 - Adds WindowFeature to BaseBrowserFragment
2019-08-27 15:33:59 -04:00
Sourabh
091778a4b9
For #4398 - add HistoryController ( #4837 )
2019-08-27 10:33:40 -07:00
ekager
ffbbe119f3
For #3967 - Invoke pending deletion on back pressed
2019-08-23 15:32:27 -04:00
Tiger Oakes
c475bc87cf
Move classes out of top-level package
2019-08-21 13:52:30 -07:00
Jeff Boek
68f5d211d3
For #4326 - Updates codebase to support latest version of detekt
2019-08-21 13:50:51 -07:00
Emily Kager
c1b1c2f332
For #3967 - Invokes pending deletion with more bookmark actions ( #4522 )
2019-08-21 08:36:41 -07:00
Mugurell
645674c9bd
Closes #4396 - Add a Bookmarks Controller ( #4593 )
...
* For #4396 - Rename BookmarkInteractor methods
Following the naming model used in other Interactors this too will use reactive
method names in the form of "on..." instead of the previous imperative model.
Kept the imperative naming model for the methods from `SelectionInteractor` as
they are a new addition and I'm not sure about the future direction.
* For #4396 - Add a BookmarkController
It abstracts the Fragment behavior in a contract through which various
Interactors can inform about the specific View changes and can ask for
modifications in their container Fragment.
This contract and it's implementation - `DefaultBookmarkController` are the
result of extracting the container Fragment's business logic from
`BookmarkFragmentInteractor` in it's own standalone component.
* For #4396 - Refactored Bookmark related tests
Added a new `BookmarkControllerTest` tests class which complements the new
`BookmarkController` to ensure that it properly operates on `BookmarkFragment`
Also refactored the existing `BookmarkFragmentInteractorTest` to accommodate
`BookmarkFragmentInteractor`'s now more specialized behavior.
2019-08-19 08:34:57 -07:00
Grisha Kruglov
b38b94ed79
Closes #4671 : Fix a potential NPE in BookmarkFragment
2019-08-12 11:16:28 -04:00
Grisha Kruglov
634ee184a6
No issue: add some BookmarkFragmentInteractor tests
2019-08-09 17:27:58 -07:00
Grisha Kruglov
f323105163
No issue: reduce code duplication in BookmarkFragmentInteractor
2019-08-09 17:27:58 -07:00
Tiger Oakes
52542708aa
Consodilate private browsing code
2019-08-09 11:00:41 -07:00
Sawyer Blatz
da06b0fb15
For #4508 : Treats warnings as errors ( #4543 )
2019-08-07 14:00:53 -07:00
Emily Kager
8194e0778e
For #4026 - Update BookmarkDiffUtil to update on Title or URL change
2019-08-07 00:37:16 -04:00
Emily Kager
0604e9858d
Closes #3939 - Adds strings for delete browsing history
2019-08-06 16:06:56 -07:00
ValentinTimisica
71aedc79fe
Fixes #3922 : Added accessibility announcement for history empty state.
...
Sent an announcement when the list becomes empty in order to tell the user
that there is no history.
2019-08-06 12:32:59 -07:00
Emily Kager
23bc8f4320
Fro #4563 - Update delete button alpha when history mode changes
2019-08-06 12:26:25 -07:00
Tiger Oakes
3c1ce90f6f
Fixes #2379 - Generic library selection
2019-08-06 11:10:50 -07:00
Emily Kager
6f7ae227a8
Closes #4540 - Set correct tint for select bookmark folder icon ( #4541 )
2019-08-05 14:54:39 -07:00
Emily Kager
a526e0fad3
For #4455 - Rename history headers by hours and days ( #4478 )
2019-08-05 11:12:22 -05:00
Sören Hentzschel
bfd4849064
For #1427 - enter multi select mode with single click on favicon in library
2019-08-03 16:43:51 -07:00
Nikit Bhandari
671727c3e8
For #4341 use camelCase for views referenced from code
2019-08-03 09:25:55 -07:00
Tiger Oakes
6e2ea0750e
Issue #2379 - Use LibrarySiteItemView in history
2019-08-02 17:15:41 -07:00
mihai-adrian
bac2e40eb2
fixes #4435 - changed title of menuitem for delete and added content description
...
setting menu title should also set content description. I added the setContentDescription programmatically in order to ensure that the content description is being set. If content description matches title it won't be read twice
2019-08-02 17:09:24 -07:00
Jonathan Almeida
ec96d134ff
No issue: Fix breaking AccountObserver API
2019-08-02 13:40:50 -04:00
Colin Lee
33e881ca8a
For #1539 : Only allow delete when folders multi-selected ( #4062 )
2019-08-02 10:11:21 -07:00
Tiger Oakes
c342a680d8
Fix crash for bookmarks
2019-08-01 18:57:35 -04:00
Emily Kager
d42e72fd8b
Closes #4462 - Adjust layout params of select bookmark folder view
2019-08-01 13:31:13 -07:00
Tiger Oakes
ccae66c08a
Issue #2379 - Use LibraryPageView in history
2019-08-01 15:59:55 -04:00
Jeff Boek
2813a3cff7
For #4441 - Keeps the ID 0 based for the recyclerview
2019-08-01 10:45:23 -07:00
Jeff Boek
a75c2f7cfb
No Issue - Fixes the offset key to prevent endless history bug
2019-07-31 17:58:56 -07:00
Jeff Boek
af449c84d5
For #4137 - Fixes HistoryInteractorTest
2019-07-31 14:35:33 -07:00
ekager
4494e40dbc
For #4137 - Adds pagination to the history view
2019-07-31 14:35:33 -07:00
Tiger Oakes
2467588c4a
Create shared custom view for library items
2019-07-30 12:26:15 -04:00
James Hugman
ac359f6970
Closes #1331 - Filter consecutive history items using simplified URL
2019-07-29 17:22:19 -04:00
Tiger Oakes
88c05a5f43
Use glide-like image loading function
2019-07-29 10:22:23 -07:00
Tiger Oakes
c2e6e25bef
Fixes #4005 - Move getColorFromAttr to Context
2019-07-26 16:44:11 -04:00
Christian Sadilek
1846a61475
For #4096 : Use new A-C API to observe store / state changes
...
With this we can remove the `whenStarted` workaround. This new API
internally creates (and uses) a scope bound to the fragment's view and
will not invoked the lambda (send state updates) when the view is
detached or the fragment's lifecylce is stopped or destroyed.
2019-07-26 10:40:33 -04:00
Colin Lee
3dc20543e3
For #4128 : Migrate Bookmarks to LibState ( #4254 )
2019-07-25 21:55:51 -05:00
ValentinTimisica
4747f2c165
Fixes #4161 : Modified style of bookmark_folders_sign_in button. ( #4291 )
...
To make this match the style of the other button I applied the same style to it
and also changed it to be a MaterialButton.
I also decided to extract the margin and padding values of the button.
2019-07-25 14:10:11 -05:00
Tiger Oakes
edb0a3ed08
For #3633 - Update StoreProvider to use a callback
...
Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
2019-07-18 18:16:49 -04:00
Sawyer Blatz
9251597e84
For #2362 : Fixes telemetry for history ( #4156 )
2019-07-18 13:36:52 -07:00
Emily Kager
ae3d187909
For #3987 - Convert History to Lib-State and add tests
2019-07-17 17:23:09 -07:00
Emily Kager
8381025ac5
For #2160 - Hide Keyboard in onPause from EditBookmarkFragment
2019-07-17 09:20:28 -07:00
Sawyer Blatz
11d36b5a00
For #2362 : Adds telemetry for history ( #3940 )
2019-07-16 12:21:03 -07:00
Emily Kager
6b4c160d18
Closes #4080 - Trim New Bookmark Folder Title Text
2019-07-16 11:02:36 -07:00
Tiger Oakes
52d4c43916
Merge some library UIView code for toolbar
2019-07-16 09:27:30 -07:00
ekager
706f7d5961
For #3554 - Add DiffUtil to HistoryAdapter
2019-07-15 13:46:21 -07:00
Tiger Oakes
ef8d9604ae
No issue: Normalize license header comment ( #3909 )
2019-07-12 11:38:15 -07:00
Grisha Kruglov
fe51bbcf7b
Update FxA integration to new APIs
2019-07-11 13:19:37 +02:00