cb129231ae
Closes #11500 : Remove wrong activity title
2020-06-19 18:17:35 +03:00
c4e83367f6
For #6832 - Fix various fragment not attached to a context crashes
2020-04-22 20:56:35 -07:00
853a0acab4
Closes #4046 : Always display 'Desktop' bookmarks folder
...
See https://github.com/mozilla-mobile/fenix/issues/4046 for a detailed discussion of this.
In short, this patch removes code that would conditionally hide desktop bookmarks depending
on the signed-in state of the browser.
2020-04-17 23:57:43 -07:00
e318cd7d15
fix #8135 - remove getColorFromAttr
2020-03-02 15:48:33 -07:00
43354489a1
For #7253 - Replace anko setters
2019-12-19 13:42:50 -08:00
e727ae5d7e
Fix 5366 - Use VectorDrawableCompat for all imagery ( #7221 )
...
* Fix 5366 - Use VectorDrawableCompat for all imagery
* Fix detekt lint issues
* Restore previous comment contents
2019-12-16 20:35:36 -08:00
422faaf7c0
Add toolbar helpers ( #6531 )
2019-11-25 15:36:47 -05:00
e55eda30fb
For #3563 . Use `ListAdapter` for Bookmark folder selection list.
2019-10-07 10:40:55 -07:00
ee1f040e53
No issue: Move signedIn tracking to BookmarksSharedViewModel ( #4755 )
2019-09-27 08:57:38 -07:00
e3c60faf24
Move BookmarkNode extensions to helper class ( #4752 )
2019-09-24 09:17:29 -07:00
cd533854e6
No issue: Only use iconTint in XML for bookmark menus ( #5145 )
2019-09-10 09:04:05 -07:00
231924f5eb
Fix breaking services APIs changes
2019-09-05 13:38:15 +02:00
709588572a
For #5055 : Crash when opening bookmarks ( #5058 )
2019-08-31 17:41:50 -05:00
645674c9bd
Closes #4396 - Add a Bookmarks Controller ( #4593 )
...
* For #4396 - Rename BookmarkInteractor methods
Following the naming model used in other Interactors this too will use reactive
method names in the form of "on..." instead of the previous imperative model.
Kept the imperative naming model for the methods from `SelectionInteractor` as
they are a new addition and I'm not sure about the future direction.
* For #4396 - Add a BookmarkController
It abstracts the Fragment behavior in a contract through which various
Interactors can inform about the specific View changes and can ask for
modifications in their container Fragment.
This contract and it's implementation - `DefaultBookmarkController` are the
result of extracting the container Fragment's business logic from
`BookmarkFragmentInteractor` in it's own standalone component.
* For #4396 - Refactored Bookmark related tests
Added a new `BookmarkControllerTest` tests class which complements the new
`BookmarkController` to ensure that it properly operates on `BookmarkFragment`
Also refactored the existing `BookmarkFragmentInteractorTest` to accommodate
`BookmarkFragmentInteractor`'s now more specialized behavior.
2019-08-19 08:34:57 -07:00
6f7ae227a8
Closes #4540 - Set correct tint for select bookmark folder icon ( #4541 )
2019-08-05 14:54:39 -07:00
671727c3e8
For #4341 use camelCase for views referenced from code
2019-08-03 09:25:55 -07:00
ec96d134ff
No issue: Fix breaking AccountObserver API
2019-08-02 13:40:50 -04:00
d42e72fd8b
Closes #4462 - Adjust layout params of select bookmark folder view
2019-08-01 13:31:13 -07:00
2467588c4a
Create shared custom view for library items
2019-07-30 12:26:15 -04:00
c2e6e25bef
Fixes #4005 - Move getColorFromAttr to Context
2019-07-26 16:44:11 -04:00
3dc20543e3
For #4128 : Migrate Bookmarks to LibState ( #4254 )
2019-07-25 21:55:51 -05:00
ef8d9604ae
No issue: Normalize license header comment ( #3909 )
2019-07-12 11:38:15 -07:00
fe51bbcf7b
Update FxA integration to new APIs
2019-07-11 13:19:37 +02:00
9901514766
Replace deprecated pxToDp ( #3932 )
2019-07-08 14:45:07 -05:00
6bb67a9de7
For #3364 : Set bookmark root titles onResume ( #3828 )
2019-07-03 13:13:53 -05:00
4994554576
No issue: Adds lint exception for when statement ( #3685 )
2019-06-26 15:52:24 -07:00
30930cdc88
Import variables referred to by path
2019-06-25 13:57:34 -07:00
d01bb8c442
Use lifecycleScope for collections fragments
2019-06-25 13:56:15 -07:00
94e99cf877
For #3364 : Edit bookmarks should show corrected bookmarks tree ( #3446 )
2019-06-25 14:19:33 -05:00
e458d8b6a1
Fixes #3365 - Set selectedFolder to null if it's already selected ( #3415 )
2019-06-13 10:52:35 -05:00
f1088222b4
For #3203 : Updates edit bookmarks to have user friendly names ( #3372 )
...
Co-authored-by: Colin Lee <mncolinlee@gmail.com>
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>"
2019-06-12 14:10:43 -05:00
1e6da54263
For #3238 : fixes race condition crash, nav destination unknown
2019-06-06 15:46:34 -07:00
f26c402f0a
For #2395 - Properly takes you back to where you start authentication on completion
2019-06-05 10:47:21 -07:00
b8c04e02e9
For #2327 : Fixes nits
2019-05-30 11:45:39 -07:00
fe50e88fc8
For #2327 : Adds error state syncing
2019-05-30 11:45:39 -07:00
7d9c8726c5
treewide: Resolve compilation warnings ( #2859 )
...
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
2019-05-27 19:04:17 +02:00
334868c283
For #2224 : Removes select bookmark and fixes crash
2019-05-15 11:46:46 -07:00
c5e5ef4b25
Teases apart ViewModel dependencies ( #2499 )
...
* No Issue - pulls render outside of the viewmodel
* No Issue - Properly subscribes to the changesObservable
* No Issue - Fixes ViewModel tests
2019-05-14 23:16:48 -07:00
ccbc14a71f
For #1994 : Re-architect state handling code ( #2382 )
2019-05-09 23:06:12 +00:00
46924544b6
For #1975 & #1627 : Refactors getSessionById in BrowserFragment
2019-04-25 16:51:03 -07:00
7c00c2983b
No issue: Fix crash on bookmark folder selection and Snackbar color
2019-04-20 15:10:24 -05:00
3b3d4c3de5
Fixes #1646 : Changes bookmarks toolbar color ( #1651 )
2019-04-16 08:03:22 -07:00
29832c5e84
For #724 : Consolidates colors
2019-04-15 12:22:03 -05:00
d7272d29de
For #1408 - Set Toolbar titles in code (vs in navgraph)
2019-04-09 16:36:14 -07:00
b54d4d1d58
Closes #1312 , #1236 , #1237 , #1238 , #1239 : Creating, Editing, and Deleting Bookmarks and Bookmark Folders
2019-04-08 14:48:36 -05:00
Antti Vainikka