1
0
Fork 0
Commit Graph

21 Commits (dd5bb94f8c3c267952bd69939c7d5a21a3c337f1)

Author SHA1 Message Date
ankur dd5bb94f8c For #13301, #13038: hide overflow menu for all bookmark items in selected mode 2020-08-06 09:51:56 -07:00
Kainalu Hagiwara 30c7b5ea5e For #12831 - Disable SwipeRefreshLayout while swiping a bookmark. 2020-08-05 09:00:43 -07:00
Kainalu Hagiwara 5318d64911 For #12906 - Fix swipe-to-delete bookmark folder. 2020-08-05 08:59:26 -07:00
Kainalu Hagiwara cd2532349d For #12551 - Implement swipe to delete for bookmarks. 2020-07-20 14:54:20 -07:00
ValentinTimisica 9f5c8819d3 For #11892: Remove dynamic calls to setupNavigationToolbar
This is a speculative fix for 11892 crash.
The side effect is that the back button will be visible in bookmarks root.
2020-06-26 07:54:11 -04:00
person808 ad90625b48 For #2165 - Add swipe to refresh gesture to bookmarks view. 2020-06-25 14:50:24 -07:00
Hakkı Kaan Çalışkan c8d36ddc36 For #8649: No bookmarks here strings are close to the top 2020-06-22 16:04:20 -04:00
ValentinTimisica c75ab3f720
For #10462: Removes back button from bookmarks and history fragments (#11721) 2020-06-22 13:15:33 -04:00
David Walsh 26137f63a2
Prevent favicons from flashing when items are selected in History (#9233) 2020-04-01 15:43:21 -07:00
Afzal Najam b9656a978e Hide add folder option when in Desktop Bookmarks folder 2019-12-13 17:51:15 -08:00
Jeff Boek 1b1f9348dc No Issue - Fixes warnings / compiler errors with A-C update 2019-11-28 12:45:45 +01:00
mcarare f6a66562dd For #4487 Set activity title only once in Bookmark fragment
Removed label from nav_graph that caused label to be set for each navigation
Removed title setting in onCreate() called for each navigation
Changed logic for checking current root when setting UI for normal mode
2019-11-12 08:21:53 -08:00
Severin Rudie fbdd537bc7 Closes #4513: show progress bar when loading bookmarks 2019-09-26 16:29:14 -07:00
Mihai Adrian c8bc144114 For #2570: Hide 3-dots menu when in select mode for bookmarks and history (#5173)
Show or hide overflow menu for entire list is triggered when mode is changed
For bookmarks, due to implementation of selection and diffUtil,
additional check is necessary for current item (last selected) that is redrawn
2019-09-12 13:56:39 -07:00
Sebastian Kaspari 76063e307a Rename BookmarkStore/State/Action to BookmarkFragmentStore/State/Action. 2019-09-03 10:09:06 -07:00
Mugurell 645674c9bd Closes #4396 - Add a Bookmarks Controller (#4593)
* For #4396 - Rename BookmarkInteractor methods

Following the naming model used in other Interactors this too will use reactive
method names in the form of "on..." instead of the previous imperative model.

Kept the imperative naming model for the methods from `SelectionInteractor` as
they are a new addition and I'm not sure about the future direction.

* For #4396 - Add a BookmarkController

It abstracts the Fragment behavior in a contract through which various
Interactors can inform about the specific View changes and can ask for
modifications in their container Fragment.

This contract and it's implementation - `DefaultBookmarkController` are the
result of extracting the container Fragment's business logic from
`BookmarkFragmentInteractor` in it's own standalone component.

* For #4396 - Refactored Bookmark related tests

Added a new `BookmarkControllerTest` tests class which complements the new
`BookmarkController` to ensure that it properly operates on `BookmarkFragment`

Also refactored the existing `BookmarkFragmentInteractorTest` to accommodate
`BookmarkFragmentInteractor`'s now more specialized behavior.
2019-08-19 08:34:57 -07:00
Tiger Oakes 3c1ce90f6f Fixes #2379 - Generic library selection 2019-08-06 11:10:50 -07:00
Tiger Oakes c342a680d8 Fix crash for bookmarks 2019-08-01 18:57:35 -04:00
Tiger Oakes ccae66c08a Issue #2379 - Use LibraryPageView in history 2019-08-01 15:59:55 -04:00
Tiger Oakes c2e6e25bef Fixes #4005 - Move getColorFromAttr to Context 2019-07-26 16:44:11 -04:00
Colin Lee 3dc20543e3
For #4128: Migrate Bookmarks to LibState (#4254) 2019-07-25 21:55:51 -05:00