1
0
Fork 0
Commit Graph

78 Commits (c52e4fd9f5f157cb5c5da32f7a623c861f68db7b)

Author SHA1 Message Date
Arturo Mejia 6530a45eb9
For issue #11676: Features phone that doesn't a site permission exception shouldn't be shown (#12855)
exception shouldn't be shown
2020-07-23 09:12:22 -07:00
Tiger Oakes c08d375c18
Move settings in components (#12675) 2020-07-21 10:47:10 -07:00
Tiger Oakes 7287b5579f
Test settings about/advanced (#12023) 2020-06-26 15:53:30 -07:00
Tiger Oakes 9a8b800a76 For #8621 - fix intermittent test failures 2020-06-23 17:43:24 -04:00
Tiger Oakes 1a19b06227
Simplify `PhoneFeature` code (#10810) 2020-06-08 13:02:42 -07:00
Dennis Schubert d046d908fc Bug 1643132 - Remove native "Report site issue" functionality.
This will be replaced by the WebCompat team's system extension that ships as an android-component.
2020-06-04 18:23:11 -04:00
apoorv9990 3469eeed9e removed auto play permissions while determining isVisible for WebsitePermissionsState 2020-05-28 16:08:07 -07:00
apoorv9990 97704bfdbd Closes #9529: changed styling for permissions dialog to set proper padding
- Changed the visibility check to check just for the permissions shown instead of all the permissions in WebsitePermissionsState
- Added bottom padding to the permissions root view so there is balanced padding on top and bottom
2020-05-28 16:08:07 -07:00
Arturo Mejia 56bb3e38ec For issue #10142 Update sitePermissions state when toggling its value 2020-04-29 18:33:34 -07:00
ekager c4e83367f6 For #6832 - Fix various fragment not attached to a context crashes 2020-04-22 20:56:35 -07:00
Arturo Mejia 0a23d66756 For issue #7566 Handle deny & don't ask again for site permissions 2020-04-22 11:33:32 -04:00
Jeff Boek 4cbb9aebaf
Cleans up nav_graph.xml (#9829)
* For #9751 - Cleans up homeFragment directions

* For #9751 - Uses global actions for fragments not owned by homeFragment

* For #9751 - Cleans up SearchFragment directions

* For #9751 - Removes settings action from DeleteBrowsingDataFragment

* For #9751 - Removes browser action from SettingsFragment

* For #9751 - Adds ManagePhoneFeature global action

* For #9751 - Clean up unused deletebrowsingfragment actions

* For #9751 - Cleans Up HistoryFragment actions

* For #9751 - Removes Home -> Search action

* For #9751 - Removes the Bookmark -> Browser action

* For #9751 - Cleans up bookmark fragment actions

* For #9751 - Cleans up actions from ShareController

* For #9751 - Removes defaultBrowserFragment to browserFragment action

* For #9751 - Removes about -> browser action

* For #9751 - Adds global action to TrackingProtectionFragment

* For #9751 - Removes exception -> browser action

* For #9751 - Removes login -> browser action

* For #9751 - Fixes LoginFragment directions

* For #9751 - Removes ExternalAppBrowser directions

* for #9751 - Cleans up actions

* For #9751 - Fixes unit tests

* For #9751 - Addresses nits in PR
2020-04-13 21:43:45 -07:00
David Walsh 27502bdd34 For #9177, #8248 - Hide empty verified by block when no cert 2020-03-20 19:40:51 -07:00
Severin Rudie 69c6de7cd4
For #8411: integrate AC permissions changes (#8618) 2020-02-25 07:36:19 -08:00
Jeff Boek a42ad7603b For #5073 - Fixes visual alignment when certificate authority breaks into a new line 2020-02-07 09:10:31 -08:00
Jeff Boek 7a16192fd1 For #5073 - Use string parameter versus concatenating programatically 2020-02-07 09:10:31 -08:00
Kate Glazko 7c00a1ad6b For #5073: View Site Cert 2020-02-07 09:10:31 -08:00
Kadeem f4f93e761e NOISSUE - Renamed a misspelled variable. 2020-02-06 18:25:11 +01:00
Tiger Oakes c0d7bc5bd5 Use navArgs helper in fragments 2020-02-05 16:37:45 -08:00
David Walsh f728cdaf05
Bug 7189 - Provide page title in website information dialog (#7255)
* Bug 7189 - Provide page title in website information dialog

* Update QSFS test

* Fix Tiger's nits
2020-01-30 11:24:53 -08:00
Rushab Kumar e6791b5c08 For #7154 - Fix crash when tapping on "Blocked" in the site info panel (#7404) 2020-01-08 13:51:45 -08:00
David Walsh e727ae5d7e Fix 5366 - Use VectorDrawableCompat for all imagery (#7221)
* Fix 5366 - Use VectorDrawableCompat for all imagery

* Fix detekt lint issues

* Restore previous comment contents
2019-12-16 20:35:36 -08:00
David Walsh c69e72bdba Fix 3809 - Show entire URL in security info view 2019-11-18 14:01:40 -08:00
Emily Kager d9615108ee For #6354 - Removes ETP Experiment, Removes Feature Flags, Sets Strict Default 2019-11-08 08:37:15 -08:00
ekager 18c0525ff6 Use new API for ETP Exceptions 2019-11-05 12:45:58 -08:00
Mugurell c5739df969 For #4126 - Add tests for the new classes resulting from refactoring
Used runBlocking to ensure we wait for the code using coroutines to execute
instead of runBlockingTest and join() since this last option led to failed
tests in CI because of
"java.lang.IllegalStateException: This job has not completed yet".
2019-10-31 17:08:40 -07:00
Mugurell 9f56624788 For #4126 - Document the newly introduced public APIs
Now that the code should be in a ready-to-ship form it would be nice to have
all the major functionalities properly documented.
2019-10-31 17:08:40 -07:00
Mugurell d70afcaa90 For #4126 - Handle all business logic with Interactors and a Controller
Combined all Stores into one for all Views shown in on Fragment.
Used a static `createStore()` which will build the initial state residing
inside the Store and not in the Fragment as to decouple the Fragment from the
business logic needed to build all the needed initial States.
Added Interactors that handle a MVI View's business logic for
TrackingProtectionView and WebsitePermissionsView.
WebsiteInfoView doesn't register any user input events and does not have any
reason to change while it is displayed so it does not have an Interactor.
The two Interactors will delegate Fragment's QuickSettingsController for
complex Android interactions, communication with other app features or for
Store updates.
Also refactored the stubs from the previous commit so that with this commit the
the quicksettings feature should all be working now based on lib-state.
2019-10-31 17:08:40 -07:00
Mugurell f1f74bc3d6 For #4126 - Refactor Views and layouts
Refactored `fragment_quick_settings_dialog_sheet` to now be composed of of
FrameLayouts placeholders in which each independent View will inflate itself.
Refactored the QuickSettingsUIView and Component to 3 standalone Views with
their own lib-state components: Store, State, Actions, Reducer.
2019-10-31 17:08:40 -07:00
shldhll 8e17ac05b1 Optimized imports. Closes #5876 2019-10-10 04:17:43 +05:30
shldhll f907ec52f0 Removed ObsoleteCoroutinesApi in tests. Closes #5876 2019-10-10 04:04:51 +05:30
Tiger Oakes 8c30200ced Only use Context.settings() function (not getter) (#5335)
Remove unused String extensions
2019-09-24 10:33:46 -07:00
Tiger Oakes 05a4faec78 Add tryGetHostFromUrl and update ExceptionDomains 2019-09-19 22:40:35 -04:00
Colin Lee 1aa4f5a519 For #255: Toggle Media Autoplay 2019-09-19 15:13:04 -07:00
Emily Kager 3e132f102c No issue: Update androidx libraries Sept 5 2019 2019-09-17 09:50:31 -07:00
Emily Kager 4485b7f647 Add Tracking Protection Info Panel 2019-09-11 07:47:13 -07:00
Mihai Adrian a31eb1f371 Code Health #4883: Refactored accessing settings by using Context extensions (#4973) 2019-09-10 10:11:58 -07:00
Tiger Oakes aab357845b No issue: Clean up preferences code (#4699) 2019-08-21 08:38:14 -07:00
Tiger Oakes 33f3b14c29 Adds setters and property delegates in `Settings` (#4809)
* Change Settings to use setters

* Add delegate for shared preferences
2019-08-20 10:47:55 -07:00
Tiger Oakes 9ee8c00928 For #4774 - Use vector drawable compat (#4811) 2019-08-20 10:43:02 -07:00
Arturo Mejia 210868f5bc Use Mozilla Android Components 9.0.0-SNAPSHOT. (#4750) 2019-08-19 10:29:10 -07:00
Tiger Oakes 52542708aa Consodilate private browsing code 2019-08-09 11:00:41 -07:00
Colin Lee ef97173cd9
For #4529, #4427: Resuming after restoring instance state breaks UI (#4571)
* For #4529, #4427: Resuming after restoring instance state breaks UI

* Clear up warnings
2019-08-08 11:05:01 -05:00
Nikit Bhandari 46de06d132 For #4339 reduce build warnings (#4340) 2019-07-31 11:43:49 -07:00
Tiger Oakes d1651ecf71 Closes #4012 - Animate quick settings (#4047) 2019-07-30 09:50:50 -07:00
Tiger Oakes 87d8f3b037 Remove redundant super calls 2019-07-29 10:22:53 -07:00
Nikit Bhandari f110ba2861 use synthetic binding instead of findviewbyid 2019-07-19 16:51:26 -04:00
Emily Kager 95367c2b50 For #3521 - Show Quick Settings Dialog Entirely in Landscape 2019-07-17 09:52:01 -07:00
Tiger Oakes ef8d9604ae No issue: Normalize license header comment (#3909) 2019-07-12 11:38:15 -07:00
Arturo Mejia b82340bf1f For #3750: Crash when tapping "Blocked" on Google Maps after disabling
location requests.
2019-06-29 18:39:19 -07:00