1
0
Fork 0
Commit Graph

7 Commits (a04b91ee3c17ba2a8e42a11007f21be831d564fa)

Author SHA1 Message Date
Tiger Oakes a04b91ee3c
FNX-14513 ⁃ For #12862: Use concept-menu in library (#13332) 2020-08-14 16:44:09 -07:00
Kainalu Hagiwara 6d8cfe1a50 For #13156, #13280 - Use payloads to bind bookmark viewholders.
Change the DiffUtil callback for bookmarks to use the generated equals()
method instead of only checking the title and url fields. This prevents
the BookmarkNode in our state from getting out of sync with the
BookmarkNode the viewholder is bound to.
2020-08-14 13:03:08 -07:00
ankur dd5bb94f8c For #13301, #13038: hide overflow menu for all bookmark items in selected mode 2020-08-06 09:51:56 -07:00
Kainalu Hagiwara cd2532349d For #12551 - Implement swipe to delete for bookmarks. 2020-07-20 14:54:20 -07:00
Mugurell 645674c9bd Closes #4396 - Add a Bookmarks Controller (#4593)
* For #4396 - Rename BookmarkInteractor methods

Following the naming model used in other Interactors this too will use reactive
method names in the form of "on..." instead of the previous imperative model.

Kept the imperative naming model for the methods from `SelectionInteractor` as
they are a new addition and I'm not sure about the future direction.

* For #4396 - Add a BookmarkController

It abstracts the Fragment behavior in a contract through which various
Interactors can inform about the specific View changes and can ask for
modifications in their container Fragment.

This contract and it's implementation - `DefaultBookmarkController` are the
result of extracting the container Fragment's business logic from
`BookmarkFragmentInteractor` in it's own standalone component.

* For #4396 - Refactored Bookmark related tests

Added a new `BookmarkControllerTest` tests class which complements the new
`BookmarkController` to ensure that it properly operates on `BookmarkFragment`

Also refactored the existing `BookmarkFragmentInteractorTest` to accommodate
`BookmarkFragmentInteractor`'s now more specialized behavior.
2019-08-19 08:34:57 -07:00
Tiger Oakes 3c1ce90f6f Fixes #2379 - Generic library selection 2019-08-06 11:10:50 -07:00
Tiger Oakes 6e2ea0750e Issue #2379 - Use LibrarySiteItemView in history 2019-08-02 17:15:41 -07:00