1
0
Fork 0
Commit Graph

10 Commits (6b786ca8dcd07bd31749d7c919d2d90007dab2d3)

Author SHA1 Message Date
Mihai Adrian 6b786ca8dc For #7417 Wait for deletion to finish and loading of new UI (#7572) 2020-01-16 11:03:59 -05:00
Oana Horvath 85dd56e12d
Added multi-selection tests for bookmarks (#6475)
Updated bookmarking method

Fixed flaky tests

Added wait to create bookmark
2019-12-03 12:44:54 +02:00
cesar d955eae4e2 Test for 6731 2019-12-02 16:18:48 +00:00
cesar 808740e4c9 Fixed Typo 2019-11-18 20:07:22 -08:00
cesar d69ead201b Test for 6594 2019-11-18 20:07:22 -08:00
cesar d9ded1f715 Test for 6593 2019-11-18 20:07:22 -08:00
Severin Rudie 6909a76bcb
4281 remove qab (#6310)
* For #4281: small ToolbarMenu refactor

This makes it easier to see how items are ordered in the menuItems list

* For 4281: add QAB buttons to menu

* For 4281: removed menu back button per mocks

I double checked with UX, and we'll be relying on the hardware back button for its functionality

* For 4281: add content descriptions for bookmarking

* For 4281: updated BrowserToolbarController for new functionality

* For 4281: provided simple dependencies to browser controller

More complex changes will be in a following commit, for review readability

* For 4281: move toolbar controller dependencies up to BaseBrowserFragment

The functionality they control is being moved into the toolbar menu, which is shared by both normal tabs and custom ones

* For 4281: removed (now unused) code related to QAB

* For 4281: fix test compilation after QAB removal

Tests still need to be expanded to include added functionality

* For 4281: updated menu to show if url is bookmarked

This sloppy workaround is required because TwoStateButton requires that `isInPrimaryState` be a synchronous call, and checking whether or not the current site is bookmarked is quite slow (10-50 MS, in my tests).  After days of work and many attempted solutions, this was the least abhorrent among them.

https://github.com/mozilla-mobile/android-components/issues/4915 was opened against AC to evaluate potentially supporting async `isInPrimaryState` functions.
https://github.com/mozilla-mobile/fenix/issues/6370 was opened against Fenix to investigate the unexpectedly slow call to `BookmarkStorage`.

* For 4281: update reader mode switch

* For 4281: selectively show/hide menu items

* For 4281: add reader mode appearance

* For 4281: update bookmark button when it is clicked

* For 4281: removed unused QAB code

* For 4281: removed QAB robot, updated UI tests

* For 4281: removed QuickActionSheet metrics

Since this behavior now lives in the toolbar, it is tracked via Event.BrowserMenuItemTapped

* For 4281: fixed lint errors

* For 4281: add new strings for buttons added to menu

This is necessary because the location change (from QAB to toolbar menu) could affect the grammar in some languages

* For 4281: remove outdated TODOs

* For 4281: removed QAB container

* For 4281: removed back button reference from UI test

This button no longer exists

* For 4821: Fixes a visual defect (extra padding on top of toolbar)

* For 4281: update copy on reader mode

* For 4281: fixed review nits
2019-11-11 17:10:14 -08:00
mcarare 675fe6a3a9 For #1487 Add "my library" menu category and items to home 3-dot menu.
Changed UI tests according to new menu items.
2019-10-31 11:29:49 -07:00
sv-ohorvath bb7caa6365 Boomkarks UI tests
Added a comment to the clear all bookmarks method
2019-10-07 10:45:04 -07:00
Aaron Train ae05bf98e2
Closes #4618 - Stub Library UI tests (#4619)
See #4572
2019-08-19 14:05:10 -04:00