1
0
Fork 0
Commit Graph

11 Commits (6ab6f3efe9b47d59c50b10c2a4f03e220e099b60)

Author SHA1 Message Date
Oana Horvath 6ab6f3efe9
Fix UI tests from #12752 #12637 #12764 (#12779)
* For #12752 & #12764: Fixes tabs tray behavior in UI tests

* For #12637: fixes goBackTest
2020-07-21 08:49:24 -04:00
Oana Horvath af3c232615 Replaces verifyPageContent in UI tests 2020-07-16 10:55:58 +03:00
Oana Horvath 268c4f25d8
No issue: re-enables tests ignoring the verifyPageContent step (#11765) 2020-06-19 15:51:50 +03:00
Aaron Train 4270c837be
For #10642: Comment out verifyPageContent calls (#11748)
fix: expectedText not called warning
2020-06-18 15:25:14 -07:00
Oana Horvath ed41c97be0
For #11642 & #10642: Disable intermittent tests (#11724)
* for #11642: disables tests crashing

* for #10642: disables frequently failing  tests
2020-06-18 11:59:36 +03:00
Severin Rudie 6909a76bcb
4281 remove qab (#6310)
* For #4281: small ToolbarMenu refactor

This makes it easier to see how items are ordered in the menuItems list

* For 4281: add QAB buttons to menu

* For 4281: removed menu back button per mocks

I double checked with UX, and we'll be relying on the hardware back button for its functionality

* For 4281: add content descriptions for bookmarking

* For 4281: updated BrowserToolbarController for new functionality

* For 4281: provided simple dependencies to browser controller

More complex changes will be in a following commit, for review readability

* For 4281: move toolbar controller dependencies up to BaseBrowserFragment

The functionality they control is being moved into the toolbar menu, which is shared by both normal tabs and custom ones

* For 4281: removed (now unused) code related to QAB

* For 4281: fix test compilation after QAB removal

Tests still need to be expanded to include added functionality

* For 4281: updated menu to show if url is bookmarked

This sloppy workaround is required because TwoStateButton requires that `isInPrimaryState` be a synchronous call, and checking whether or not the current site is bookmarked is quite slow (10-50 MS, in my tests).  After days of work and many attempted solutions, this was the least abhorrent among them.

https://github.com/mozilla-mobile/android-components/issues/4915 was opened against AC to evaluate potentially supporting async `isInPrimaryState` functions.
https://github.com/mozilla-mobile/fenix/issues/6370 was opened against Fenix to investigate the unexpectedly slow call to `BookmarkStorage`.

* For 4281: update reader mode switch

* For 4281: selectively show/hide menu items

* For 4281: add reader mode appearance

* For 4281: update bookmark button when it is clicked

* For 4281: removed unused QAB code

* For 4281: removed QAB robot, updated UI tests

* For 4281: removed QuickActionSheet metrics

Since this behavior now lives in the toolbar, it is tracked via Event.BrowserMenuItemTapped

* For 4281: fixed lint errors

* For 4281: add new strings for buttons added to menu

This is necessary because the location change (from QAB to toolbar menu) could affect the grammar in some languages

* For 4281: remove outdated TODOs

* For 4281: removed QAB container

* For 4281: removed back button reference from UI test

This button no longer exists

* For 4821: Fixes a visual defect (extra padding on top of toolbar)

* For 4281: update copy on reader mode

* For 4281: fixed review nits
2019-11-11 17:10:14 -08:00
Sawyer Blatz 0e435b8b7b For #5534: Temporarily disables find in page test 2019-10-08 16:17:38 -07:00
ekager 1d66af34b0 No issue: Fixes UI tests by removing TP onboarding closure 2019-09-15 19:47:16 -07:00
Richard Pappalardo 16ec5858ad fix: broken UI tests (#5324) 2019-09-13 17:30:53 -07:00
Aaron Train 5e7672b59e
Closes #5137 - Add Find in Page UI Test (#5138) 2019-09-09 14:16:47 -04:00
Aaron Train 6aa6cf8a99 Closes #3977: Add basic navigational UI tests (#3978)
- Adds UI tests (and assets) for basic navigation

fix: review changes

fix: linter cleanup

fix: detekt cleanup

fix: adjust wait approaches
2019-07-16 13:02:12 -07:00