64072a1256
For #11498/#11499 - added/fixed unit tests
2020-07-31 21:42:57 +03:00
ff50dae8e9
For #11498 - removed SignIn ViewHolder and unified with the Error one
2020-07-31 21:42:57 +03:00
5d1aeb5ea7
For #11499 - replaced string for no tabs available
2020-07-31 21:42:57 +03:00
bfc955cd40
For #11498 - add Sync tabs error view (including sign-in CTA)
2020-07-31 21:42:57 +03:00
78126122ad
For #12769 : Refactored Background Service Test into multiple test cases.
2020-07-31 10:47:11 -07:00
ab2ea8e682
For #13037 - Use email to sign in to fxa if device has no camera
...
App can be installed on devices with no camera modules. Like Android TV boxes.
Will skip presenting the option to sign in by scanning a qr code in this case
and default to login with email and password.
2020-07-31 20:02:23 +03:00
0f0aee5e97
For #6846 - Don't show ToolbarPopupWindow if nothing to show
2020-07-31 12:55:09 -04:00
58e24b81aa
For issue #12400 - Refresh swiped collection tab view
...
Item is now refreshed by calling notifyDataSetChanged on the adapter when the last tab from the collection has been swiped away and the user cancels the deletion by pressing the cancel button from the dialog.
Also added a "wasSwiped" flag to onCollectionRemoveTab in order to check if the tab was deleted from a swipe action and not by pressing the "X" button.
2020-07-31 12:48:32 -04:00
29d07e8153
Import l10n.
2020-07-31 12:37:11 +03:00
5ddf8beea7
Fix suggestions, extract layout for tab history
2020-07-30 17:54:09 -07:00
6152469ffd
Add tests for tab history
2020-07-30 17:54:09 -07:00
4c1e6eeb25
For #12887 : Use ListAdapter to diff history
2020-07-30 17:54:09 -07:00
6cdf304d10
No issue: Adds sameAs function for TopSiteList AdapterItem
2020-07-30 17:46:03 -04:00
3d3153039c
For #11690 - Add contentsSameAs to avoid rebind of items in SessionControlAdapter
2020-07-30 15:18:04 -04:00
d8ff6179fe
For #7992 : Use favicon style from AC ( #12608 )
2020-07-30 11:21:17 -07:00
e265bd7266
Use uplifted addon date code
2020-07-30 10:29:40 -07:00
79c3f3c925
For #11664 — Fixup MissingResourceExceptions being thrown in exotic Locales ( #13124 )
...
Our kotlin code is not catching the `MissingResourceException` in the `LeanplumMetricsService` which results in the app crashing when the locale isn't known by the device.
Catches the exception, and falls back to the ISO 639 language code. This isn't a great solution, because ISO 639 isn't especially stable.
In practice however this is almost certainly never going to be a problem because Leanplum isn't going to be supported in such exotic locales.
In this case, using the ISO 639 language code allows the error message to be more informative.
2020-07-30 18:28:26 +01:00
0356bea50e
For #13117 - Hide save to collection button for private tabs in tab tray
2020-07-30 11:53:29 -04:00
ed8a9bd1a0
For #12565 : Remove activity from DefaultTabTrayController constructor.
2020-07-30 13:33:02 +03:00
ef4e865105
Import l10n.
2020-07-29 21:52:03 -04:00
1a51b7f874
For #13084 - Use runBlockingTest
2020-07-29 21:51:28 -04:00
611adf83e5
remove unused import
2020-07-29 17:47:18 -07:00
151e8595b6
For AC #7673 Move DownloadStatus to DownloadState Fenix Side Changes
2020-07-29 17:47:18 -07:00
0e3acfcd94
Move config to robolectric.properties
2020-07-29 17:46:26 -07:00
a72f9c75f0
For #12570 - Correctly removes search suggestions when search query and url is empty
2020-07-29 16:03:10 -07:00
12b95b4902
For #11579 - Adds telemetry for autoplay settings in Site Permissions
2020-07-29 15:10:25 -07:00
f75be41d3a
Add metric tests
2020-07-29 14:58:48 -07:00
57c7955637
For #12865 , #12990 - Disable swipe to switch tabs gesture when the keyboard is visible.
2020-07-29 14:55:03 -07:00
d5b105097e
Import l10n. ( #13088 )
2020-07-29 13:51:01 -07:00
4b646c03cb
For #9730 : Add Login Dialog Prompt telemetry
2020-07-29 12:59:35 -07:00
1497e4886e
For #13084 - Update SavedLoginsStorageControllerTest
2020-07-29 15:15:18 -04:00
19ffb84cf9
For #11654 - Adds leanplum ETP changed event
2020-07-29 13:35:16 -04:00
bb03049fb5
Add documentation
2020-07-29 13:35:16 -04:00
8bfc493568
For #12103 : Add ChangedDefaultBrowser event for leanplum
2020-07-29 13:35:16 -04:00
2b1122bc77
For #11531 : Add search widget installed leanplum event
2020-07-29 13:35:16 -04:00
6b6e1956ca
For #13071 - Only return to home when session doesn't have parent session to select
2020-07-29 09:50:58 -07:00
579a69b477
Closes #12692 : Remove www. prefix in tab tray urls
...
Use separate imports instead of a wildcard import
Use toShortUrl String extension instead of removing prefix from url host
Add missing import
2020-07-29 12:16:32 -04:00
048f6a49fe
For #12565 : Pass passwordsStorage instead of context in constructor.
2020-07-29 12:15:16 -04:00
87a7b6f9ec
For #12992 - Correctly notifies concat adapters about mode changes
2020-07-29 11:58:04 -04:00
2c0511c92f
Import l10n.
2020-07-29 11:42:30 -04:00
6a27c209b5
For #13042 - Remove bottomSheetCallback in multiselect mode
2020-07-29 11:19:47 -04:00
ac870634ff
For #12533 : Align main settings categories according to specs. ( #12534 )
2020-07-29 10:08:00 -05:00
4b74ff186b
For #12565 : Remove context from DeleteBrowsingDataController constructor
2020-07-29 17:46:43 +03:00
e2e684b4d4
Import l10n. ( #13048 )
2020-07-28 18:37:50 -07:00
537d95c04d
for #11830 created class containing the logic for sending AllStartup telemetry logic
...
lint check
renamed the intentReceived telemetry to appOpenedAllSource
added comments
removed unused code
moved lifecycle process to AppAllSourceStartTelemetry
moved tracking event out of init function
lint fix
moved appAllStartTelemetry to components
added bit more info about the metrics
added the onReceivedIntent metric back
minor fix
change discriptions based on the comments frm MR
wrote test cases for AppAllSourceStartTelemetry.kt
lint fix
test case to mock application going background
post rebase:
post rebase:
fixed nit from comments
fixed nit from comments
fixed nit from comments
lint fix
lint fix
2020-07-28 17:09:42 -07:00
6a618aa318
for #11698 added on demand workmanager initialization ( #12739 )
2020-07-28 16:26:18 -07:00
bef98698cb
For #12904 - Conditionally inflate SwipeGestureLayout in BaseBrowserFragment.
...
Changing the root view of BaseBrowserFragment from a CoordinatorLayout
to a SwipeGestureLayout has caused some regressions, particularly in
snackbar behavior. Lets prevent those regressions from occuring in
builds where the feature flag for gestures is off by only adding the
SwipeGestureLayout when the feature flag is on.
2020-07-28 14:54:18 -07:00
0c8c87e56d
For #12755 - Replace @+id by @id when referencing already declared ids
...
When referencing an Android resource ID, you do not need the
plus-symbol if you declared before.
Caution: make sure that the resource you are referring to
is defined EARLIER and not LATER.
2020-07-28 14:46:09 -07:00
6aa70977e7
For #12861 - Swap order of tabs for tab switching gesture.
2020-07-28 14:37:45 -07:00
af020d0af1
For #12706 - Add vertical scrollbar to bookmarks screen
2020-07-28 16:47:18 -04:00
791eac50f3
For #12704 - Add vertical scrollbar to history screen
2020-07-28 16:47:09 -04:00
210f1ab898
For #12707 - Add vertical scrollbar to search suggestions
2020-07-28 16:46:51 -04:00
8d1bd10e6b
Test paged history provider
2020-07-28 12:35:34 -07:00
239e3de5e9
For #12856 : Add save to collections button to Tabs Tray
...
Using the ConcatAdapter, we're now able to insert multiple data sources
of information into one RecyclerView and preserve layout/scrolling in
addition to adding the 'Save to Collection' button.
2020-07-28 11:14:08 -07:00
33bb86b1aa
For #12992 - Hide tab close button while in multiselect mode
2020-07-28 11:10:45 -07:00
12e68ac18d
For #12622 : Visually indicate different types of suggestions in the search screen
2020-07-28 11:08:35 -07:00
5b997ff1d8
Closes #13021 : Fix verifyAboutFirefoxPreview UI test
2020-07-28 11:02:21 -07:00
272c380755
For #13028 - Add feature flag for tab history.
2020-07-28 11:01:59 -07:00
b7fabdd2f1
Closes #12670 : Add lastUri as a parameter in RequestInterceptor
2020-07-28 13:24:03 -04:00
b0dfdd57dc
For #12968 : Re-enables Search settings tests ( #13020 )
2020-07-28 09:22:46 -04:00
33db252797
Import l10n.
2020-07-27 21:05:00 -04:00
0657bf41d3
For #12991 - Set height to recommended touch target size for collect button
2020-07-27 20:17:48 -04:00
b7325a3833
For #12571 : Rename shortcuts to search engine on search screen ( #12839 )
...
* Rename shortcuts to search engine on search screen
* Remove deprecated pref key
* Re-add deprecated string
2020-07-27 17:19:31 -05:00
5d772337a8
Fix AccountUiView ui failures
2020-07-27 17:40:15 -04:00
52a9acf87d
Enable editing saved logins on all channels ( #12841 )
2020-07-27 15:48:28 -05:00
46f010f247
For #2681 - Adds ability to bypass cache when reloading
2020-07-27 12:11:11 -07:00
57ac6fc36d
Extract navigation subgraphs
2020-07-27 15:04:28 -04:00
61d6b333de
Update LongParameterList baseline
2020-07-27 14:20:34 -04:00
eab9660146
For #1146 : Extract AccountUiView from settings
2020-07-27 21:05:47 +03:00
d640f58316
For #12565 - Clean up controller and add tests
2020-07-27 10:40:09 -07:00
596300591e
For #12772 - Opt-out of scoped storage
...
Targeting Android 10 means we need to support scoped storage or we need to
opt-out of that using requestLegacyExternalStorage="true".
This patch adds the opting-out leaving investigations for what changes we need
for fully supporting scoped storage to be done in issue #12822 .
2020-07-27 10:39:47 -07:00
e5e62fa79a
For #6846 : Added quick actions for nav bar in home
2020-07-27 13:28:28 -04:00
1d604d327c
For #12966 - Fixes session removal show home logic
2020-07-27 10:27:39 -07:00
52de2b8f38
Fix license on remaining files
2020-07-27 13:04:55 -04:00
b1e7e60665
For issue #12181 - Convert String to sentence case
...
Changed the string values capitalization to sentence case.
2020-07-27 12:31:13 -04:00
1353e157cd
Created UI tests for Addon Settings ( #9258 )
2020-07-27 11:00:35 -04:00
9c4fba4565
Closes #12954 - Remove all ConstraintLayout casts in SearchEngineListPreference
2020-07-27 09:49:43 -04:00
808584b75f
For: #12894 , #12899 , #12968 , #11239 , disables failing UI tests
2020-07-27 13:34:56 +03:00
1cbc4eec52
For #7716 - modified xml to let 'Learn more' button have min 48dp for a11y
...
Added a margin top of 20dp as well on the buttons so as not to change UI
2020-07-27 10:16:31 +03:00
6f5faa332d
For #12947 - Adjust tab selected state on bind
2020-07-25 20:07:30 -04:00
058f44e82d
For #12721 - Remove SessionManager usages in TabCounter
2020-07-25 18:37:45 -04:00
3be6393ea5
For #12929 : Change cast to LinearLayout
2020-07-25 10:14:48 -04:00
b3b7566fcf
For #12804 : Set min height for search engine radio button
2020-07-24 22:10:24 -04:00
46511d6f8e
For #10163 - Adds tab multiselect mode
2020-07-24 18:18:26 -04:00
d15b8381a6
For #10925 : Fix breaking APIs in tabs tray
2020-07-24 16:52:06 -04:00
8c1d3dc827
For #12871 - Use local TWA DAL API ( #12872 )
2020-07-24 13:08:24 -07:00
cac0be43e6
For #12880 - Pass a CoordinatorLayout to Snackbars created by the context menu.
2020-07-24 12:30:46 -07:00
95d786a79f
No issue: fix master
2020-07-24 15:06:38 -04:00
6edbb82591
For #12364 - Improve PWA onboarding timing logic
2020-07-24 14:43:28 -04:00
9c56e1905b
For #12793 : Improve snackbars for tabs tray
2020-07-24 10:56:54 -07:00
6c58098fef
For #12791 : Fix issue with undo snackbar last tab
2020-07-24 10:56:54 -07:00
c48159d76f
For #10997 : Remove scrolling from home ( #12866 )
2020-07-24 10:43:53 -07:00
923d841403
For #12345 : replace Activity.reportFullyDrawnSafe with a-c impl.
2020-07-24 10:30:03 -07:00
a07f8a5041
For #12893 : Disables failing deleteAllHistoryTest ( #12902 )
2020-07-24 11:47:59 -04:00
a116950fc8
For #12473 : Disable failing verifyContextCopyLink ( #12891 )
2020-07-24 10:29:22 -04:00
3883703ed5
For #10026 : Update scroll flags on a11y state change.
2020-07-24 10:35:33 +03:00
e7a5613afb
For #10026 : Add a11y state listener to BaseBrowserFragment.
2020-07-24 10:35:33 +03:00
cf0126e079
For #10026 : Add Context extension to get AccessibilityManager.
2020-07-24 10:35:33 +03:00
8f32b18dfa
For #12868 - Fix tab counter menu snackbar position.
2020-07-23 18:30:04 -07:00
0e438ef9a7
For #12430 : Hide the mic when not using Google
2020-07-23 19:29:26 -04:00
d3a07e95c9
For #12565 : Don't pass contest to SortingStrategy
2020-07-23 19:05:11 -04:00
aa495b4526
No issue: Fix recent UI test breakage ( #12869 )
2020-07-23 14:17:54 -07:00
652af79e95
Migrate from Session.toTab to BrowserStore ( #12221 )
2020-07-23 12:27:39 -07:00
9af167ba0a
Add tests for some classes in home/browser ( #12837 )
2020-07-23 11:17:52 -07:00
0d77f761e9
Test sync adapter ( #12810 )
2020-07-23 11:16:11 -07:00
6530a45eb9
For issue #11676 : Features phone that doesn't a site permission exception shouldn't be shown ( #12855 )
...
exception shouldn't be shown
2020-07-23 09:12:22 -07:00
7f829e1752
Import l10n.
2020-07-23 10:40:10 +03:00
8f5a37733d
Create ToolbarPosition enum ( #12747 )
2020-07-22 19:23:38 -07:00
c143f95819
Issue #11333 : Set ContentBlocking settings directly on GeckoRuntime
...
We set the ContentBlockingSettings directly on the GeckoRuntime now to
improve the startup of the engine.
This change has requirements from Android Components and GeckoView, so
we would only see the full perf benefits in Nightly as the changes ride
the train, although we might start to see some of them as we're updating
the GeckoProvider for the `geckoBeta` variant as well.
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
2020-07-22 16:28:18 -04:00
b26e39906d
No issue - Fix compilation error caused by removed extension function.
2020-07-22 13:00:07 -07:00
58ccc64386
Fix UI tests.
...
We need to pass a CoordinatorLayout instead of a SwipeGestureLayout to
FenixSnackbar.make() in BaseBrowserFragment to prevent UI tests from
breaking. We also need to remove a few view IDs from the tab preview.
2020-07-22 11:26:15 -07:00
e7dc5580b2
For #3481 - Implement swipe on toolbar to switch tabs.
2020-07-22 11:26:15 -07:00
9a2da5bb0f
Import l10n.
2020-07-22 11:25:16 -07:00
921b16233b
For #1048 - Add ability to view tab history by long-pressing the back or forward button.
2020-07-22 11:20:47 -07:00
2a0a11f740
For #12571 : Rename 'Shortcuts' to 'Search engines'
...
Co-Authored-By: Khushraj Rathod <khushrajrathod@gmail.com>
2020-07-22 11:05:04 -07:00
c2d940cf06
Use AC RunWhenReadyQueue ( #12800 )
2020-07-22 09:48:36 -07:00
d9357f1e32
For #12801 - Extra debug menu trigger, disable if already triggered
2020-07-22 19:28:48 +03:00
d5fbc17ccf
Update to Android Components 52.0.20200722023149
...
Fixes breaking APIs in SyncedTabsFeature and
BookmarksStorageSuggestionProvider
2020-07-22 10:52:14 -04:00
2ae88aec81
No issue: add missing newline.
2020-07-21 15:52:34 -07:00
6e06c7fda1
No issue: clean up initVisualCompletenessQueue... method.
...
A no-op clean up.
2020-07-21 15:52:34 -07:00
633bc4f2f2
No issue: extract initVisualCompletenessQueueAndQueueTasks.
...
This refactor, done entirely by IDE, is a no-op cleanup.
2020-07-21 15:52:34 -07:00
169071ac61
No issue: extract startMetricsIfEnabled function.
...
This refactor, done entirely by IDE, is a no-op clean-up of this file.
2020-07-21 15:52:34 -07:00
11e2137fab
For #12806 - Adds unit tests to cover `ToolbarView.update()` ( #12807 )
2020-07-21 14:34:07 -07:00
99354174a9
For #12797 : Use measured height/width for loading a thumbnail
...
Using `onNextLayout` has the side-effect of showing the thumbnail with
the tab.id from a recycled view.
The root cause of needing that call is to retrieve the measured
height/width from the view first before requesting. A simpler solution
to avoid the complexity is to retrieve these values from the dimen
resources.
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
2020-07-21 16:38:49 -04:00
b483067bd9
For #12461 : Update content description for tabs tray open tab count
2020-07-21 15:48:38 -04:00
96121a79fa
Issue #7877 : Add SearchActionProvider for faster responses that mirror entered text.
2020-07-21 14:41:00 -04:00
c08d375c18
Move settings in components ( #12675 )
2020-07-21 10:47:10 -07:00
c3041bcb64
For issue #12387 - Display tab tray using .show
...
Replaced the global navigation action used for displaying the tab tray with the .show() function.
2020-07-21 10:31:24 -07:00
8826f99ef7
For #9722 : Refactor onboarding buttons with text.
...
Add title and description to button text, remove extra Textviews.
2020-07-21 10:28:45 -07:00
0abb2c4f8b
Add tests for web push integration
2020-07-21 10:12:06 -07:00
9a7154e95e
For android-l10n #241 : Mark a11y link type as not translatable.
2020-07-21 17:59:17 +03:00
7e7d69cb8e
Bug 1652979 - Stop producing fennecNightly, fenixNightly and fenixBeta ( #12225 )
2020-07-21 16:42:08 +02:00
899f6e63ad
No issue: verify ETP toolbar shield icon is not displayed if ETP is OFF globally in ETP UI tests ( #12623 )
2020-07-21 09:33:06 -04:00
6ab6f3efe9
Fix UI tests from #12752 #12637 #12764 ( #12779 )
...
* For #12752 & #12764 : Fixes tabs tray behavior in UI tests
* For #12637 : fixes goBackTest
2020-07-21 08:49:24 -04:00
e809df0858
Pass settings and metrics to CFR
2020-07-21 09:01:09 +03:00
80b3b2dd82
Import l10n. ( #12766 )
2020-07-20 18:26:00 -07:00
41c256e474
Fixes #12752 , #12764 - Temp disable openHistoryInNewTabTest intermittent UI test failures ( #12754 )
...
* Fixes #12752 - Temp disable intermittent failing test
2020-07-20 18:09:01 -07:00
02a929a926
No issue - Suppress new warnings from detekt update
2020-07-20 17:01:50 -07:00
284ec7b58f
For #12461 : Add tab count to tab tray
2020-07-20 19:16:47 -04:00
f73411b924
For #5499 - Unify CFR drawables and dimens ( #12749 )
2020-07-20 16:00:57 -07:00
aeabd3e91b
For #12532 : Quick fix for radio button alignment ( #12691 )
2020-07-20 15:33:32 -07:00
cd2532349d
For #12551 - Implement swipe to delete for bookmarks.
2020-07-20 14:54:20 -07:00
313e5abf6a
Rename tab_tray_background.xml
2020-07-20 14:54:20 -07:00
fcb84d940a
No issue: correct position of StartupTimeline; add warning.
2020-07-20 14:27:41 -07:00
445593b719
For #10466 : Add search privately to top of list ( #12744 )
2020-07-20 13:25:36 -07:00
51937e73fc
Closes #10924 - Cleanup SavedLoginsAuthFragment ( #10930 )
2020-07-20 13:25:24 -07:00
1121d844e6
For #12730 - Fix ripple for font size setting.
2020-07-20 13:00:59 -07:00
afbb039a08
For #11851 : Close tab tray when last tab closed ( #12615 )
2020-07-20 11:05:32 -07:00
1dc0ad39f4
For #10784 - Fixes memory leak in BrowserAnimator
2020-07-20 13:50:18 -04:00
f0c6bc0226
For #12735 : Fixes issue with tab deletion undo ( #12737 )
2020-07-20 10:48:16 -07:00
3f25a28cf7
For #12554 : Helper class for password reveal on logins
2020-07-20 13:45:46 -04:00
c66480d6dd
Import l10n. ( #12687 )
2020-07-19 21:30:11 -07:00
16b6776938
Update Android Components to 51.0.20200717190031
2020-07-17 19:32:02 -04:00
499f185fc0
Fix lint issues ( #12683 )
2020-07-17 16:20:08 -07:00
13949d6968
Test migration classes ( #12677 )
2020-07-17 14:35:13 -07:00
67fda80453
Add tests for login exceptions ( #12681 )
2020-07-17 14:25:45 -07:00
aa31eb0fa5
Fix failure in handleWhatsNewGetAnswersClicked ( #12682 )
2020-07-17 14:25:35 -07:00
9c1b586e45
For #7966 : Update toolbar content description. ( #12667 )
2020-07-17 16:22:13 -05:00
37af9df3ad
For #12532 : Align Settings -> Site permissions -> Sub-pages to 72dp keyline ( #12680 )
...
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
2020-07-17 15:54:57 -05:00
1823fdb66d
For issue #9949 - Bookmarks/History deletion inconsistencies ( #12630 )
...
- Added the undo action for deleting individual history items by creating a new field to the history state containing the id's of the history items that are pending for deletion; This field is used inside the update function from the view to show/hide the items.
- Added a new check inside the "deleteMulti" method from BookmarkFragment that calls the showRemoveFoldersDialog to prevent the user from being able to delete one or more bookmark folders without being asked for confirmation, as in #8648 .
Co-authored-by: Mihai Eduard Badea <mihai.badea@softvision.ro>
2020-07-17 15:13:18 -05:00
eed20b43b9
Test session control controller ( #12652 )
2020-07-17 13:07:01 -07:00
aa7655f4d6
For #12509 : Set height of remove add on button to 36dp
2020-07-17 12:55:36 -07:00
455e7b8f99
Update ContextMenuUseCases to just take a store
2020-07-17 14:49:10 -04:00
e1ef5f55ec
For #12453 - Sets secure flags on private tab of tabs tray
2020-07-17 13:24:25 -04:00
e358f95eed
For #12364 - Only show PWA prompt the third time a user visits installable site
2020-07-17 12:37:03 -04:00
ac3df6bc5e
Add tests for adapters in collections ( #12649 )
2020-07-17 09:04:16 -07:00
2fe17a6220
For #12531 : Align Settings -> Private browsing to 72dp keyline ( #12654 )
...
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
2020-07-16 22:26:49 -07:00
023a4983fa
For #10173 : login duplicates and save ( #11208 )
...
* Extract controller into it's own class. Implement find dupes and filter based on username.
Create edit login controller. Add text watchers and check for duplicates.
Edit controller test
* Find duplicates and save to store
* Retrieve duplicates from AC and check list on username text changed
Move duplicates logic into the controller
* Add glean pings for delete and edit. Move logic for login manipulation into the datastore.
* Use correct threads in controller. Enable save button when applicable.
Save enabled in datastore.
Move login data to datastore
Rebase with password error states
Update metrics to be more specific for edit
* Create logins controller for AC calls
* Interactor and controller methods for edit login. Add edit view to separate out some layout manipulation.
Inflate view in edit fragment. Double layout showing up.
Edit view
Controller tests
Controller tests passing
Interactor tests
Lint and detekt cleanup
* Remove datastore and use storage controller for all logins calls to password storage.
Addressed comments
Lint
:
Rebase - 1
2020-07-16 17:08:04 -05:00
4dd0c0f224
For #12457 : Add MockK matcher for intents ( #12612 )
2020-07-16 15:05:01 -07:00
e1fc0cc038
Ensure logins deletion ( #12507 )
...
* For #11227 - Cleanup saved logins list when one is selected
Selecting a saved login will open a detail screen for it from where users can
change details or even delete that particular login.
After the change is made the user is brought back to the list of saved logins
where for a brief moment (< 1s) until we get a new response from
passwordsStorage.list() the user can see and even interact with the old list
of items, which may still contain the just deleted one.
To avoid users seeing obsolete logins or even interacting with them (selecting
a previosuly deleted item will result in a crash) we will clean the list of
logins just before the selected login is opened in the detailed view.
When returning for a brief moment the users may see the "loading" UX until
passwordsStorage.list() returns the up-to-date list of logins to display.
* For #11227 - Refactor SavedLoginsView to be closer to MVI
- Interactors should only get passed other Interactors or Controllers as
dependencies to which they should delegate user actions.
- Controllers should hold most of the business logic and get passed all final
dependencies they need to do their job.
2020-07-16 14:40:08 -05:00
2d066d77ad
Add tests for sync, wifi, and push ( #12581 )
2020-07-16 12:25:38 -07:00
2291fb07aa
For #12565 : Add Locale settings tests & use activity ( #12579 )
2020-07-16 11:43:27 -07:00
3373f8b987
For #12600 - remove AddonInstalled event when the permission dialog is shown ( #12601 ) r=csadilek,sblatz
2020-07-16 19:40:39 +01:00
9373e7fcf4
For #12201 - forced callbacks to be on the main thread ( #12543 )
2020-07-16 13:39:31 -05:00
4fe1fb8f4a
No issue: Delete unnecessary to-dos ( #12603 )
...
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
2020-07-16 13:38:07 -05:00
b997fba953
No issue: Move dp's to dimens.xml
2020-07-16 13:08:55 -04:00
b867e0de45
Update TabTrayViewHolder with A-C thumbnail changes.
2020-07-16 12:50:33 -04:00
7923255fda
For #12118 : Add isSubframeRequest parameter for app links
2020-07-16 12:50:33 -04:00
a0d9cdc450
For #12248 : Webcompat reporter not active in Nightly
2020-07-16 12:24:21 -04:00
fb1d7e12e6
For #11704 Add leanplum attributes for tracking protection ( #11965 ) r=sblatz
...
* For 11657: add LP attribute for tracking protection
* For #11704 : added tracking_protection_enabled attribute
* Added docs for the new attributes, linking to data-review to the mma.md
* Rename null to none when no ETP is enabled
2020-07-16 17:09:32 +01:00
057711e6fb
No issue: Uncomment forgotten assert
2020-07-16 11:45:53 -04:00
cdd5d206fd
For #12105 : Follow ux mock on Settings --> Accessibility screen
2020-07-16 10:37:20 -04:00
798c1bf743
Address review comments
2020-07-16 10:37:03 -04:00
22689a9ff5
Remove need to specify component names for new intents
2020-07-16 10:37:03 -04:00
98a33ea82b
Changed home_* style links to urls_* to reflect that the destination is a set of links, rather than where the screen is
2020-07-16 10:37:03 -04:00
1629878a66
Add install_search_widget
2020-07-16 10:37:03 -04:00
4573d09fd8
Add UI tests for deep links
2020-07-16 10:37:03 -04:00
709fedd4d7
Add unit tests for deep links
2020-07-16 10:37:03 -04:00
8130aaa2cc
Add deep links for settings and home screens
2020-07-16 10:37:03 -04:00
5b61b44f1a
cron-job-ui-screenshots ( #12423 )
...
Co-authored-by: isabel rios <isabelrios@MacBook-Pro-de-isabel-2.local>
2020-07-16 16:08:00 +02:00
d449184faa
For #12544 - Prevent search engines mixup
...
Stricter synchronization by always using the same "loadedSearchEngines"
variable.
With "loadedSearchEngines" calling "refreshAsync()" we also get the fallback
engines to contain reddit and youtube (which are programatically added) and
also now we properly remember and display the engines added by user.
2020-07-16 16:49:54 +03:00
af3c232615
Replaces verifyPageContent in UI tests
2020-07-16 10:55:58 +03:00
6be39aebde
Add tests for StartupReportFullyDrawn ( #12560 )
2020-07-15 23:31:59 -07:00
d4bb432e24
Add helper for underlining text ( #12520 )
2020-07-15 22:38:46 -07:00
a0491b702e
Fix nav graph and theme tests ( #12567 )
2020-07-15 18:04:36 -07:00
d0e9f1f165
Update Kotlin dependency ( #10806 )
2020-07-15 18:02:58 -07:00
4153c11ea8
For #12503 : Add unit tests for permissions details view.
2020-07-15 10:04:40 -04:00
800702149b
For #12503 : Open addon permissions link in app.
2020-07-15 10:04:40 -04:00
661835a35c
No issue: Add a couple Tabs Tray UI tests
2020-07-15 10:49:34 +03:00
9ed85510ae
For #7094 - Adds save login exceptions
2020-07-14 14:47:37 -04:00
Mihai Branescu