37af9df3ad
For #12532 : Align Settings -> Site permissions -> Sub-pages to 72dp keyline ( #12680 )
...
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
2020-07-17 15:54:57 -05:00
aa7655f4d6
For #12509 : Set height of remove add on button to 36dp
2020-07-17 12:55:36 -07:00
e358f95eed
For #12364 - Only show PWA prompt the third time a user visits installable site
2020-07-17 12:37:03 -04:00
023a4983fa
For #10173 : login duplicates and save ( #11208 )
...
* Extract controller into it's own class. Implement find dupes and filter based on username.
Create edit login controller. Add text watchers and check for duplicates.
Edit controller test
* Find duplicates and save to store
* Retrieve duplicates from AC and check list on username text changed
Move duplicates logic into the controller
* Add glean pings for delete and edit. Move logic for login manipulation into the datastore.
* Use correct threads in controller. Enable save button when applicable.
Save enabled in datastore.
Move login data to datastore
Rebase with password error states
Update metrics to be more specific for edit
* Create logins controller for AC calls
* Interactor and controller methods for edit login. Add edit view to separate out some layout manipulation.
Inflate view in edit fragment. Double layout showing up.
Edit view
Controller tests
Controller tests passing
Interactor tests
Lint and detekt cleanup
* Remove datastore and use storage controller for all logins calls to password storage.
Addressed comments
Lint
:
Rebase - 1
2020-07-16 17:08:04 -05:00
b997fba953
No issue: Move dp's to dimens.xml
2020-07-16 13:08:55 -04:00
cdd5d206fd
For #12105 : Follow ux mock on Settings --> Accessibility screen
2020-07-16 10:37:20 -04:00
9ed85510ae
For #7094 - Adds save login exceptions
2020-07-14 14:47:37 -04:00
f424656575
For #12107 : Follow ux mock on Settings --> Account screen
2020-07-14 12:25:21 +03:00
ca30fef579
For #12106 : Follow ux mock on Settings --> Logins screen
2020-07-13 11:14:32 -04:00
ad265be672
For #11303 - Change copy login origin to open in browser
2020-07-09 18:09:41 -04:00
63eb7b3e4e
For #12010 : Follow ux mock on Settings --> ETP --> Info screen ( #12429 )
...
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
2020-07-09 09:47:09 -07:00
fab64229a5
Closes #11873 - Add scrollbar in tabs tray
2020-07-07 17:50:56 -04:00
426a1ba57d
For #12078 : Follow ux mock on Settings --> Language screen
2020-07-06 15:47:42 -04:00
9bc4f443f5
For #9775 : Increase touch target of elements in add search engine screen
2020-07-06 15:47:25 -04:00
170ae1aa33
For #12263 - Adds end margin to synced tabs header
2020-07-06 15:37:53 -04:00
331090d1e6
For #12007 : Fix add search engine items using wrap content for height
2020-07-06 15:37:28 -04:00
90f43bf350
For #12086 : Follow ux mock on Settings --> Customize screen ( #12324 )
...
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
2020-07-06 12:25:54 -07:00
ad8e28ae02
For #12007 : Follow ux mock on Settings --> Search screen ( #12177 )
...
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
2020-07-02 00:48:31 -07:00
50c3c9a9dd
Fix ignored XML lint issues ( #12094 )
2020-06-29 16:36:52 -07:00
e0fa1c0db4
For issue #11835 - Update text fonts
...
Updated the fonts and colors for several texts throughout the application.
2020-06-26 23:18:52 -04:00
5ef6b49aa1
For #8795 : remove redundant ConstraintLayout around BrowserToolbar. ( #12014 )
...
This is functionally equivalent to the code before this patch but should
be slightly more performant in theory because ConstraintLayout is
expensive to inflate.
The elevation and layoutParams set dynamically appeared to have no effect
with the wrapping view but broke the view when used by itself so I had
to remove them. I also updated a few other unnecessary params.
Theoretically this may have some perf benefits but I didn't see anything
outside noise levels after I took the numbers (but I didn't try very
hard).
2020-06-26 21:31:02 -04:00
f89b157c23
For #12002 : Show default tab background when thumbnail not available ( #12041 )
2020-06-26 20:46:23 -04:00
2cbd969e34
For #11641 : Update synced tabs view
2020-06-26 18:11:13 -04:00
64947a8686
For #10285 : Swap TextView for a LinkTextView to improve links a11y
2020-06-26 18:11:11 +03:00
0626384baf
For #10285 : Swap TextView for a LinkTextView to improve a11y.
2020-06-26 09:15:44 +03:00
ad90625b48
For #2165 - Add swipe to refresh gesture to bookmarks view.
2020-06-25 14:50:24 -07:00
77ed670558
For #11860 - Conditionally show add to collection button on Home screen
2020-06-24 21:41:19 -04:00
7b20bb9976
For #11562 : Align overflow menu button with close buttons.
2020-06-24 21:40:57 -04:00
2c39d3ebca
For #11430 - Gives enough padding to the tab tray give adequate space for the fab
2020-06-24 21:16:24 -04:00
ce31a620d5
Minify XML path
2020-06-24 14:05:44 -04:00
2861421312
For #11112 - Adds save tabs to collection button to the no collections message
2020-06-23 08:17:55 -07:00
761d253f59
For #8649 - Fixes overlapping bookmark sign in button
2020-06-22 18:19:47 -04:00
c8d36ddc36
For #8649 : No bookmarks here strings are close to the top
2020-06-22 16:04:20 -04:00
00862708ae
For #10551 : Increase touch target for link.
2020-06-22 13:58:02 -04:00
0b57f5e71b
Fixes #10551 : Removes the increased touch target for learn more link
2020-06-22 16:40:15 +03:00
988513aa89
for #10568 moved awesomebar and toolbar into fragment_search ( #11744 )
2020-06-21 14:56:49 -07:00
3ad7795a2d
Fixes #11134 : Removes margin to allow collection title to expand
2020-06-19 17:27:57 +03:00
e7bc266578
For #11665 : Adjust visual design for delete browsing data screens.
2020-06-19 09:32:37 +03:00
0ce4aa1e60
For issue #10764 - Onboarding toggle color
...
- Removed the theme from the toggle so that the default colors from the themes are used instead
2020-06-18 10:16:36 +03:00
5f7bb68a51
For #11666 : TopSites layout from Constraint to Linear ( #11669 )
2020-06-17 19:18:14 -04:00
56b00d0625
For #11456 : AddonDetailsFragment should use ConstraintLayout, not RelativeLayout
2020-06-17 15:51:29 -04:00
291a29b334
For #11651 - Fix top site favicon size and dark theme border color. ( #11652 )
2020-06-16 14:10:15 -07:00
37ccc52d35
For #11558 - Fix double click required for tabs tray
2020-06-16 15:59:38 -04:00
396cd61efa
For #9712 - show "AC: " before AC version on "About" screen
2020-06-16 15:29:00 -04:00
e6da2bd910
Fix breaking APIs in TabsAdapter and ViewHolder
2020-06-13 16:02:31 -04:00
149efc1683
For 9640 - Focus on last selected tab in tab tray with a11y turned on ( #11487 )
2020-06-12 18:15:13 -05:00
063cf457ba
For #11291 - Provide New Tab button when accessibility enabled ( #11441 )
2020-06-12 17:52:06 -05:00
724ca2fca9
For #10281 : Reduce logo margin to compensate top site padding increase.
2020-06-12 09:31:23 -04:00
852720f8c6
For #10281 : Change margin with padding to allow flexbox to stretch.
2020-06-12 09:31:23 -04:00
1639b1d3a1
For #11342 - Fixes missing space for the FAB
2020-06-11 18:25:57 -04:00
d14b39a56e
For #2165 - Implement pull-to-refresh gesture to sync history.
2020-06-11 10:23:27 -07:00
f163861b47
For #11177 - Load all share targets in the horizontal share menu
...
This was previously regressed by having the RecyclerViews for "recent" and
"all" items put inside a HorizontalScrollView which would then prevent the
RecyclerViews from actually scrolling, recycling, showing new items.
As a quick solution that would keep the desired behavior the "all" items list
is now a child of a RelativeLayout which will allow it to load all items at
once and so all the share targets will be available to the user but which also
means no recycling.
The RecyclerView for the "recent" items uses a `RECENT_APPS_LIMIT = 6` so this
does not need the same "fix" as all the items would fit the screen without
any issue.
2020-06-11 15:08:36 +03:00
3ff20c0b25
For #11081 - Add dark theme colors for top sites.
2020-06-10 19:42:34 -07:00
137d66a511
For 10172: Set edit text listeners ( #11196 )
...
* Set edit text listeners
* Set clearable icons and change with error states
* Clear text buttons show and hide
* Move error checks to afterTextChanged. Refactor. Remove unused color.
2020-06-10 16:52:47 -05:00
d16c70d8be
Wire up UI to make add-on installation cancelable
2020-06-10 18:52:06 +03:00
d33080571b
For #11267 - Announce "Your open tabs will be shown here ( #11272 )
2020-06-05 17:27:45 -05:00
c8b40fa617
For #11246 : Align text to viewStart to support RTL layouts.
2020-06-05 14:29:00 -04:00
d66ccb8631
For #11277 - Set textAlignment to viewStart to fix RTL layout in empty ETP exceptions screen.
2020-06-05 14:27:54 -04:00
a57d76eb4f
For #6180 - Set textAlignment to viewStart to fix RTL layouts.
2020-06-05 14:27:26 -04:00
512aa46224
For #11229 : Update ETP cfr string and behaviour.
2020-06-05 14:18:25 -04:00
a0d9189321
For #11229 : Update onboarding ETP copy.
2020-06-05 14:18:25 -04:00
52c2fdb310
Remove tab tray feature flag ( #11176 )
...
* For #11171 - Removes feature flag for the new tab tray
* For #11171 - Removes all tab references from homeFragment
* For #11171 - Fixes unit tests
* For #11171 - Gets UI tests to compile and HomeScreenTest to pass
* For #11171 - Fixes `deleteMultipleSelectionTest`
* For #11171 - Fixes `openHistoryItemInNewPrivateTabTest`
* For #11171 - Fixes `openHistoryInPrivateTabTest`
* For #11171 - Fixes `openHistoryInNewTabTest`
* For #11171 - Fixes `openNewPrivateTabTest`
* For #11171 - Fixes tabbedBrowsingTests
* For #11171 - Fixes SettingsPrivacyTest
* For #11171 - Fixes TopSitesTest
* For #11171 - Fixes lint errors
* Ignore
2020-06-05 12:59:08 -05:00
741fa799ad
For #7752 , #7753 : Adjust touch targets for elements in crash reporter.
2020-06-05 12:04:58 +03:00
f47c80d10b
No issue: Fix xml indentations.
2020-06-05 12:04:58 +03:00
2d24369362
For #7725 : Increase info button touch target while keeping size.
...
Also removed unnecessary touch delegate.
2020-06-05 11:57:17 +03:00
8f3274eba9
For #9590 : Increase widget elements touch target while keeping size.
2020-06-05 11:49:35 +03:00
d046d908fc
Bug 1643132 - Remove native "Report site issue" functionality.
...
This will be replaced by the WebCompat team's system extension that ships as an android-component.
2020-06-04 18:23:11 -04:00
7013e8198b
For 11114 - Correct landscape tab tray buttons
2020-06-02 23:09:05 -07:00
803ed6cde3
For #11154 : Fix button color on migration UI
2020-06-02 18:08:45 -07:00
ead3194d86
For #8759 - Allow recently used in share fragment to scroll
2020-06-02 16:46:08 -04:00
2dd0a3cb9e
Implement tab tray design improvements and fix close functionality.
2020-06-02 15:03:58 -05:00
7d50834a90
For #11139:Constrain title to start of checkbox and ellipsize.
2020-06-02 12:08:05 -04:00
ad829115ef
For #9545 : Split button to allow distinct focus for a11y services.
2020-06-02 09:33:32 -04:00
c4f7a32eae
For #9583 : Increase touch targets for onboarding elements.
2020-06-02 09:26:38 -04:00
713b004488
For #9805 : Increase touch target for build date.
2020-06-02 09:26:07 -04:00
0aeb89400b
For #9805 : Increase touch target for etp panel switch.
2020-06-02 09:25:51 -04:00
5fe007b723
For #10577 - Adds elevation for the browser toolbar popup
2020-06-02 11:26:46 +03:00
50441e28f1
Tests and cleanup for tracking protection
2020-06-01 22:08:52 -04:00
4da22c605a
For #10834 - Adding Sync Tabs Feature in Fenix
2020-06-01 16:52:40 -04:00
60b68a265a
For #10921 - Integrate BrowserThumbnails feature into the tabs tray ( #11093 )
2020-06-01 14:36:44 -04:00
f05890efec
For #10848 - Fixes bug where selected index wouldnt be properly calculated in private mode
2020-05-30 10:38:48 -07:00
917609aa36
For #10848 - Fixes FAB color when in private mode
2020-05-30 10:38:48 -07:00
91402f9b38
For #10848 - Fixes icon colors and missing divider
2020-05-30 10:38:48 -07:00
b9370640a2
Update multi-task, private, 3-dot icon and hairline in light mode to ink_20 (#312A65) and in dark mode to violet_50 (#9059FF)
2020-05-30 10:38:48 -07:00
51ea68f4bd
For 10848 - Add divider under tab headings
2020-05-30 10:38:48 -07:00
3946ec11de
Polish homescreen ( #11065 )
...
* For #10505 - Adjusts wordmark margins
* For #10505 - Removes topsite header, fixes collections header size and removes divider
* For #10505 - Restyle the top site items on the homescreen
2020-05-29 17:09:12 -05:00
20e358228e
For #11015 - Switch Default ETP Setting to Standard
2020-05-29 16:39:47 -04:00
906d72c894
For #9594 : Increase touch target for snackbar action button button.
2020-05-28 19:41:28 -07:00
97704bfdbd
Closes #9529 : changed styling for permissions dialog to set proper padding
...
- Changed the visibility check to check just for the permissions shown instead of all the permissions in WebsitePermissionsState
- Added bottom padding to the permissions root view so there is balanced padding on top and bottom
2020-05-28 16:08:07 -07:00
94d741864e
For #9488 : Add search widget CFR
2020-05-28 15:15:25 -07:00
63b4fcd4c4
For #11004 : Fix invisible text on migration UI
...
For some text and colors, we were using the default styling where
possible. These styles contain references that react to theme changes
like dark mode. Since the migration UI does not respect these changes,
we should not use them.
2020-05-28 15:48:42 -04:00
ea4c342797
For #10877 - Show 'no tabs' message when no tabs are open ( #10960 )
2020-05-28 10:17:55 -05:00
610409862b
For issue #10725 - Truncated account details
...
- Set the textview's height to "wrap_content" and added top/bottom padding to account for the size difference and maintain the original height
2020-05-28 13:41:29 +03:00
424598946a
For #10962 - Remove tab tray tab text labels
2020-05-27 16:40:49 -07:00
58a7e63105
For 10965 - Implement content description and fix border for add button
2020-05-27 16:40:26 -07:00
248237290e
For #10865 - Implement 3 dot menu for tab tray ( #10869 )
2020-05-27 13:07:03 -05:00
a59917cdc0
For #9626 : Swap margin for padding and remove use of touch delegate.
...
Also remove text margin to maintain visual appearance.
2020-05-27 08:43:43 -07:00
6e325d6242
For #6198 : Update copy and position of pair QR code scan message.
2020-05-25 17:53:20 -04:00
a62f4b2caa
For #10851 : Add end constraint for text view.
2020-05-25 17:49:39 -04:00
ce46a96742
For #10706 : Update copy of deleting open tabs preference.
2020-05-25 17:37:29 -04:00
Elise Richards