1
0
Fork 0
Commit Graph

69 Commits (69a9aeebae193107ba122bf60e5b60386666d85b)

Author SHA1 Message Date
Elise Richards feae7fff2f
FNX-14498 ⁃ For #9487: improve fxa onboarding manual sign in card (#13317)
* Replace strings, add learn more, hook up button

* Constrain learn more and icon to the text

* View holder tests

* Lint

* Update homescreen ui test
2020-08-20 11:05:11 -05:00
ekager a1a839f237 For #13221 - Update global ETP to include PBM 2020-08-04 14:34:24 -04:00
Tiger Oakes 8f5a37733d
Create ToolbarPosition enum (#12747) 2020-07-22 19:23:38 -07:00
Tiger Oakes c08d375c18
Move settings in components (#12675) 2020-07-21 10:47:10 -07:00
mcarare 8826f99ef7 For #9722: Refactor onboarding buttons with text.
Add title and description to button text, remove extra Textviews.
2020-07-21 10:28:45 -07:00
Tiger Oakes d4bb432e24
Add helper for underlining text (#12520) 2020-07-15 22:38:46 -07:00
Tiger Oakes 67ce5ad5d9
Add tests for onboarding viewholders (#11522) 2020-07-08 07:53:22 -07:00
Tiger Oakes 8e8e5aea36
Extract radio group logic into helper (#11493) 2020-07-06 17:09:42 -07:00
Elise Richards 665fb8d60c
#10824: Onboarding telemetry (#11867)
* Onboarding events and tracking

* Rename metrics for consistency

* Add reference to PR for the data review

* Add default values to onboarding events
2020-06-25 13:21:31 -05:00
mcarare 4b04a140fc For #11229: Update etp strict option title content description. 2020-06-11 10:20:01 +03:00
mcarare a0d9189321 For #11229: Update onboarding ETP copy. 2020-06-05 14:18:25 -04:00
mcarare c4f7a32eae For #9583: Increase touch targets for onboarding elements. 2020-06-02 09:26:38 -04:00
Tiger Oakes f7b4f1c959
Cache findViewById calls in session control (#10575) 2020-05-12 14:05:08 -07:00
Mihai Branescu 6f97e75579 For #8643 and #7606 - illustrations are now connected to their radio buttons 2020-05-06 09:18:27 +03:00
Mihai Branescu cde31cf785 For #8643 and #7606 - Changed toolbar picker illustrations according to theme 2020-05-06 09:18:27 +03:00
Mihai Branescu 16b7a9399b For #8643 and #7606 - Changed theme picker illustrations according to theme 2020-05-06 09:18:27 +03:00
Mihai Branescu 4c0af91b7b For #8643 and #7606 - Changed tint for onboarding icons 2020-05-06 09:18:27 +03:00
ValentinTimisica da3fca0f29 Fixes #10109: Adds content description for browse privately card content 2020-04-23 16:59:42 +03:00
Jeff Boek 4cbb9aebaf
Cleans up nav_graph.xml (#9829)
* For #9751 - Cleans up homeFragment directions

* For #9751 - Uses global actions for fragments not owned by homeFragment

* For #9751 - Cleans up SearchFragment directions

* For #9751 - Removes settings action from DeleteBrowsingDataFragment

* For #9751 - Removes browser action from SettingsFragment

* For #9751 - Adds ManagePhoneFeature global action

* For #9751 - Clean up unused deletebrowsingfragment actions

* For #9751 - Cleans Up HistoryFragment actions

* For #9751 - Removes Home -> Search action

* For #9751 - Removes the Bookmark -> Browser action

* For #9751 - Cleans up bookmark fragment actions

* For #9751 - Cleans up actions from ShareController

* For #9751 - Removes defaultBrowserFragment to browserFragment action

* For #9751 - Removes about -> browser action

* For #9751 - Adds global action to TrackingProtectionFragment

* For #9751 - Removes exception -> browser action

* For #9751 - Removes login -> browser action

* For #9751 - Fixes LoginFragment directions

* For #9751 - Removes ExternalAppBrowser directions

* for #9751 - Cleans up actions

* For #9751 - Fixes unit tests

* For #9751 - Addresses nits in PR
2020-04-13 21:43:45 -07:00
ekager b8fba63be4 For #9890 - Do not display full screen snackbar with toolbar padding 2020-04-13 14:56:51 -07:00
Mihai Adrian dfded8e69c
For #9687: Refactor onboarding cards to follow app architecture (#9743)
* For #9687: Refactor onboarding cards to follow app architecture

* For #9687: Update unit test to new controller parameters
2020-04-06 11:00:47 -07:00
Sawyer Blatz e3ed7ed268
Issue #9128 & #9222 & #9499: Refactors snackbar creation and fixes placement (#9628) 2020-04-02 12:30:13 -07:00
Mihai Adrian 9612c3f16d
For #8540: Fix ETP options not being correctly applied (#8688) 2020-02-26 12:25:40 -08:00
mcarare 314bee2abd For #8627: Add proper content description to ETP card clickable areas 2020-02-26 08:31:51 -08:00
mcarare a5ac7304bb For #8523: Also disable radio buttons clickable area when ETP is off 2020-02-19 10:48:01 -08:00
mcarare 372b1e7f0e For #6980: Update Private browsing card.
Added test to description.
Added link to settings.
Updated unit tests.
2020-02-13 14:13:57 -08:00
mcarare 1168fbd638 For #8299: Select current ETP policy set on card creation 2020-02-11 17:54:09 -08:00
mcarare 3ea5b08135 For #8190: Add animation to ETP policy selection 2020-02-07 15:50:39 -08:00
mcarare 5bd5f81559 For #6980: Add onboarding Toolbar position picker card 2020-02-07 09:05:03 -08:00
mcarare 9d993cae92 For #8146: Extend radio buttons clickable area to title and description 2020-02-06 16:34:37 +01:00
Mohammaduvez 00d7f4c91c
Fixes #5711 Added tint to onboarding icons (#8093)
* Added tint to onboarding icons and udpated finish button tint

* Replaced tint parameter with onboarding_card_icon color in setOnboardingIcon
2020-02-05 21:46:12 -08:00
Grisha Kruglov 3f9ed2992c Bump to a-s 0.50.0 2020-02-05 13:29:17 -05:00
Mihai Adrian 4eb71ce235
For #6980: Update ETP onboarding card (#7958) 2020-02-03 21:03:15 -08:00
ValentinTimisica 0a76fdaa58 For #7289: Adds telemetry for selecting dark theme 2020-02-03 23:20:42 +01:00
Mihai Adrian 24396d174f
For #6980: Add What's new card (#7952) 2020-01-29 08:50:11 -08:00
Chenxia Liu e5164e3670 For #6980 - Pre-land string changes to onboarding cards. 2020-01-21 16:28:36 -08:00
liuche 904098387a
Issue #7093 - Pre-land strings for new onboarding cards. (#7747) 2020-01-16 18:20:41 -08:00
Patrick Martin 71880705df For #5711 - Onboarding colours have contrast issues 2019-12-13 17:52:55 -08:00
Gabriel 56b21426eb
For #5574 - Migrate SessionControl to LibState (#6651)
* For #5574 - Part 1: Port TabAction.SaveTabGroup to TabSessionInteractor and SessionControlController. (#6651)

- Introduces the TabSessionInteractor, SessionControlInteractor and SessionControlController classes.
- Removes the TabAction.SaveTabGroup.

* For #5574 - Part 2: Port TabAction.PrivateBrowsingLearnMore to TabSessionInteractor and SessionControlController (#6651)

* For #5574 - Part 3: Port TabAction.ShareTabs to TabSessionInteractor and SessionControlController (#6651)

* For #5574 - Part 4: Remove unused TabAction.Share and TabItemMenu (#6651)

In #2205, the tab overflow button was removed which would have shown the
TabItemMenu when clicked. So, we can remove TabItemMenu since it is not
used and as a result, we can also remove TabAction.Share since there are
no consumers.

* For #5574 - Part 5: Port TabAction.PlayMedia and TabAction.PauseMedia to TabSessionInteractor and SessionControlController (#6651)

* For #5574 - Part 6: Port TabAction.Select to TabSessionInteractor and SessionControlController (#6651)

* For #5574 - Part 7: Port Onboarding.Finish to OnboardingInteractor and SessionControlController (#6651)

* For #5574 - Part 8: Port TabAction.Close and TabAction.CloseAll to TabSessionInteractor and SessionControlController (#6651)

- Removes TabAction

* For #5574 - Part 9: Port CollectionAction.Delete to CollectionInteractor and SessionControlController (#6651)

* For #5574 - Part 10: Port CollectionAction.ShareTabs to CollectionInteractor and SessionControlController (#6651)

* For #5574 - Part 11: Port CollectionAction.AddTab and CollectionAction.Rename to CollectionInteractor and SessionControlController (#6651)

* For #5574 - Part 12: Port CollectionAction.RemoveTab to CollectionInteractor and SessionControlController (#6651)

* For #5574 - Part 13: Port CollectionAction.OpenTab to CollectionInteractor and SessionControlController (#6651)

* For #5574 - Part 14: Port CollectionAction.CloseTabs to CollectionInteractor and SessionControlController (#6651)

* For #5574 - Part 15: Introduce a HomeFragmentStore (#6651)

- We will hook up the HomeFragmentStore in later parts.
- Removes List<Tab>.toSessionBundle(context: Context) since it is unused.

* For #5574 - Part 16: Port CollectionAction.Collapse and CollectionAction.Expand to CollectionInteractor and SessionControlController (#6651)

- We assume the store is hooked up to the SessionControlController in this part,
but this work will be done in a later part.
- Removes CollectionAction.

* For #5574 - Part 20: Remove the architecture module. (#6651)

* For #5574 - Part 17:  Remove duplicate subscribeToTabCollections in BrowserFragment.kt (#6651)

There is a duplicate call of subscribeToTabCollections() in both HomeFragment and BrowserFragment.
In this patch, we remove the call in BrowserFragment to avoid passing the HomeFragmentStore to
BrowserFragment in order to dispatch the CollectionsChange event.

* For #5574 - Part 18: Delete SessionControlComponent and fix TabCollection and Tab imports (#6651)

* For #5574 - Part 19: Use the new HomeFragmentStore in the HomeFragment (#6651)

- Renames SessionControlUIView to SessionControlView

* For #5574 - Part 21: Fix white screen on home fragment (#6651)

* For #5574 - Part 22: Fix formatting in SessionControlInteractor and replace See with @see in SessionControlController (#6651)

* For #5574 - Part 23: Move to metrics.track call to the beginning of handleCollectionRemoveTab (#6651)

This ensures that the metrics.track will be called immediately before the tab is removed from the collection.

* For #5574 - Part 24: Use the sessionManager getter in SessionControlController (#6651)

* For #5574 - Part 25: Use mapNotNull in List<Tab>.toSessionBundle (#6651)

* For #5574 - Part 26: Simplify closeTab and closeAllTabs functions by assigning a deletionJob constant (#6651)

* For #5574 - Part 27: Replace listOf() with emptyList() in removeAllTabsWithUndo (#6651)

* For #5574 - Part 28: Replace the Context parameter with the HomeActivity in SessionControlController (#6651)

* For #5574 - Part 29: Add test for HomeFragmentStore, DefaultSessionControlController and SessionControlInteractor (#6651)

* For #5574 - Removes running CI against the architecture debug build varient
2019-12-04 22:06:05 -05:00
Tiger Oakes 8c30200ced Only use Context.settings() function (not getter) (#5335)
Remove unused String extensions
2019-09-24 10:33:46 -07:00
Tiger Oakes b77c4d2e2e Clean up SupportUtils 2019-09-10 10:16:04 -07:00
Mihai Adrian a31eb1f371 Code Health #4883: Refactored accessing settings by using Context extensions (#4973) 2019-09-10 10:11:58 -07:00
Tiger Oakes 33f3b14c29 Adds setters and property delegates in `Settings` (#4809)
* Change Settings to use setters

* Add delegate for shared preferences
2019-08-20 10:47:55 -07:00
ekager 015922ddd2 No issue: Fix Crash lower API by setting gradient drawables in onBind 2019-08-02 16:18:34 -07:00
Grisha Kruglov ae33234bbc Closes #2593: FxA automatic sign-in integration 2019-08-01 17:03:45 -07:00
Mihai Adrian c74cb61455 fixes #4176 (#4175)
adds content description to 'browse privately' card, replacing placeholder %s with the header_text of card
2019-07-19 14:23:10 -05:00
Tiger Oakes 5de1678e65 No issue: Use putCompoundDrawables helper (#3982) 2019-07-15 08:24:59 -07:00
Tiger Oakes ef8d9604ae No issue: Normalize license header comment (#3909) 2019-07-12 11:38:15 -07:00
Tiger Oakes e8bd090a8e No issue: Use ImageView rather than rebuilding drawable (#3616)
HomeFragment's onboarding items included drawableStart values, but also
built drawables in the view holders to replace them. Instead, we should
just use ImageViews so that work isn't duplicated.
2019-06-26 16:03:06 -07:00
Tiger Oakes 30930cdc88 Import variables referred to by path 2019-06-25 13:57:34 -07:00