1
0
Fork 0
Commit Graph

230 Commits (69a9aeebae193107ba122bf60e5b60386666d85b)

Author SHA1 Message Date
ekager 655d2b8a88 For #12377 - Choice to hide no collections placeholder from homescreen 2020-08-24 16:48:50 -04:00
Elise Richards feae7fff2f
FNX-14498 ⁃ For #9487: improve fxa onboarding manual sign in card (#13317)
* Replace strings, add learn more, hook up button

* Constrain learn more and icon to the text

* View holder tests

* Lint

* Update homescreen ui test
2020-08-20 11:05:11 -05:00
Mugurell b993b94be1 For #12857 - Use Collection title when sharing tabs collection
Avoided passing the subject for sharing a collection of tabs in the ShareData
object since ShareData is part of a web standard.
2020-08-12 13:40:58 +03:00
ekager a1a839f237 For #13221 - Update global ETP to include PBM 2020-08-04 14:34:24 -04:00
Mihai Eduard Badea 58e24b81aa For issue #12400 - Refresh swiped collection tab view
Item is now refreshed by calling notifyDataSetChanged on the adapter when the last tab from the collection has been swiped away and the user cancels the deletion by pressing the cancel button from the dialog.
Also added a "wasSwiped" flag to onCollectionRemoveTab in order to check if the tab was deleted from a swipe action and not by pressing the "X" button.
2020-07-31 12:48:32 -04:00
ekager 6cdf304d10 No issue: Adds sameAs function for TopSiteList AdapterItem 2020-07-30 17:46:03 -04:00
ekager 3d3153039c For #11690 - Add contentsSameAs to avoid rebind of items in SessionControlAdapter 2020-07-30 15:18:04 -04:00
Tiger Oakes d8ff6179fe
For #7992: Use favicon style from AC (#12608) 2020-07-30 11:21:17 -07:00
Tiger Oakes 61d6b333de Update LongParameterList baseline 2020-07-27 14:20:34 -04:00
ekager e5e62fa79a For #6846: Added quick actions for nav bar in home 2020-07-27 13:28:28 -04:00
ekager 46511d6f8e For #10163 - Adds tab multiselect mode 2020-07-24 18:18:26 -04:00
Tiger Oakes 8f5a37733d
Create ToolbarPosition enum (#12747) 2020-07-22 19:23:38 -07:00
Tiger Oakes c08d375c18
Move settings in components (#12675) 2020-07-21 10:47:10 -07:00
mcarare 8826f99ef7 For #9722: Refactor onboarding buttons with text.
Add title and description to button text, remove extra Textviews.
2020-07-21 10:28:45 -07:00
Kainalu Hagiwara 02a929a926 No issue - Suppress new warnings from detekt update 2020-07-20 17:01:50 -07:00
Tiger Oakes eed20b43b9
Test session control controller (#12652) 2020-07-17 13:07:01 -07:00
Tiger Oakes d4bb432e24
Add helper for underlining text (#12520) 2020-07-15 22:38:46 -07:00
Tiger Oakes d0e9f1f165
Update Kotlin dependency (#10806) 2020-07-15 18:02:58 -07:00
Tiger Oakes e9fb1a61c7
Test viewholders in home.sessioncontrol (#12524) 2020-07-14 10:31:50 -07:00
Tiger Oakes 67ce5ad5d9
Add tests for onboarding viewholders (#11522) 2020-07-08 07:53:22 -07:00
Tiger Oakes 8e8e5aea36
Extract radio group logic into helper (#11493) 2020-07-06 17:09:42 -07:00
ValentinTimisica e39d5b6de7 For #11763: Shows confirmation dialog when deleting last tab from collection 2020-07-06 17:06:10 -04:00
mcarare 94273bc274 For #12125: Handle visibility updates for add to collection button. 2020-07-06 14:37:39 -04:00
Elise Richards 665fb8d60c
#10824: Onboarding telemetry (#11867)
* Onboarding events and tracking

* Rename metrics for consistency

* Add reference to PR for the data review

* Add default values to onboarding events
2020-06-25 13:21:31 -05:00
mcarare a056e86e4f For #8080: Dismiss menu when swiping away from its anchor. 2020-06-24 21:37:57 -04:00
Jeff Boek 2861421312 For #11112 - Adds save tabs to collection button to the no collections message 2020-06-23 08:17:55 -07:00
MarcLeclair b52091ed34
For #11660: added prefetch for topsites and update in onCreateView() (#11668)
* For #11660:added prefetch for topsites

TopSites will be prefetched with observerOnce (wrapper around observerForever).
Also, the SessionControlView.update() is called right away instead of waiting from consumeFrom
in the HomeFragment.onCreateView() which will allow the UI to render all at once on its first
perform traversal

* Removed the submitList(null) since it retriggered a drawing on lower end device
2020-06-18 19:43:20 -04:00
liuche 35fa445165
Issue #11112 - Update empty collections string + tests. (#11538) 2020-06-12 18:01:38 -04:00
mcarare 4b04a140fc For #11229: Update etp strict option title content description. 2020-06-11 10:20:01 +03:00
mcarare a0d9189321 For #11229: Update onboarding ETP copy. 2020-06-05 14:18:25 -04:00
Jeff Boek 52c2fdb310
Remove tab tray feature flag (#11176)
* For #11171 - Removes feature flag for the new tab tray

* For #11171 - Removes all tab references from homeFragment

* For #11171 - Fixes unit tests

* For #11171 - Gets UI tests to compile and HomeScreenTest to pass

* For #11171 - Fixes `deleteMultipleSelectionTest`

* For #11171 - Fixes `openHistoryItemInNewPrivateTabTest`

* For #11171 - Fixes `openHistoryInPrivateTabTest`

* For #11171 - Fixes `openHistoryInNewTabTest`

* For #11171 - Fixes `openNewPrivateTabTest`

* For #11171 - Fixes tabbedBrowsingTests

* For #11171 - Fixes SettingsPrivacyTest

* For #11171 - Fixes TopSitesTest

* For #11171 - Fixes lint errors

* Ignore
2020-06-05 12:59:08 -05:00
mcarare c4f7a32eae For #9583: Increase touch targets for onboarding elements. 2020-06-02 09:26:38 -04:00
Jeff Boek 8662164b8a
Refactors the TabTrayDialogFragment to ditch that weird interactor (#11061)
* For #11056 - Removes unused argument when navigating to the collection creation fragment

* For #11056 - Moved the collection creation navigation logic to the TabTrayDialogFragment

* For #11056 - Moves navigating to the share screen from home/browser to the TabTrayDialogFragment

* For #11056 - We moved tab selection logic from home/browser to the tab tray dialog

* For #11056 - Moved new tab tapped logic to the tab tray dialog fragment

* For #11056 - Removes all interactor logic for the TabTrayDialogFragment

* For #11056 - Migrates the presentation / navigation around the TabTrayDialog to the androidx navigation library
2020-05-29 17:17:56 -05:00
Jeff Boek 3946ec11de
Polish homescreen (#11065)
* For #10505 - Adjusts wordmark margins

* For #10505 - Removes topsite header, fixes collections header size and removes divider

* For #10505 - Restyle the top site items on the homescreen
2020-05-29 17:09:12 -05:00
David Walsh 4fdac4d608
For 10734 - Open tab tray when collection is opened from Home (#10751)
* For 10734 - Open tab tray when collection is opened from Home

* Update to work with tab tray drawer
2020-05-28 10:22:12 -05:00
Sawyer Blatz 7067e5c000
For #8125: Add default top site telemetry (#10752) 2020-05-22 13:10:09 -07:00
Christian Sadilek 4e25f41a41 For #1824: Prevent extremely long URLs from locking up HomeFragment 2020-05-21 13:11:07 -04:00
Tiger Oakes f7b4f1c959
Cache findViewById calls in session control (#10575) 2020-05-12 14:05:08 -07:00
Jeff Boek 58ca5d0e3a For #10341 - Always show collections placeholder with new tab tray enabled 2020-05-07 15:38:17 -07:00
Mihai Branescu 6f97e75579 For #8643 and #7606 - illustrations are now connected to their radio buttons 2020-05-06 09:18:27 +03:00
Mihai Branescu cde31cf785 For #8643 and #7606 - Changed toolbar picker illustrations according to theme 2020-05-06 09:18:27 +03:00
Mihai Branescu 16b7a9399b For #8643 and #7606 - Changed theme picker illustrations according to theme 2020-05-06 09:18:27 +03:00
Mihai Branescu 4c0af91b7b For #8643 and #7606 - Changed tint for onboarding icons 2020-05-06 09:18:27 +03:00
Jeff Boek a8a90bd4d6
For #1063: Put tab tray behind a feature flag and hidden pref (#10313)
* For #1063 - Adds feature flag and pref for new tab tray

* For #1063 - Swaps add tab to tab tray button when newTabTray is enabled

* For #1063 - Creates hidden preference to use new tab tray

* For #1063 - Hides tabs on home screen when setting is enabled

* For #1063 - Navigate to new tab tray from browser with setting enabled

* For #1063 - Fixes regression where we dont show the new tab message with no tabs and no collections

* For #1063 - Fixes crash when toggling to private mode on the home screen

* For #1063 - combines both settings. Cleans up lint errors
2020-04-30 15:53:10 -05:00
mcarare 1aa473b112 For #9913, For #9914: Remove touch delegate when button is disabled. 2020-04-27 11:57:51 -07:00
mcarare e830da59b7 For #10180: Remove touch delegate when button is disabled.
Also refactored multiple if's into a when.
2020-04-24 13:28:29 -07:00
mcarare 2edd4b39a4 For #9913, For #9914: Remove button when disabling it.
Setting visibility to GONE allows clicks to parent view in that space.
2020-04-24 16:42:47 +03:00
mcarare cc67de29bf For #10091 Also disable play/pause button when hiding it. 2020-04-23 09:22:01 -07:00
ValentinTimisica da3fca0f29 Fixes #10109: Adds content description for browse privately card content 2020-04-23 16:59:42 +03:00
ekager c4e83367f6 For #6832 - Fix various fragment not attached to a context crashes 2020-04-22 20:56:35 -07:00