1
0
Fork 0
Commit Graph

22 Commits (69a9aeebae193107ba122bf60e5b60386666d85b)

Author SHA1 Message Date
Kainalu Hagiwara 09473b991d For #12926 - Add back button to menu. 2020-08-11 10:36:55 -07:00
Jeff Boek 46f010f247 For #2681 - Adds ability to bypass cache when reloading 2020-07-27 12:11:11 -07:00
Kainalu Hagiwara 921b16233b For #1048 - Add ability to view tab history by long-pressing the back or forward button. 2020-07-22 11:20:47 -07:00
ValentinTimisica e9bb11e22d Fixes #9205: Changes add-ons and 'Open links in apps' icons from menus 2020-06-22 12:09:19 +03:00
Roger Yang 538a7917e4
Closes #10906: Add Open in app option in custom tab (#10929) 2020-05-26 14:37:53 -04:00
mcarare a214f04b4a For #9698: Use extension to ensure fallback to English and avoid crash 2020-04-13 09:40:00 +03:00
Tiger Oakes 383a70482c Clean up toolbar menu class 2020-02-06 00:25:42 +01:00
Tiger Oakes 55c1b01d7b For #7431: Remove extra share button 2020-01-11 11:48:51 -08:00
mcarare b115a00589 For #7155 Align custom tabs overflow menu to original mocks
Reverse menu items order when toolbar position is top
2020-01-08 11:50:17 -07:00
Tiger Oakes 32985af882 For #6830 - Fix "Open in" text size for custom tab (#7010) 2019-12-12 11:49:54 +02:00
Severin Rudie 6909a76bcb
4281 remove qab (#6310)
* For #4281: small ToolbarMenu refactor

This makes it easier to see how items are ordered in the menuItems list

* For 4281: add QAB buttons to menu

* For 4281: removed menu back button per mocks

I double checked with UX, and we'll be relying on the hardware back button for its functionality

* For 4281: add content descriptions for bookmarking

* For 4281: updated BrowserToolbarController for new functionality

* For 4281: provided simple dependencies to browser controller

More complex changes will be in a following commit, for review readability

* For 4281: move toolbar controller dependencies up to BaseBrowserFragment

The functionality they control is being moved into the toolbar menu, which is shared by both normal tabs and custom ones

* For 4281: removed (now unused) code related to QAB

* For 4281: fix test compilation after QAB removal

Tests still need to be expanded to include added functionality

* For 4281: updated menu to show if url is bookmarked

This sloppy workaround is required because TwoStateButton requires that `isInPrimaryState` be a synchronous call, and checking whether or not the current site is bookmarked is quite slow (10-50 MS, in my tests).  After days of work and many attempted solutions, this was the least abhorrent among them.

https://github.com/mozilla-mobile/android-components/issues/4915 was opened against AC to evaluate potentially supporting async `isInPrimaryState` functions.
https://github.com/mozilla-mobile/fenix/issues/6370 was opened against Fenix to investigate the unexpectedly slow call to `BookmarkStorage`.

* For 4281: update reader mode switch

* For 4281: selectively show/hide menu items

* For 4281: add reader mode appearance

* For 4281: update bookmark button when it is clicked

* For 4281: removed unused QAB code

* For 4281: removed QAB robot, updated UI tests

* For 4281: removed QuickActionSheet metrics

Since this behavior now lives in the toolbar, it is tracked via Event.BrowserMenuItemTapped

* For 4281: fixed lint errors

* For 4281: add new strings for buttons added to menu

This is necessary because the location change (from QAB to toolbar menu) could affect the grammar in some languages

* For 4281: remove outdated TODOs

* For 4281: removed QAB container

* For 4281: removed back button reference from UI test

This button no longer exists

* For 4821: Fixes a visual defect (extra padding on top of toolbar)

* For 4281: update copy on reader mode

* For 4281: fixed review nits
2019-11-11 17:10:14 -08:00
Tiger Oakes 9456998f9f For #6153 - Add powered by notification 2019-10-31 16:39:58 -07:00
Tiger Oakes c475bc87cf Move classes out of top-level package 2019-08-21 13:52:30 -07:00
Tiger Oakes ef8d9604ae No issue: Normalize license header comment (#3909) 2019-07-12 11:38:15 -07:00
Emily Kager ce2d597af3 For #203 - Adds find in page and request desktop site to custom tab menu (#3835) 2019-07-02 14:41:29 -07:00
Emily Kager 9624964bc3 For #3087 - Adds disabled color attr (#3192)
* For #3087 - Adds disabled color attr

* Change alpha to 40%
2019-06-05 20:37:16 -05:00
Jeff Boek a7d5cdcb9d For #2723 - Fixes theme manager 2019-05-30 16:38:31 -07:00
jhugman 34bd6513b6 Fixes 1689 - Add sessionManager and sessionId to custom tabs menu and toolbar. (#2229) 2019-05-02 14:32:04 -05:00
Emily Kager 59a4340f65 Closes #2172 - Tint Share Icon in Custom Tab Menu 2019-04-30 14:33:16 -07:00
Sawyer Blatz 4cd0d464a7
For #1092: Fixes ordering of custom tab menu items (#2072) 2019-04-26 13:54:38 -07:00
Emily Kager 7f5f96b41b Closes #1914 - Removes incomplete actions from Custom Tab Menu 2019-04-23 17:46:55 -05:00
Sawyer Blatz ec35283c9a For #668: Restyles custom tabs 2019-04-15 11:31:13 -07:00