ekager
24b3ed4384
For #5568 - Don't pass in Session for QuickActionSheetController
2019-09-25 13:33:38 -07:00
Tiger Oakes
8c30200ced
Only use Context.settings() function (not getter) ( #5335 )
...
Remove unused String extensions
2019-09-24 10:33:46 -07:00
Mihai Adrian
a31eb1f371
Code Health #4883 : Refactored accessing settings by using Context extensions ( #4973 )
2019-09-10 10:11:58 -07:00
Sebastian Kaspari
ac32a88d45
Rename BrowserStore/State/Action to BrowserFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
Amaan Marfatia
dc9fdd9db3
Fixes #4067 besides snackbar ( #4777 )
...
* Fixes #4067 besides snackbar
Makes layout hierarchy more shallow to increase performance.
* Fix #4067 Feedback
Make sure quick_action_overlay appears on top and use horizontal chain in tab_header.
2019-08-27 10:09:55 -07:00
Jeff Boek
68f5d211d3
For #4326 - Updates codebase to support latest version of detekt
2019-08-21 13:50:51 -07:00
Tiger Oakes
de14962e3f
Extract quick action sheet observer code ( #4368 )
2019-08-19 08:28:33 -07:00
Colin Lee
5b4a441bcb
For #1667 : Screen reader can't reach other UI items when QAB expanded ( #4695 )
2019-08-14 09:56:29 -07:00
Sawyer Blatz
0ec92d716f
For #4123 : Adds telemetry for quick action open in app ( #4629 )
2019-08-09 13:51:12 -07:00
Sawyer Blatz
6fa022c2f8
For #4124 : Migrate BrowserToolbar to Libstate ( #4279 )
...
* For #4124 : Migrate BrowserToolbar to Libstate
* Restores QuickActionSheetReducer
* Improve tests
* Make QuickActionSheetController
* Finalize tests
* Breaks out QuickActionSheetState
* Fix comments
* Adds BrowserStoreTest
2019-07-29 12:39:36 -07:00
Sawyer Blatz
7588251f8b
Closes #3986 & Closes #3661 : Migrate QuickActionSheet to LibState & add tests ( #4058 )
...
* Closes #3986 : Migrate QuickActionSheet to LibState
* Closes #3661 : Add tests for QuickActionSheet
Co-authored-by: boek <jeff@jeffboek.com>
* For #3986 : Fix feedback
2019-07-22 10:31:31 -07:00
Nikit Bhandari
f110ba2861
use synthetic binding instead of findviewbyid
2019-07-19 16:51:26 -04:00
James Hugman
62850430b7
Closes AC#3695 - Add UI to open current page in external app
2019-07-18 15:33:31 -04:00
Tiger Oakes
5de1678e65
No issue: Use putCompoundDrawables helper ( #3982 )
2019-07-15 08:24:59 -07:00
Tiger Oakes
ef8d9604ae
No issue: Normalize license header comment ( #3909 )
2019-07-12 11:38:15 -07:00
Emily Kager
1f108f3c88
For #3806 - Adds corner radius to QAB and dialogs
2019-07-11 12:57:27 -04:00
Sören Hentzschel
eb1ea882cf
For #2425 - QAB showed wrong text for bookmarked pages ( #3794 )
...
* For #2425 - QAB showed wrong text for bookmarked pages
* fixed linting issue
2019-07-01 11:45:52 -05:00
Sawyer Blatz
763c8be815
For #2689 : Turns dynamic toolbar into fixed toolbar
2019-05-23 08:37:00 -07:00
Sawyer Blatz
9509ce1b12
For #911 : Adds reader mode notification on first launch
2019-05-23 08:27:07 -07:00
Jeff Boek
c5e5ef4b25
Teases apart ViewModel dependencies ( #2499 )
...
* No Issue - pulls render outside of the viewmodel
* No Issue - Properly subscribes to the changesObservable
* No Issue - Fixes ViewModel tests
2019-05-14 23:16:48 -07:00
Colin Lee
49ac62ab85
Fix ViewModel States ( #2457 )
...
Co-authored-by: Jeff Boek <jeff@jeffboek.com>
2019-05-14 13:49:02 -07:00
Sawyer Blatz
b71eeb9fb3
For #2245 : Updates quick action bar state and animation ( #2451 )
...
* Revert quick action changes
* For #2245 : Updates quick action bar state and animation
2019-05-14 08:14:41 -07:00
Colin Lee
ccbc14a71f
For #1994 : Re-architect state handling code ( #2382 )
2019-05-09 23:06:12 +00:00
Christian Sadilek
9b0422b062
Issue #910 : Integrate feature-readerview component ( #2269 )
...
Closes #908 , Closes #910 , Closes #911 , Closes #912
Co-authored-by: Jonathan Almeida <jalmeida@mozilla.com>
2019-05-03 21:01:45 +00:00
Colin Lee
85eef5796a
No issue: Fix QAB handle lingering onscreen ( #2244 )
2019-05-02 16:25:17 -05:00
Colin Lee
39eb107335
For #2206 : Quick Action Bar fixes, do not hide, add shadow, peek initially ( #2238 )
2019-05-02 15:08:49 -05:00
Sawyer Blatz
473b528ea1
No issue: Improves scrolling of quick action sheet ( #2079 )
2019-04-26 11:35:57 -07:00
Emily Kager
99f979e86b
For #1601 - Bookmark icon should change visually if page is bookmarked
2019-04-25 17:29:27 -07:00
Sawyer Blatz
9e9b6f98f9
Fixes #2030 : Quick action sheet collapses on scroll
2019-04-25 13:01:31 -07:00
Emily Kager
911ef446ab
No issue: Fixed visibility bugs in quick action sheet ( #1927 )
2019-04-23 11:46:52 -07:00
Emily Kager
72410b18bd
Closes #1912 - Quick action bottom sheet should fade in
2019-04-22 23:25:15 -07:00
Emily Kager
dad4149b81
For #1542 - Add ripple to quick action buttons
2019-04-10 19:12:05 -07:00
Sawyer Blatz
5fc1e9227f
Closes #1195 : Adds telemetry for quick action sheet ( #1362 )
2019-04-05 15:08:55 -07:00
Colin Lee
bd81e72239
Fixes #916 , fixes #917 , fixes #920 : Save, share, and delete bookmarks
2019-04-01 16:16:08 -05:00
Eitan Isaacson
4f67b7a26c
Fixes #1186 : Make quick actions invisible to screen reader when collapsed.
...
The buttons in the quick actions sheet are not visible or interactive
when the sheet is collapsed. They should not be visible to AT users
either.
2019-03-29 12:47:19 -07:00
Eitan Isaacson
f9ea856b34
Fixes #1186 : Add AccessibilityActions to quick action sheet's handle
...
Adding the 'click' action allows the user to activate the button with a
default action (double tap in TalkBack). This is instead of
conditionally setting up a click listener if TalkBack is enabled. This
is a more generalized solution that accomodates other ATs besides
TalkBack.
Adding an expand or collapse action also tells TalkBack what the current
state of the sheet is, and reports it to the user. So they will
initially hear "collapsed, quick actions, button". When they double tap,
they will hear "expanded". Adding those actions also allows TalkBack and
other AT users to explicitly call those actions on that element with a
menu or a gesture binding.
2019-03-29 12:47:19 -07:00
Eitan Isaacson
c807f84b98
Fixes #1186 : Made quick actions sheet's handle larger.
...
It now takes up the entire horizontal space and all the vertical space
until the buttons. This gives a bigger touch target both for typical
users and TalkBack users when they use explore-by-touch.
Also changed content description. The content description should not
include semantic names like "handle". The screen reader already knows
it's a button and describes it as such. Same thing with "sheet".
2019-03-29 12:47:19 -07:00
Sawyer Blatz
0f1e65bdab
Closes #1127 : Improves accessibility of quick action sheet
2019-03-21 14:07:17 -05:00
Sawyer Blatz
da35581c54
For #1072 : Fixes nits
2019-03-21 12:54:08 -05:00
Sawyer Blatz
0a449dc12c
For #1072 : Adds onAttachedToWindow
2019-03-21 12:54:08 -05:00
Sawyer Blatz
6dcc026e04
For #1072 : Adds accessibility support
2019-03-21 12:54:08 -05:00
Sawyer Blatz
486bfc2d68
For #1072 : Adds cap to auto bounce
2019-03-21 12:54:08 -05:00
Sawyer Blatz
7accf07d48
For #1072 : Fixes lint errors
2019-03-21 12:54:08 -05:00
Sawyer Blatz
c0ceeb8cb6
For #1072 : Increases touch target of grabber handle
2019-03-21 12:54:08 -05:00
Sawyer Blatz
504fc41e51
For #1072 : Modifies icons
2019-03-21 12:54:08 -05:00
Sawyer Blatz
d2af87f8f8
For #1072 : Adds grabber handle bounce animation
2019-03-21 12:54:08 -05:00
Sawyer Blatz
4acd939289
For #1072 : Adds grabber handle
2019-03-21 12:54:08 -05:00
Sawyer Blatz
994d88542e
For #1072 : Adds basic view
2019-03-21 12:54:08 -05:00