1
0
Fork 0
Commit Graph

4501 Commits (638e7c6e47eb4510d77c011254292899061db4a5)

Author SHA1 Message Date
mozilla-l10n-automation-bot c66480d6dd
Import l10n. (#12687) 2020-07-19 21:30:11 -07:00
MickeyMoz f41a93894d Update Android Components version to 51.0.20200719130512. 2020-07-19 11:24:12 -04:00
MickeyMoz 610be6d014 Update Android Components version to 51.0.20200718130042. 2020-07-18 13:30:04 -04:00
Christian Sadilek 16b6776938 Update Android Components to 51.0.20200717190031 2020-07-17 19:32:02 -04:00
Tiger Oakes 499f185fc0
Fix lint issues (#12683) 2020-07-17 16:20:08 -07:00
Tiger Oakes 693af257aa
Change enabled lint rules (#12517) 2020-07-17 15:17:16 -07:00
Tiger Oakes 13949d6968
Test migration classes (#12677) 2020-07-17 14:35:13 -07:00
Tiger Oakes 67fda80453
Add tests for login exceptions (#12681) 2020-07-17 14:25:45 -07:00
Tiger Oakes aa31eb0fa5
Fix failure in handleWhatsNewGetAnswersClicked (#12682) 2020-07-17 14:25:35 -07:00
Mihai Adrian Carare 9c1b586e45
For #7966: Update toolbar content description. (#12667) 2020-07-17 16:22:13 -05:00
Elise Richards 37af9df3ad
For #12532: Align Settings -> Site permissions -> Sub-pages to 72dp keyline (#12680)
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
2020-07-17 15:54:57 -05:00
Mihai-Eduard Badea 1823fdb66d
For issue #9949 - Bookmarks/History deletion inconsistencies (#12630)
- Added the undo action for deleting individual history items by creating a new field to the history state containing the id's of the history items that are pending for deletion; This field is used inside the update function from the view to show/hide the items.

 - Added a new check inside the "deleteMulti" method from BookmarkFragment that calls the showRemoveFoldersDialog to prevent the user from being able to delete one or more bookmark folders without being asked for confirmation, as in #8648.

Co-authored-by: Mihai Eduard Badea <mihai.badea@softvision.ro>
2020-07-17 15:13:18 -05:00
Tiger Oakes eed20b43b9
Test session control controller (#12652) 2020-07-17 13:07:01 -07:00
Hakkı Kaan Çalışkan aa7655f4d6 For #12509: Set height of remove add on button to 36dp 2020-07-17 12:55:36 -07:00
ekager 455e7b8f99 Update ContextMenuUseCases to just take a store 2020-07-17 14:49:10 -04:00
ekager 3ac2627064 Update Android Components to 51.0.20200717130954 2020-07-17 14:49:10 -04:00
ekager e1ef5f55ec For #12453 - Sets secure flags on private tab of tabs tray 2020-07-17 13:24:25 -04:00
ekager e358f95eed For #12364 - Only show PWA prompt the third time a user visits installable site 2020-07-17 12:37:03 -04:00
Tiger Oakes ac3df6bc5e
Add tests for adapters in collections (#12649) 2020-07-17 09:04:16 -07:00
Aaron Train 074b013916
Update Flank to v20.07.0 (#12640) 2020-07-17 09:31:20 -04:00
Kainalu Hagiwara 2fe17a6220
For #12531: Align Settings -> Private browsing to 72dp keyline (#12654)
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
2020-07-16 22:26:49 -07:00
Elise Richards 023a4983fa
For #10173: login duplicates and save (#11208)
* Extract controller into it's own class. Implement find dupes and filter based on username.

Create edit login controller. Add text watchers and check for duplicates.

Edit controller test

* Find duplicates and save to store

* Retrieve duplicates from AC and check list on username text changed

Move duplicates logic into the controller

* Add glean pings for delete and edit. Move logic for login manipulation into the datastore.

* Use correct threads in controller. Enable save button when applicable.

Save enabled in datastore.

Move login data to datastore

Rebase with password error states

Update metrics to be more specific for edit

* Create logins controller for AC calls

* Interactor and controller methods for edit login. Add edit view to separate out some layout manipulation.

Inflate view in edit fragment. Double layout showing up.

Edit view

Controller tests

Controller tests passing

Interactor tests

Lint and detekt cleanup

* Remove datastore and use storage controller for all logins calls to password storage.

Addressed comments

Lint
:

Rebase - 1
2020-07-16 17:08:04 -05:00
Tiger Oakes 4dd0c0f224
For #12457: Add MockK matcher for intents (#12612) 2020-07-16 15:05:01 -07:00
Mugurell e1fc0cc038
Ensure logins deletion (#12507)
* For #11227 - Cleanup saved logins list when one is selected

Selecting a saved login will open a detail screen for it from where users can
change details or even delete that particular login.
After the change is made the user is brought back to the list of saved logins
where for a brief moment (< 1s) until we get a new response from
passwordsStorage.list() the user can see and even interact with the old list
of items, which may still contain the just deleted one.

To avoid users seeing obsolete logins or even interacting with them (selecting
a previosuly deleted item will result in a crash) we will clean the list of
logins just before the selected login is opened in the detailed view.
When returning for a brief moment the users may see the "loading" UX until
passwordsStorage.list() returns the up-to-date list of logins to display.

* For #11227 - Refactor SavedLoginsView to be closer to MVI

- Interactors should only get passed other Interactors or Controllers as
dependencies to which they should delegate user actions.
- Controllers should hold most of the business logic and get passed all final
dependencies they need to do their job.
2020-07-16 14:40:08 -05:00
Tiger Oakes 2d066d77ad
Add tests for sync, wifi, and push (#12581) 2020-07-16 12:25:38 -07:00
Tiger Oakes 2291fb07aa
For #12565: Add Locale settings tests & use activity (#12579) 2020-07-16 11:43:27 -07:00
jhugman 3373f8b987
For #12600 - remove AddonInstalled event when the permission dialog is shown (#12601) r=csadilek,sblatz 2020-07-16 19:40:39 +01:00
Mihai Branescu 9373e7fcf4
For #12201 - forced callbacks to be on the main thread (#12543) 2020-07-16 13:39:31 -05:00
Elise Richards 4fe1fb8f4a
No issue: Delete unnecessary to-dos (#12603)
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
2020-07-16 13:38:07 -05:00
Hakkı Kaan Çalışkan b997fba953 No issue: Move dp's to dimens.xml 2020-07-16 13:08:55 -04:00
Kainalu Hagiwara b867e0de45 Update TabTrayViewHolder with A-C thumbnail changes. 2020-07-16 12:50:33 -04:00
Roger Yang 7923255fda For #12118: Add isSubframeRequest parameter for app links 2020-07-16 12:50:33 -04:00
MickeyMoz aaa2cfe2c7 Update Android Components version to 51.0.20200716130034. 2020-07-16 12:50:33 -04:00
Christian Sadilek a0d9cdc450 For #12248: Webcompat reporter not active in Nightly 2020-07-16 12:24:21 -04:00
jhugman fb1d7e12e6
For #11704 Add leanplum attributes for tracking protection (#11965) r=sblatz
* For 11657: add LP attribute for tracking protection

* For #11704: added tracking_protection_enabled attribute

* Added docs for the new attributes, linking to data-review to the mma.md

* Rename null to none when no ETP is enabled
2020-07-16 17:09:32 +01:00
Hakkı Kaan Çalışkan 057711e6fb No issue: Uncomment forgotten assert 2020-07-16 11:45:53 -04:00
Tiger Oakes 667261f511 Closes #12493: Remove kapt plugin 2020-07-16 10:38:03 -04:00
Hakkı Kaan Çalışkan cdd5d206fd For #12105: Follow ux mock on Settings --> Accessibility screen 2020-07-16 10:37:20 -04:00
James Hugman 798c1bf743 Address review comments 2020-07-16 10:37:03 -04:00
James Hugman 22689a9ff5 Remove need to specify component names for new intents 2020-07-16 10:37:03 -04:00
James Hugman 98a33ea82b Changed home_* style links to urls_* to reflect that the destination is a set of links, rather than where the screen is 2020-07-16 10:37:03 -04:00
James Hugman 1629878a66 Add install_search_widget 2020-07-16 10:37:03 -04:00
James Hugman 7bd2b5b0c9 Add 8 deeplinks to mma.md documentation 2020-07-16 10:37:03 -04:00
James Hugman 4573d09fd8 Add UI tests for deep links 2020-07-16 10:37:03 -04:00
James Hugman 709fedd4d7 Add unit tests for deep links 2020-07-16 10:37:03 -04:00
James Hugman 8130aaa2cc Add deep links for settings and home screens 2020-07-16 10:37:03 -04:00
isabelrios 5b61b44f1a
cron-job-ui-screenshots (#12423)
Co-authored-by: isabel rios <isabelrios@MacBook-Pro-de-isabel-2.local>
2020-07-16 16:08:00 +02:00
Mugurell d449184faa For #12544 - Prevent search engines mixup
Stricter synchronization by always using the same "loadedSearchEngines"
variable.
With "loadedSearchEngines" calling "refreshAsync()" we also get the fallback
engines to contain reddit and youtube (which are programatically added) and
also now we properly remember and display the engines added by user.
2020-07-16 16:49:54 +03:00
Oana Horvath af3c232615 Replaces verifyPageContent in UI tests 2020-07-16 10:55:58 +03:00
Tiger Oakes 6be39aebde
Add tests for StartupReportFullyDrawn (#12560) 2020-07-15 23:31:59 -07:00