1
0
Fork 0
Commit Graph

55 Commits (52d4ffdef07769ca026f02b460025f70e95bb541)

Author SHA1 Message Date
Kainalu Hagiwara 52d4ffdef0 For #13424 - Fix detekt config and warnings. 2020-08-12 09:04:24 -07:00
Kainalu Hagiwara 09473b991d For #12926 - Add back button to menu. 2020-08-11 10:36:55 -07:00
Kainalu Hagiwara 17bb010cc3 For #13235 - Add haptic feedback when long pressing forward button. 2020-08-04 12:19:12 -07:00
Jeff Boek 46f010f247 For #2681 - Adds ability to bypass cache when reloading 2020-07-27 12:11:11 -07:00
ekager e5e62fa79a For #6846: Added quick actions for nav bar in home 2020-07-27 13:28:28 -04:00
ekager 058f44e82d For #12721 - Remove SessionManager usages in TabCounter 2020-07-25 18:37:45 -04:00
Tiger Oakes 8f5a37733d
Create ToolbarPosition enum (#12747) 2020-07-22 19:23:38 -07:00
Christian Sadilek 216396d979 For #12353: URL copied to clipboard should not be extension/reader URL 2020-07-08 16:55:32 -04:00
Mihai Branescu 3c2c7f705c For #10467 - blue dot doesn't disappear on menu dismiss 2020-06-24 21:33:32 -04:00
Jeff Boek cd3b6181b3 For #10374 - Adds quick contextual menu to tab switcher
Co-authored-by: person808 <kainaluh808@gmail.com>
2020-06-10 16:50:28 -07:00
Sawyer Blatz 27c7ef5ad4 For #8775: Removes feature flag for dynamic bottom toolbar 2020-06-09 20:58:17 -07:00
Sawyer Blatz e9189dc089 For #11045: Add reader mode to urlView 2020-06-08 15:12:03 -07:00
mcarare e11f1b62dc For #10027: Make toolbar context menu popup dismissible on SDK<23 2020-04-22 22:47:46 -07:00
Sawyer Blatz a8e624959e
For #6940: Fixes top dynamic toolbar behavior (#9900) 2020-04-17 13:32:20 -07:00
ekager b8fba63be4 For #9890 - Do not display full screen snackbar with toolbar padding 2020-04-13 14:56:51 -07:00
Christian Sadilek 0f1bff7402 No issue: Refactor readerview to use browser-state 2020-04-07 16:31:03 -04:00
Sawyer Blatz e3ed7ed268
Issue #9128 & #9222 & #9499: Refactors snackbar creation and fixes placement (#9628) 2020-04-02 12:30:13 -07:00
Sawyer Blatz 208a58bc58
Issue #9598 & #8697: Fixes force expand crash (#9599) 2020-04-01 12:32:00 -07:00
Sawyer Blatz 1a2b65d854
Issue #9472: ForceExpand browser toolbar when navigating (#9552) 2020-03-31 11:16:40 -07:00
Kate Glazko 47b2f6a070 For 7077 Simplify Display Url 2020-03-23 12:36:48 -07:00
mcarare 14338a3b13 For #8899: Set viable anchor for snackbars in both custom and normal tab 2020-03-20 22:46:59 -07:00
Mihai Branescu 485efacd33 For #8800 - dismiss all highlights when menu is closed 2020-03-11 19:05:55 +02:00
Christian Sadilek 20387401b1 Issue #7863: Ensure parent process triggers speculative connect 2020-03-03 14:19:18 +01:00
ekager a6b07afa95 No issue: Fix LeakCanary detected memory leaks
Co-authored-by: Emily Kager <emilykager@gmail.com>
Co-authored-by: Pierre-Yves Ricau <py@squareup.com>
2020-02-28 13:29:16 -08:00
mcarare 5a6fc02976 For #8773: Set proper anchor and padding for Snackbars on browser screen 2020-02-28 13:23:11 -08:00
mcarare 3b5eadcc70 For #8372: Set toolbar position relative anchor for url copied snackbar 2020-02-13 20:42:05 -08:00
Tiger Oakes 383a70482c Clean up toolbar menu class 2020-02-06 00:25:42 +01:00
Emily Kager 46fd1a04f1 For #7456 - For top toolbar set correct progress gravity and background 2020-02-05 19:14:14 +01:00
mcarare b115a00589 For #7155 Align custom tabs overflow menu to original mocks
Reverse menu items order when toolbar position is top
2020-01-08 11:50:17 -07:00
Sawyer Blatz 3fb060f682
For #6413: Fixes snackbar positionining for bottom toolbar (#7415)
* For #6413: Fixes snackbar positionining for bottom toolbar

* For #6413: Cleans up snackbar usage
2019-12-30 14:43:15 -08:00
Rushab Kumar 562eb89356 For #7250 - Replace anko.dimen 2019-12-18 15:39:14 -08:00
Tiger Oakes ea486d7c66
Split out CustomTabToolbarIntegration (#7107) 2019-12-17 12:26:46 -08:00
Emily Kager d1b134c2ff For #6908 - Set null anchors for snackbars with top toolbar (#6911) 2019-12-04 15:01:04 -08:00
Jeff Boek e8972bb47d For #6795 - Auto shows toolbar when loading a new URL (#6955)
Co-authored-by: Severin <Baron-Severin@users.noreply.github.com>
2019-12-04 15:00:51 -08:00
Sawyer Blatz 769c1e422d For #5694 & #6054: Allows users to change toolbar position (#6608)
* For #5694 & #6054: Adds preference screen for toolbar

* For #5694: Adds changing toolbar position functionality

* No issue: Updates telemetry links to actually work lol 😬

* For #6054: Adds toolbar position to core ping
2019-11-25 16:43:32 -08:00
Severin Rudie 6909a76bcb
4281 remove qab (#6310)
* For #4281: small ToolbarMenu refactor

This makes it easier to see how items are ordered in the menuItems list

* For 4281: add QAB buttons to menu

* For 4281: removed menu back button per mocks

I double checked with UX, and we'll be relying on the hardware back button for its functionality

* For 4281: add content descriptions for bookmarking

* For 4281: updated BrowserToolbarController for new functionality

* For 4281: provided simple dependencies to browser controller

More complex changes will be in a following commit, for review readability

* For 4281: move toolbar controller dependencies up to BaseBrowserFragment

The functionality they control is being moved into the toolbar menu, which is shared by both normal tabs and custom ones

* For 4281: removed (now unused) code related to QAB

* For 4281: fix test compilation after QAB removal

Tests still need to be expanded to include added functionality

* For 4281: updated menu to show if url is bookmarked

This sloppy workaround is required because TwoStateButton requires that `isInPrimaryState` be a synchronous call, and checking whether or not the current site is bookmarked is quite slow (10-50 MS, in my tests).  After days of work and many attempted solutions, this was the least abhorrent among them.

https://github.com/mozilla-mobile/android-components/issues/4915 was opened against AC to evaluate potentially supporting async `isInPrimaryState` functions.
https://github.com/mozilla-mobile/fenix/issues/6370 was opened against Fenix to investigate the unexpectedly slow call to `BookmarkStorage`.

* For 4281: update reader mode switch

* For 4281: selectively show/hide menu items

* For 4281: add reader mode appearance

* For 4281: update bookmark button when it is clicked

* For 4281: removed unused QAB code

* For 4281: removed QAB robot, updated UI tests

* For 4281: removed QuickActionSheet metrics

Since this behavior now lives in the toolbar, it is tracked via Event.BrowserMenuItemTapped

* For 4281: fixed lint errors

* For 4281: add new strings for buttons added to menu

This is necessary because the location change (from QAB to toolbar menu) could affect the grammar in some languages

* For 4281: remove outdated TODOs

* For 4281: removed QAB container

* For 4281: removed back button reference from UI test

This button no longer exists

* For 4821: Fixes a visual defect (extra padding on top of toolbar)

* For 4281: update copy on reader mode

* For 4281: fixed review nits
2019-11-11 17:10:14 -08:00
ValentinTimisica 1e13e70cd0 Fixes #5917: Show snackbar when URL is copied (#6210)
Show a snackbar to the user for him to know that the URL was copied to
clipboard.
2019-10-31 16:53:00 -07:00
Sebastian Kaspari 9543f38978 Use new toolbar API of AC 18.0.0. 2019-10-24 08:57:30 -07:00
Emily Kager f9afd97a68 For #1901 - Get rid of black flash when leaving GV Engine 2019-10-09 11:02:21 -07:00
Mihai Adrian 236f702bbe For#5468 Changed info source for url clipboard copy from view to session (#5514) 2019-09-24 07:56:59 -07:00
Sawyer Blatz 2db2d9ceae For #1744: Adds tests for clipboard 2019-09-19 08:24:27 -07:00
Sawyer Blatz fd1fcd8b89 For #4155: Adds paste & go for search terms 2019-09-19 08:24:27 -07:00
Sawyer Blatz e961a9d63d For #1744: Adds clipboard provider to search engine screen 2019-09-19 08:24:27 -07:00
Sawyer Blatz 42b31f0088 For #4155: Adds elevation to copy/paste menu 2019-09-12 14:03:12 -07:00
Sawyer Blatz 5586b18c3e For #4155: Handle custom tabs & fix test 2019-09-11 09:03:17 -07:00
Sawyer Blatz 9d30d7bb03 For #4155: Restyle to custom menu 2019-09-11 09:03:17 -07:00
Sawyer Blatz 52fd327bc0 For #4155: Adds tests for browser toolbar popup menu 2019-09-11 09:03:17 -07:00
Sawyer Blatz fdd2b59fb8 For #4155: Adds popup menu for browser toolbar 2019-09-11 09:03:17 -07:00
Sebastian Kaspari ac32a88d45 Rename BrowserStore/State/Action to BrowserFragmentStore/State/Action. 2019-09-03 10:09:06 -07:00
Tiger Oakes c475bc87cf Move classes out of top-level package 2019-08-21 13:52:30 -07:00