1
0
Fork 0
Commit Graph

2055 Commits (4d139d52c40ea2655487d9405bab3334218ad00a)

Author SHA1 Message Date
Harshal Lele e318cd7d15 fix #8135 - remove getColorFromAttr 2020-03-02 15:48:33 -07:00
Sawyer Blatz 8e06933e8d For #167: Adds browser -> home animation 2020-03-02 14:45:44 -08:00
Emily Kager a61502215b Revert "For #7603 - Temporarily do not show biometric prompt for OnePlus devices"
This reverts commit 17d7928cc9.
2020-03-02 14:31:08 -08:00
Michael Comella db57e123b9 For #8797: Do not allow nested scrolling on top sites. 2020-03-02 15:24:43 -07:00
mcarare 2bb2061931 For #8766: Show collections only when tabs are open or collection exists 2020-03-02 14:27:04 -07:00
Mihai Adrian e3d34edfc7
For #8873 - Update snackbar padding for adding top sites 2020-03-02 14:28:14 -05:00
Arturo Mejia 4cf34b47ee
Show a notification when add-on update requires new permissions 2020-03-02 13:46:37 -05:00
Sawyer Blatz e96732604b For #167: Improves home to browser animation 2020-02-28 18:04:14 -07:00
Michael Comella 9ed43b60b6 For #7781: instrument visual completeness for top sites.
Eyeballing my output in *Debug builds on my P2, this adds approximately 115ms
or slightly less from first frame drawn to visually complete time.
2020-02-28 13:37:06 -08:00
Michael Comella 4605ba9124 No issue: make Performance methods private that can be. 2020-02-28 13:37:06 -08:00
ekager a6b07afa95 No issue: Fix LeakCanary detected memory leaks
Co-authored-by: Emily Kager <emilykager@gmail.com>
Co-authored-by: Pierre-Yves Ricau <py@squareup.com>
2020-02-28 13:29:16 -08:00
Sebastian Kaspari 83f94cacb5 FennecWebAppIntentProcessor: Handle manifest file not existing. 2020-02-28 13:27:53 -08:00
Sebastian Kaspari a477f14042 IntentReceiverActivity: Simplify intent handling.
This patch removes the need to process() and then match() on every intent processor.
A successful process() means that we already matched. Doing this in two steps caused
issues when the process() failed but later the simple check in match() returned true.

After this patch lands I intent to remove the match() API from the IntentProcessor
interface in AC:
https://github.com/mozilla-mobile/android-components/issues/6097
2020-02-28 13:27:53 -08:00
mcarare 5a6fc02976 For #8773: Set proper anchor and padding for Snackbars on browser screen 2020-02-28 13:23:11 -08:00
mcarare df80a5240b For #6607 Add button to no tab content pane 2020-02-28 13:21:22 -08:00
David Walsh 5b7a800f98 Make 'Redirect to Sync' home menu item go directly to the 'Reconnect to Sync' / error screen 2020-02-28 13:19:06 -08:00
David Walsh 0187669790 Match account problem styling between HomeMenu and BrowserMenu 2020-02-28 13:18:40 -08:00
Sebastian Kaspari d89fbd7af8 FenixSearchEngineProvider: Use dummy location service in debug builds.
Workaround for issue described in:
https://github.com/mozilla-mobile/android-components/issues/5989

For debug builds it is unnecessary to use the actual location provider since those builds
do not have an API key configured. With that patch we replace the location provider with
a dummy implementation in debug builds.
2020-02-28 13:17:45 -08:00
Arturo Mejia 30f351910a
Make sure all installed extensions are registered for updates 2020-02-28 15:37:08 -05:00
Will Hawkins f9b716286a For #8034: Create a post-visual completeness executor
Create an object that will execute its enqued tasks
when Fenix is visually complete.
2020-02-28 09:15:06 -08:00
Simon Chae 0def456cac
For #8116: Attach add-on snackbar to activity rootView 2020-02-27 17:47:59 -05:00
David Walsh b525f2382a
For #7504 - Update sync error display in menus (#8639) 2020-02-27 12:54:14 -08:00
ekager 63ddff533d For #8641 - Update addon text selector to use attr colors 2020-02-27 12:40:57 -08:00
Simon Chae 4854566f94
For #8824: Reset isInstallationInProgress in correct lifecycle (#8825) 2020-02-27 12:33:37 -05:00
Arturo Mejia cfa6f0cc7a No issue: Submit exceptions while updating add-ons to the crashReporter 2020-02-27 17:44:23 +01:00
Simon Chae 41a84e85a3
For #8699: Add view.settings to setAllInteractiveViewsClickable (#8820) 2020-02-27 11:30:22 -05:00
Mihai Adrian 9612c3f16d
For #8540: Fix ETP options not being correctly applied (#8688) 2020-02-26 12:25:40 -08:00
David Walsh e2b72a9c01 For #8505 - Update tab icon 2020-02-26 12:04:51 -08:00
Simon Chae f99bad949e
For #8699: Add setAllInteractiveViewsClickable for add-on pending removal (#8776) 2020-02-26 14:22:42 -05:00
mcarare 314bee2abd For #8627: Add proper content description to ETP card clickable areas 2020-02-26 08:31:51 -08:00
Grisha Kruglov 7275dd5269 Public API changes related to 0.52.0 A-S bump 2020-02-26 10:15:58 +01:00
Severin Rudie c87c837865
For #8752: fix invalid AutoplayAction crash 2020-02-26 00:37:44 -05:00
Sawyer Blatz b8d5dc4551 For #7715: Display search suggestions when pressing allow 2020-02-25 20:14:05 -08:00
Grisha Kruglov fddf77280c Remove direct A-S dependency; switch to using 'full' megazord
As far as I can tell, we never actually exercise the a-s libraries in Fenix tests currently (this was one of the presumed reasons for having a direct dependency).
In a different branch I've started work on adding end-to-end tests, but currently that's blocked on trying to figure out to load native libraries in tests (somehow, fenix's setup is different than what we have in A-C, not yet clear to me in what way).

Another reason for a direct dependency (i think) is that we needed it to configure a `fenix` megazord. This could be solved via a `support-megazord-fenix` a-c component that provides the correct transient dependencies,
but we can also just switch to use the `full` megazord instead, which is essentially what fenix megazord is at this point. A-S team wants to remove the fenix megazord, so this will help. This is what this patch does.
2020-02-25 17:30:57 -08:00
ekager 7f34204188 For #5843 - Ensure tabs pending deletion are removed 2020-02-25 16:53:52 -08:00
Sawyer Blatz 13c9c39658 For #4383: Add feature flag 2020-02-25 16:45:59 -08:00
Sawyer Blatz 009a7f3020 For #4383: Enable dynamic bottom toolbar 2020-02-25 16:45:59 -08:00
ekager f569f48b33 For #5696 - Adds basic share action to text selection context menu 2020-02-25 15:39:01 -08:00
ekager ffc2785c1e No issue: Add back updateThemeForSession in onResume 2020-02-25 15:35:16 -08:00
MarcLeclair 41f9311e20
For #7448: Move LP to IO dispatcher (#8558) 2020-02-25 17:55:43 -05:00
Sawyer Blatz 82979afb48 For #8743: Fix baseBrowserFragment crash 2020-02-25 14:43:59 -08:00
ekager 511c36e191 Removes FragmentPreDrawManager changes in BrowserFragment 2020-02-25 13:38:47 -08:00
Sawyer Blatz dcc1e9fc65 No issue: Fixes swipeRefresh UI test crash 2020-02-25 11:08:41 -08:00
mcarare cc47bc4e1e For #8655: Show top site context menu below top site title 2020-02-25 10:30:15 -08:00
Arturo Mejia 959e438ff3
Initializes GlobalAddonDependencyProvider 2020-02-25 12:31:05 -05:00
Mihai Adrian beb323924b
For #8594: Show correct info in Etp settings info (#8687) 2020-02-25 09:18:27 -08:00
Sebastian Kaspari 388c7017d8 Closes #6003: MigrationProgressActivity: Always open browser. 2020-02-25 17:44:18 +01:00
Severin Rudie 69c6de7cd4
For #8411: integrate AC permissions changes (#8618) 2020-02-25 07:36:19 -08:00
Sparky93 0f609b1888 Fix for #8533 - Migration screen's buttons in the wrong place
Made a small refactor on the migration screen layout in order to correctly position the elements.
2020-02-25 13:19:09 +01:00
Simon Chae 0434e53911 For #8637: Remove setActivityTheme outside activity lifecycle scope 2020-02-24 19:48:03 -08:00
Mihai Adrian 4be693255d
For #8565: Fix updating dropdown preferences in ETP settings! (#8573)
* For #8565: Create custom SharedPreferenceUpdater for String Preferences

* For #8565: Use custom updater to correctly update DropDownPreference

* For #8565: Set default values for dropDown preferences

* For 8565: add tests for findEntriesValue

* For 8565: clarified findEntryValue

Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
2020-02-24 18:07:02 -08:00
Sebastian Kaspari fdd3d29cd4 Implement new feature-tabs API. 2020-02-24 14:35:36 +01:00
Jeff Boek cbad832b19 For #8153 - Allow web-extensions to open tabs in correct browsing mode 2020-02-24 00:24:07 -08:00
Jeff Boek dfde37baf5 Reverts For #7559 - allows changing locale even after setting theme with 2020-02-24 00:24:07 -08:00
Jeff Boek 541bcf072a Reverts all BrowsingModeManager changes 2020-02-24 00:24:07 -08:00
ekager 0d398f7d44 For #8580 - Don't change theme in initialize UI 2020-02-22 20:03:02 -08:00
Roger Yang 60d38057bb
Closes #8654: Fix breakage from customTabId rename (#8656) 2020-02-21 13:37:46 -08:00
Jeff Boek 26d1bd70d8 Revert "For #8460: Prevent multiple back navigation clicks."
This reverts commit b030d3ac9f.
2020-02-21 09:32:02 -08:00
Sawyer Blatz d918cfdf38 For #1901: Screenshot engineView to remove GV flash
Co-authored-by: ekager <ekager@mozilla.com>
2020-02-21 08:35:42 -08:00
Roger Yang 0630e2482f
Closes #8544: Activity should be reused when opening intents from other apps (#8547) 2020-02-21 09:02:13 -05:00
Simon Chae da0148b8bd For #8535 #8498: Allow for multiple browsingModeListeners dispatch 2020-02-20 19:50:35 -08:00
Dennis Schubert be06450dd9 Bug 1613416 - Hide "Report site issue" button in Fenix Production. 2020-02-20 19:24:56 -08:00
mcarare b030d3ac9f For #8460: Prevent multiple back navigation clicks. 2020-02-20 19:14:45 -08:00
Arturo Mejia 8b7fd3a1df
For issue #8570: Disabling uBlock and quickly opening the Settings
section cause a crash
2020-02-20 20:31:26 -05:00
Sawyer Blatz f02e06afae
For #8454 - Removes back button from the search screen 2020-02-20 18:15:47 -05:00
Jeff Boek f050db517c For #8552 - Fixes bug where "installing/uninstalling" was using the old pref key 2020-02-19 15:20:52 -08:00
mcarare a5ac7304bb For #8523: Also disable radio buttons clickable area when ETP is off 2020-02-19 10:48:01 -08:00
mcarare 2d72027cbd For #8534: Register preference update on first tap 2020-02-19 10:40:17 -08:00
Mihai Branescu 9d972fa1d0 For #4231 added unit tests for most recent apps 2020-02-19 10:36:58 -08:00
Mihai Branescu fdbf63fb97 For #4231
Added kapt plugin + dependencies in order to be able to use Room
Added recent apps to share fragment (top 6)
Extracted dimens of share_to_apps.xml in the dimens file
2020-02-19 10:36:58 -08:00
Mihai Adrian 3486f30b6a
For #8529: Fix custom ETP preferences visibility update 2020-02-19 11:19:00 -05:00
Sebastian Kaspari d7e1259e7b
Use Mozilla Android Components 34.0.0-SNAPSHOT. (#8527) 2020-02-19 16:59:34 +02:00
Arturo Mejia 2daa485931
Show internal add-on version when available (#8507) 2020-02-19 09:57:04 -05:00
Jeff Boek 020608275d For #6981 - Fixes tests to support locale aware changes 2020-02-18 18:20:50 -08:00
Jeff Boek 1ba64f9559 For #6981 #6907 - Properly reloads search engines when locale changes 2020-02-18 18:20:50 -08:00
ekager 35bf4fbda9 No issue: Fix login for BaseBrowserFragment FragmentPreDrawManager 2020-02-18 17:53:47 -08:00
ekager 57a02a10fc For #8514 - Use state list colors for default disabled states 2020-02-18 17:45:36 -08:00
Jeff Boek 5c6e6ddfb7 For #4807 - Always navigate to settings after deleting data 2020-02-18 13:30:32 -08:00
ekager bb85de5dca For #6737 - Set Logins checkbox default to true 2020-02-18 11:32:50 -08:00
Mihai Adrian e8913474a0
For #8268 - Update added to top sites snackbar text (#8435) 2020-02-18 13:40:02 -05:00
ValentinTimisica 12ae46343e For #7957: Enable Login management preference for all users 2020-02-18 10:39:04 -08:00
ekager f52f87f6a4 For #8324 - Only use encrypted storage for Nightly/Debug populations 2020-02-18 10:30:20 -08:00
Jeff Boek a8746320d7 For #3869 - Uses RegionSearchLocalizationProvider in the search engine provider 2020-02-18 10:10:16 -08:00
mcarare 5fd3894171 For #8354 Fix uppdating theme when coming from external links 2020-02-18 09:34:36 -08:00
mcarare 9d755a877a For #8354 Fix opening custom tabs and links directly in private mode 2020-02-18 09:34:36 -08:00
mcarare ae13f4b44f For #8354 Remove unsetting open links in private if not default browser 2020-02-18 09:34:36 -08:00
mcarare bba563b5f9 For #6479: Add granular ETP settings 2020-02-18 09:32:43 -08:00
Emma Malysz 15ff4726a0 For #8056: remove Experiments.initialize from FenixApplication
Experiments will not be used before GA and are thus being removed
for performance wins.
2020-02-18 08:22:03 -08:00
ValentinTimisica ba8867c1a9 For #1741: Passes 'showDescription' boolean to SearchSuggestionProvider
Change required for removing description from search suggestion. Implemented
in AC (https://github.com/mozilla-mobile/android-components/pull/5890)
2020-02-18 12:31:40 +02:00
Severin Rudie cc29c5fe84
For #7896: integrate text selection search from AC (#8295) 2020-02-17 19:20:35 -08:00
Sebastian Kaspari ba54080177 Issue #8277: Reuse app icon in widget layout.
This patch refactors the widget layouts so that we can reuse the app icon and do not have to have
another logo resource with different constraints. This will also make it easier to update the
branding in #8277 and #8278.
2020-02-17 11:37:15 +01:00
ekager 324fe64213 No issue: Fix new optional adds on arg error 2020-02-15 17:21:03 -08:00
Jeff Boek 7aeb5f072d For #7295 - Adds more documentation for the installation metrics 2020-02-14 20:56:49 -08:00
codrut.topliceanu d6ae3d4abe For #7295 - Adds new custom ping: 'installation' 2020-02-14 20:56:49 -08:00
ekager b72550c28a For #8126 - Adds default top sites 2020-02-14 14:39:58 -08:00
ekager 2e1202cbd1 For #8348 - Add small delay after biometric auth 2020-02-14 12:36:38 -08:00
Sebastian Kaspari c45df6ecde Dismiss "migration notification" after leaving migration activity.
For https://github.com/mozilla-mobile/android-components/issues/5886.

With this patch we will dismiss the "migration completed" notification once the users
clicks on the button in the migration activity.
2020-02-14 12:02:58 +01:00
Sparky93 640d24974f Fix for #8426 - Migration steps displayed in a different order than UI specifications
Changed the order of the whitelisted migrations in order to respect the UI specifications.

Now using linked hash map instead of hash map for the whitelisted migrations so we can preserve the
order of the steps upon status changing in the migration process.
2020-02-14 11:48:24 +01:00
mcarare 3b5eadcc70 For #8372: Set toolbar position relative anchor for url copied snackbar 2020-02-13 20:42:05 -08:00
Severin Rudie 1be812eba0 For #8408: fix requireContext crash in HomeFragment#onViewCreated 2020-02-13 20:15:54 -08:00
Emily Kager 2264e6e1b1 For #6623 - Adds ability to delete a login 2020-02-13 16:04:26 -08:00
Mugurell ad1144c722 For #6577 - Remove the `total_uri_count` Glean StringMetricType
This was added as a duplicate to an already existing `total_uri_count`
CounterMetricType in #4456.
2020-02-13 15:54:55 -08:00
Christian Sadilek ce96d909d1 No issue: Support basic navigation in add-on popups 2020-02-13 17:26:43 -05:00
mcarare 372b1e7f0e For #6980: Update Private browsing card.
Added test to description.
Added link to settings.
Updated unit tests.
2020-02-13 14:13:57 -08:00
Jeff Boek 127169f5ff For mozilla-mobile#8172: Add a new 'E_Fennec_To_Fenix_Migrated' Leanplum event
This new event will be sent when the user has successfully migrated from Fennec
to Fenix.
This event will only be sent to Leanplum and not to the other telemetry
services like Glean or Adjust.

Co-authored-by: ValentinTimisica <valentin.timisica@softvision.ro>
2020-02-13 14:10:24 -08:00
ValentinTimisica 33616e0042 For #8172: Add a new "Fenix" Leanplum attribute 2020-02-13 14:10:24 -08:00
Emily Kager 9bac7ef47b For #8403: Don't postpone transition for view intents 2020-02-13 12:58:28 -08:00
Christian Sadilek 40031e6130 For #8143: Allow add-on popups to display prompts 2020-02-13 14:15:02 -05:00
Emily Kager 9adc617765 For #8358 - Make sure we don't cancel toolbar editing more than once 2020-02-13 10:32:31 -08:00
Emily Kager cbc8d3aa45 For #8366 - Move CreateShortcutFragment dismiss after AddToHomescreen 2020-02-12 22:54:30 -08:00
Simon Chae b5379eb513
Allow fragment to go back when all unsupported add-ons are removed (#8351) 2020-02-12 17:32:03 -05:00
Simon Chae 2c01022c4b For #8153: Allow web-ext to open new tabs in correct browsing mode 2020-02-12 13:41:16 -08:00
mcarare 5e4ef202b8 For #8262: Set toolbar position relative anchor for collection snackbars 2020-02-12 07:56:17 -08:00
Jeff Boek a701988ae9 For #5905 - Creates private browsing settings fragment 2020-02-11 18:14:14 -08:00
Jeff Boek ef6913ec25 For #5905 - Combine theme and toolbar settings 2020-02-11 18:14:14 -08:00
Jeff Boek cfb9b16863 No Issue - Fixes breaking snapshot change 2020-02-11 17:59:16 -08:00
mcarare 1168fbd638 For #8299: Select current ETP policy set on card creation 2020-02-11 17:54:09 -08:00
Arturo Mejia 95528c3191 For issues #8310 Disable the remove button while disabling an add-on
and vice versa.
2020-02-11 19:54:48 -05:00
MarcLeclair 834d7e13cd
Remove Tracking protection popup for visual testing (#8226)
* For #6903: allow override TP popup for performanceTest

* For #6903: refactored the code
2020-02-11 11:12:39 -05:00
Sparky93 1ed185d4c2 Fix for #7980 - MigrationStore's COMPLETE action now redirects to MigrationProgressActivity
In order to ensure that the user's migration screen is not being bypassed by mistake, we handle the
migration's store COMPLETED state the same way we handle the MIGRATING state.

We can do this because we can treat the initial state (NONE) as being either a fresh start of the
app, either the user's intention of starting the home activity.

Before this change, if the app was being open from the shortcut after the migration was complete,
the user would have been encountered the home activity instead of the migration one.
2020-02-11 16:41:20 +01:00
codrut.topliceanu 705567651f For #7978 - Remove ScrollView from migration activity. 2020-02-11 16:40:15 +01:00
codrut.topliceanu e193c9c084 For #7975 - Added a progress bar according to specs 2020-02-11 16:40:15 +01:00
Arturo Mejia 941c147989 mozilla-mobile/android-components#5867 Fix addonProgressOverlay IllegalStateException 2020-02-10 17:50:55 -05:00
Arturo Mejia 93a68736a3 For issue #8272: Keep the add-ons management ui in sync with add-ons
changes
2020-02-10 16:31:53 -05:00
Emily Kager 316215ca54 For #7999 - for Leanplum fxaHasSyncedItems use SyncEnginesStorage 2020-02-10 20:47:46 +01:00
David Walsh f51069cd82 For #8016 - Prevent duplicate domains from displaying inthe collection description on the home screen 2020-02-10 10:50:07 -08:00
Sawyer Blatz 453231b5fd For #7753: Increases touch target of crash page 2020-02-10 10:36:46 -08:00
Jeff Boek f9b05e7d5a
For #8212 - Fixes shadow/border when toolbar is on top (#8234) 2020-02-10 12:32:26 -06:00
Sebastian Kaspari f0af6d6f6e Update Mozilla Android Components to 32.0.0-SNAPSHOT. 2020-02-10 17:13:58 +01:00
Sparky93 c9313029a8 Fix for #5695 - Migration steps' status displayed before the migration completed
The migration steps' status was already being shown as succeeded instead of showing an "unchecked" list of
steps.
These changes will make the steps being "checked" one by one as the migration advances.
2020-02-10 14:31:42 +01:00
Jeff Boek 952c48c8ce For #4674 - Adds ability to toggle metric services by type 2020-02-10 12:33:53 +02:00
Jeff Boek 9f3faa43fe For #4674 - Adds marketing data as a collection choice 2020-02-10 12:33:53 +02:00
Emily Kager 5839f5891c No issue: Update androidx dependencies 02.08.20 2020-02-10 11:33:12 +01:00
Grisha Kruglov 7a272a4564 Enable fennec Pinned Sites migration 2020-02-10 08:19:30 +01:00
Jonathan Almeida e73b3cfbec
No issue: Simplify migration accessible string (#8249) 2020-02-08 13:19:46 -05:00
Emily Kager 17d7928cc9 For #7603 - Temporarily do not show biometric prompt for OnePlus devices 2020-02-07 20:39:36 -08:00
Emily Kager 9e4e23eceb
Closes #8176 - Adds new string for add to top sites (#8209) 2020-02-07 22:05:35 -05:00
Christian Sadilek 8a33897f3a For #8201: Enable/Disable uBlock button status isn't updated 2020-02-07 19:55:41 -05:00
mcarare 3ea5b08135 For #8190: Add animation to ETP policy selection 2020-02-07 15:50:39 -08:00
Arturo Mejia 2daf7c3142 For issue #8221: Fix crash in the AddonsManagementFragment when binding
the RecyclerView after the fragment is not attached anymore
2020-02-07 18:38:37 -05:00
Christian Sadilek 142104dc86 For #8202: Remove settings if add-on disabled
- Also fixes the crash described in #8202.
2020-02-07 16:42:54 -05:00
Gabriel Luong e3df9f0902
For #8167: Don't show the add-ons permission dialog if installation is in progress (#8230) 2020-02-07 16:06:28 -05:00
Michael Comella a896b47cfe For #7820: warm BrowsersCache on background thread.
In an early iteration of his patch on a beta build, I saw no improvement over
6 runs (Pixel 2):
- Before: 401.5ms
- After: 402.17ms

This may be attributed to noise in startup performance. However,
BrowsersCache disappears from profiles completely and results in
theoretical performance gains.

When using the StartupTimeline class (not landed yet), I see a 27.75ms
runtime improvement on beta builds after this patch.
2020-02-07 09:13:29 -08:00
Jeff Boek a42ad7603b For #5073 - Fixes visual alignment when certificate authority breaks into a new line 2020-02-07 09:10:31 -08:00
Jeff Boek 7a16192fd1 For #5073 - Use string parameter versus concatenating programatically 2020-02-07 09:10:31 -08:00
Kate Glazko 7c00a1ad6b For #5073: View Site Cert 2020-02-07 09:10:31 -08:00
mcarare 5bd5f81559 For #6980: Add onboarding Toolbar position picker card 2020-02-07 09:05:03 -08:00
Sawyer Blatz 0a6881d470
For #255: Removes autoplay media feature flag (#8198) 2020-02-07 10:22:37 -05:00
ValentinTimisica 29522d29ed For #1500: Passes resources to SessionSuggestionProvider
Change required for adding 'Switch to tab' description for a suggestion that
represents an opened tab. Implemented in AC
(https://github.com/mozilla-mobile/android-components/pull/5773)
2020-02-07 11:26:58 +01:00
Jeff Boek 62d540257f For #7965 - removed unused strings, reverted changes to radiobutton widget 2020-02-06 18:48:23 -08:00