2c01022c4b
For #8153 : Allow web-ext to open new tabs in correct browsing mode
2020-02-12 13:41:16 -08:00
c7c4ad051a
For #6413 : Adds more snackbar positioning logic ( #7444 )
...
* For #6413 : Adds more snackbar positioning logic
* Refactor
2020-01-02 14:31:52 -08:00
3fb060f682
For #6413 : Fixes snackbar positionining for bottom toolbar ( #7415 )
...
* For #6413 : Fixes snackbar positionining for bottom toolbar
* For #6413 : Cleans up snackbar usage
2019-12-30 14:43:15 -08:00
6344a8892d
For #7041 - Respect current mode when opening library items ( #7311 )
...
* Fixes #7041
Consumes `browserMode` from home activity for tap method of bookmark
* Fixes spaces
* Cleaning tests
* Cleaning tests
2019-12-23 12:26:47 -05:00
ea486d7c66
Split out CustomTabToolbarIntegration ( #7107 )
2019-12-17 12:26:46 -08:00
b9656a978e
Hide add folder option when in Desktop Bookmarks folder
2019-12-13 17:51:15 -08:00
8e17ac05b1
Optimized imports. Closes #5876
2019-10-10 04:17:43 +05:30
f907ec52f0
Removed ObsoleteCoroutinesApi in tests. Closes #5876
2019-10-10 04:04:51 +05:30
ee1f040e53
No issue: Move signedIn tracking to BookmarksSharedViewModel ( #4755 )
2019-09-27 08:57:38 -07:00
dffa61bf16
Closes #4513 : fixes bookmark tests broken by loading change
...
Note that BookmarkFragmentStoreTest changes preserve existing behavior, which in many cases is more expansive than the test name implies
2019-09-26 16:29:14 -07:00
fd7f1b2665
Closes #4513 : adds tests for bookmark loading state
2019-09-26 16:29:14 -07:00
de93b05cac
For #2754 Add tab cards to share sheet ( #5493 )
...
* For #2754 Add tab cards to share sheet
* For #2754 : Fix background near rounded corners and ShareButtonAppearanceTest
* Add license to share_tab_item
2019-09-26 14:25:34 -07:00
e3c60faf24
Move BookmarkNode extensions to helper class ( #4752 )
2019-09-24 09:17:29 -07:00
d0ef2d40c2
Move bookmark navigation listener to separate file
2019-09-10 16:53:09 -07:00
76063e307a
Rename BookmarkStore/State/Action to BookmarkFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
c475bc87cf
Move classes out of top-level package
2019-08-21 13:52:30 -07:00
c1b1c2f332
For #3967 - Invokes pending deletion with more bookmark actions ( #4522 )
2019-08-21 08:36:41 -07:00
645674c9bd
Closes #4396 - Add a Bookmarks Controller ( #4593 )
...
* For #4396 - Rename BookmarkInteractor methods
Following the naming model used in other Interactors this too will use reactive
method names in the form of "on..." instead of the previous imperative model.
Kept the imperative naming model for the methods from `SelectionInteractor` as
they are a new addition and I'm not sure about the future direction.
* For #4396 - Add a BookmarkController
It abstracts the Fragment behavior in a contract through which various
Interactors can inform about the specific View changes and can ask for
modifications in their container Fragment.
This contract and it's implementation - `DefaultBookmarkController` are the
result of extracting the container Fragment's business logic from
`BookmarkFragmentInteractor` in it's own standalone component.
* For #4396 - Refactored Bookmark related tests
Added a new `BookmarkControllerTest` tests class which complements the new
`BookmarkController` to ensure that it properly operates on `BookmarkFragment`
Also refactored the existing `BookmarkFragmentInteractorTest` to accommodate
`BookmarkFragmentInteractor`'s now more specialized behavior.
2019-08-19 08:34:57 -07:00
634ee184a6
No issue: add some BookmarkFragmentInteractor tests
2019-08-09 17:27:58 -07:00
da06b0fb15
For #4508 : Treats warnings as errors ( #4543 )
2019-08-07 14:00:53 -07:00
3c1ce90f6f
Fixes #2379 - Generic library selection
2019-08-06 11:10:50 -07:00
33e881ca8a
For #1539 : Only allow delete when folders multi-selected ( #4062 )
2019-08-02 10:11:21 -07:00
3dc20543e3
For #4128 : Migrate Bookmarks to LibState ( #4254 )
2019-07-25 21:55:51 -05:00
ef8d9604ae
No issue: Normalize license header comment ( #3909 )
2019-07-12 11:38:15 -07:00
15d887e41f
For #2251 - Add bookmark adapter diffutil ( #3936 )
...
* For #2251 - Add bookmark adapter diffutil
* For #2251 - Fix unit tests for bookmark adapter diffutil
2019-07-08 14:00:25 -05:00
f1088222b4
For #3203 : Updates edit bookmarks to have user friendly names ( #3372 )
...
Co-authored-by: Colin Lee <mncolinlee@gmail.com>
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>"
2019-06-12 14:10:43 -05:00
c5e5ef4b25
Teases apart ViewModel dependencies ( #2499 )
...
* No Issue - pulls render outside of the viewmodel
* No Issue - Properly subscribes to the changesObservable
* No Issue - Fixes ViewModel tests
2019-05-14 23:16:48 -07:00
ccbc14a71f
For #1994 : Re-architect state handling code ( #2382 )
2019-05-09 23:06:12 +00:00
78f8354fbb
Fix build breakage over FragmentScenario integration
2019-05-08 10:27:24 -05:00
96b68948b5
For #1710 : Create scaffolding for Robolectric tests ( #2282 )
2019-05-07 16:36:37 -05:00
a60d2c071c
For #1967 : Multi-selection toolbar should disappear after deleting ( #2202 )
2019-05-01 13:51:37 -05:00
bc1b7e0b43
For #1539 : Add bookmark multi-select features
2019-04-12 13:35:28 -05:00
b54d4d1d58
Closes #1312 , #1236 , #1237 , #1238 , #1239 : Creating, Editing, and Deleting Bookmarks and Bookmark Folders
2019-04-08 14:48:36 -05:00
bd81e72239
Fixes #916 , fixes #917 , fixes #920 : Save, share, and delete bookmarks
2019-04-01 16:16:08 -05:00
Simon Chae