1
0
Fork 0
Commit Graph

22 Commits (2953b54a843615362a8aab1d1da96f6d24baa5f1)

Author SHA1 Message Date
Sawyer Blatz 473b528ea1
No issue: Improves scrolling of quick action sheet (#2079) 2019-04-26 11:35:57 -07:00
Emily Kager 99f979e86b For #1601 - Bookmark icon should change visually if page is bookmarked 2019-04-25 17:29:27 -07:00
Sawyer Blatz 9e9b6f98f9 Fixes #2030: Quick action sheet collapses on scroll 2019-04-25 13:01:31 -07:00
Emily Kager 911ef446ab No issue: Fixed visibility bugs in quick action sheet (#1927) 2019-04-23 11:46:52 -07:00
Emily Kager 72410b18bd Closes #1912 - Quick action bottom sheet should fade in 2019-04-22 23:25:15 -07:00
Emily Kager dad4149b81 For #1542 - Add ripple to quick action buttons 2019-04-10 19:12:05 -07:00
Sawyer Blatz 5fc1e9227f
Closes #1195: Adds telemetry for quick action sheet (#1362) 2019-04-05 15:08:55 -07:00
Colin Lee bd81e72239 Fixes #916, fixes #917, fixes #920: Save, share, and delete bookmarks 2019-04-01 16:16:08 -05:00
Eitan Isaacson 4f67b7a26c Fixes #1186: Make quick actions invisible to screen reader when collapsed.
The buttons in the quick actions sheet are not visible or interactive
when the sheet is collapsed. They should not be visible to AT users
either.
2019-03-29 12:47:19 -07:00
Eitan Isaacson f9ea856b34 Fixes #1186: Add AccessibilityActions to quick action sheet's handle
Adding the 'click' action allows the user to activate the button with a
default action (double tap in TalkBack). This is instead of
conditionally setting up a click listener if TalkBack is enabled. This
is a more generalized solution that accomodates other ATs besides
TalkBack.

Adding an expand or collapse action also tells TalkBack what the current
state of the sheet is, and reports it to the user. So they will
initially hear "collapsed, quick actions, button". When they double tap,
they will hear "expanded". Adding those actions also allows TalkBack and
other AT users to explicitly call those actions on that element with a
menu or a gesture binding.
2019-03-29 12:47:19 -07:00
Eitan Isaacson c807f84b98 Fixes #1186: Made quick actions sheet's handle larger.
It now takes up the entire horizontal space and all the vertical space
until the buttons. This gives a bigger touch target both for typical
users and TalkBack users when they use explore-by-touch.

Also changed content description. The content description should not
include semantic names like "handle". The screen reader already knows
it's a button and describes it as such. Same thing with "sheet".
2019-03-29 12:47:19 -07:00
Sawyer Blatz 0f1e65bdab Closes #1127: Improves accessibility of quick action sheet 2019-03-21 14:07:17 -05:00
Sawyer Blatz da35581c54 For #1072: Fixes nits 2019-03-21 12:54:08 -05:00
Sawyer Blatz 0a449dc12c For #1072: Adds onAttachedToWindow 2019-03-21 12:54:08 -05:00
Sawyer Blatz 6dcc026e04 For #1072: Adds accessibility support 2019-03-21 12:54:08 -05:00
Sawyer Blatz 486bfc2d68 For #1072: Adds cap to auto bounce 2019-03-21 12:54:08 -05:00
Sawyer Blatz 7accf07d48 For #1072: Fixes lint errors 2019-03-21 12:54:08 -05:00
Sawyer Blatz c0ceeb8cb6 For #1072: Increases touch target of grabber handle 2019-03-21 12:54:08 -05:00
Sawyer Blatz 504fc41e51 For #1072: Modifies icons 2019-03-21 12:54:08 -05:00
Sawyer Blatz d2af87f8f8 For #1072: Adds grabber handle bounce animation 2019-03-21 12:54:08 -05:00
Sawyer Blatz 4acd939289 For #1072: Adds grabber handle 2019-03-21 12:54:08 -05:00
Sawyer Blatz 994d88542e For #1072: Adds basic view 2019-03-21 12:54:08 -05:00