29539c458e
For #9770 - Disable pull to refresh pending changes
2020-04-07 17:06:43 +03:00
a12cb5b0c3
Import l10n.
2020-04-07 10:30:26 +03:00
376740cd2c
For #9631 : replace assertk assertions with junit.
...
I created a series of editor macros to do this with minimal errors (and
to do it quickly!).
2020-04-06 16:56:40 -07:00
c632b93ee7
For #220 - Removes feature flag for language picker ( #9191 )
...
* For #220 - Removes feature flag for language picker
* For #220 - Updates Android Components
2020-04-06 14:29:52 -07:00
dfded8e69c
For #9687 : Refactor onboarding cards to follow app architecture ( #9743 )
...
* For #9687 : Refactor onboarding cards to follow app architecture
* For #9687 : Update unit test to new controller parameters
2020-04-06 11:00:47 -07:00
025656d8fd
For issue #9647 Crash when tapping settings after quickly
...
enabling/disabling add-on
2020-04-06 13:47:21 -04:00
3789f50423
Fix errors in top_sites_count metric
...
We discovered in the Fenix metrics errors query [1] that
top_sites_count had a spike in the number of errors. It
seems to be recording a count of 0, which is an invalid value.
[1] https://sql.telemetry.mozilla.org/queries/67107/source#169983
2020-04-06 10:34:52 -07:00
2d55b07935
Import l10n.
2020-04-06 12:20:41 +03:00
cac8115e55
For #9663 : Allow more than one line for onboarding card header
2020-04-03 17:47:11 -07:00
9e470c93ca
Import l10n.
2020-04-03 17:38:26 -07:00
b35704beed
Closes #9688 : Disable ReaderViewTest for intermittent investigation in detection issues
2020-04-03 22:04:43 +03:00
b2da0bd922
For #9670 : Disabled intermittent tabMediaControlButton test ( #9679 )
...
and removed file created by mistake -e
added reason for disabled tests
2020-04-03 20:39:33 +03:00
904bfc9ebe
For #3262 - Enable pull down to refresh in Nightly
2020-04-03 19:40:08 +03:00
51a76651d6
For #9605 - review: clarify comments in new test runner.
2020-04-03 09:27:49 -07:00
efef8eaba0
For #9605 : TestApplication -> FenixRobolectricTestApplication.
...
This disambiguates it from the FirefoxTestApplication used in on-device
tests.
2020-04-03 09:27:49 -07:00
8df49473c0
For #9605 : move TestApplication to the helpers package.
...
The helpers/ package is created to separate the test support code from
the code under test.
2020-04-03 09:27:49 -07:00
6e0d851da3
For #9605 : replace unit test runners with FenixRobolectricTestRunner.
...
This is how we can apply the new test runner to remove duplication.
This commit was generated programmatically with the following commands:
```
// Replace test runners with new one.
find app/src/test -type f -exec gsed -i "s/@RunWith(RobolectricTestRunner::class)/@RunWith(FenixRobolectricTestRunner::class)/" {} +
find app/src/test -type f -exec gsed -i "s/@RunWith(AndroidJUnit4::class)/@RunWith(FenixRobolectricTestRunner::class)/" {} +
// Replace imports of old test runners with new one
find app/src/test -type f -exec gsed -i "s/org.robolectric.RobolectricTestRunner/org.mozilla.fenix.helpers.FenixRobolectricTestRunner/" {} +
find app/src/test -type f -exec gsed -i "s/androidx.test.ext.junit.runners.AndroidJUnit4/org.mozilla.fenix.helpers.FenixRobolectricTestRunner/" {} +
// Remove unused imports
find app/src/test -type f -exec gsed -i "/@Config(application = TestApplication::class)/d" {} +
find app/src/test -type f -exec gsed -i "/import org.mozilla.fenix.TestApplication/d" {} +
find app/src/test -type f -exec gsed -i "/import org.robolectric.annotation.Config/d" {} +
```
Where gsed is the GNU version of sed installed via homebrew. After
running these commands, I need to manually clean up the following files:
- FenixRobolectricTestRunner
- LocaleManagerExtensionTest
2020-04-03 09:27:49 -07:00
b0cfa3ee5c
For #9605 : add FenixRobolectricTestRunner.
...
This class will help us reduce duplication by specifying the
configuration within the test runner rather than each test needing to
specify it itself.
This class is adapted from Firefox for Fire TV:
https://github.com/mozilla-mobile/firefox-tv/blob/master/app/src/test/java/org/mozilla/tv/firefox/helpers/FirefoxRobolectricTestRunner.kt
2020-04-03 09:27:49 -07:00
392dda5eda
For #9605 : remove unnecessary @RunWith(Robolectric in unit tests.
...
robolectric increases the run time of tests so it's important to remove
them when they're unnecessary.
Between this change and the last one, the unit test runtime was reduced
by ~10s.
2020-04-03 09:27:49 -07:00
f2acef66b5
For #9605 : remove unnecessary @RunWith(AndroidJUnit4) in unit tests.
...
In unit tests, this annotation annotations defer to robolectric, non-trivially
increasing test runtime so it's important to remove them when they're
unnecessary.
2020-04-03 09:27:49 -07:00
cb009f915c
No issue: re-enable libraryMenuItemsTest and backButtonTest ( #9639 )
2020-04-03 10:37:03 -04:00
f46cfc2ad2
Update Android Components version to 38.0.20200403130109.
2020-04-03 16:15:31 +02:00
8413b8133d
Import l10n.
2020-04-03 16:19:33 +03:00
4a8dc5b54f
No issue: add kdoc to HomeActivity.
...
We could consider renaming the Activity to make it clearer that it's the
main activity and doesn't just feature the homescreen but I'm concerned
that renaming it will break too many things (e.g. automation that starts
a specific activity). For quick fix, I added this comment.
2020-04-02 16:27:00 -07:00
e3ed7ed268
Issue #9128 & #9222 & #9499 : Refactors snackbar creation and fixes placement ( #9628 )
2020-04-02 12:30:13 -07:00
8c43935ba3
For #7978 - Put views above button in scrollView ( #8819 )
2020-04-02 10:13:32 -07:00
dc6d479da3
For #6174 - Add telemetry for WebExtensions ( #8318 )
2020-04-02 10:12:31 -07:00
7043f9ee4e
For #9604 : Swap and adjust margin with padding to avoid text being cut ( #9617 )
2020-04-02 09:40:29 -07:00
c15a005ca8
No issue: remove unused FirefoxTestRunner.
...
It would be used for on device tests but it doesn't seem to hooked up
currently.
2020-04-02 07:57:09 -07:00
202172cd04
Import l10n.
2020-04-02 13:42:58 +03:00
fac61fbb41
For #9422 : Nit: Fix xml indenting
2020-04-02 09:11:31 +03:00
4d0b37a3b8
For #9422 : Align widget text to viewStart to support RTL layouts
2020-04-02 09:11:31 +03:00
327009efc4
For #768 : Add first time PWA dialog ( #9308 )
...
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
2020-04-01 22:56:12 -04:00
26137f63a2
Prevent favicons from flashing when items are selected in History ( #9233 )
2020-04-01 15:43:21 -07:00
8cd6d7460c
For #9336 Check current destination before navigating ( #9353 )
...
* For #9336 Check current destination before navigating
* For #9336 Update unit test to check for navigateSafe
2020-04-01 15:36:56 -07:00
90787cf630
For #9423 : Align preference title and summary to viewStart ( #9426 )
...
* For #9423 : Align preference title and summary to viewStart
* Update checkbox_left_preference_etp.xml
Co-authored-by: Jeff Boek <jeff@jeffboek.com>
2020-04-01 15:36:01 -07:00
fd60270da8
For #9533 - Switch to using enum for Library Item Selected Telemetry
2020-04-01 15:29:08 -07:00
8d3d030feb
Closes #9553 : Only update account UI state once when creating SettingsFragment
2020-04-01 15:28:39 -07:00
96c6401457
For #8125 - Send top sites count with metrics ping
2020-04-01 15:27:39 -07:00
8c398c86ef
For #9365 : Partially reverse menu items order when using top toolbar
2020-04-01 15:21:22 -07:00
b119700820
For #9365 : Update naming to reflect history item
2020-04-01 15:21:22 -07:00
cca3dae290
NoIssueFixMetropolisAccountPref
2020-04-01 15:13:03 -07:00
208a58bc58
Issue #9598 & #8697 : Fixes force expand crash ( #9599 )
2020-04-01 12:32:00 -07:00
3d1d146c94
For #9549 - Scrolling to top sites now includes header.
2020-04-01 10:28:04 -07:00
a2ea53d8f2
For #9574 : Remove category layout from LeakCanary SwitchPreference
2020-04-01 10:17:21 -07:00
4159cd3da7
Closes #9564 : Fixes cut off strings in ETP panel
2020-04-01 10:16:51 -07:00
24596fd3cd
For #9109 - remove the sync error highlight from three-dot menu
2020-04-01 10:42:00 +03:00
d9d5de98c9
For 3687 Use Metropolis Font for Header
2020-03-31 19:31:15 -07:00
9043120dd7
Import l10n.
2020-03-31 17:52:51 -07:00
54b7fd8834
Make sure reconnect item is displayed in HomeMenu in case of account problems
...
AccountObserver listeners were being triggered correctly, however, during every time
we open HomeFragment, home menu gets re-created, which causes us to re-run the initialization
block. Before this patch, the init block would never touch the account manager.
After this patch, it will query it if account manager has already been initialized.
2020-03-31 16:07:35 -07:00
Mugurell