1
0
Fork 0
Commit Graph

133 Commits (284cbab9eae90052e31a240109c906dcb193f97b)

Author SHA1 Message Date
Tiger Oakes 284cbab9ea Use .orEmpty() 2019-09-17 11:09:21 -07:00
Mihai Adrian c8bc144114 For #2570: Hide 3-dots menu when in select mode for bookmarks and history (#5173)
Show or hide overflow menu for entire list is triggered when mode is changed
For bookmarks, due to implementation of selection and diffUtil,
additional check is necessary for current item (last selected) that is redrawn
2019-09-12 13:56:39 -07:00
Tiger Oakes 4acf48e817 Fixes #5212 - Change tint in onCreateOptionsMenu
Also fixes #5213
2019-09-12 10:30:49 -07:00
Tiger Oakes d0ef2d40c2 Move bookmark navigation listener to separate file 2019-09-10 16:53:09 -07:00
Sawyer Blatz cd533854e6
No issue: Only use iconTint in XML for bookmark menus (#5145) 2019-09-10 09:04:05 -07:00
Grisha Kruglov 231924f5eb Fix breaking services APIs changes 2019-09-05 13:38:15 +02:00
Sebastian Kaspari ba05d21657 Fix ktlint MaxLineLength issues. 2019-09-03 10:09:06 -07:00
Sebastian Kaspari 38d97fda8b Stores: Reduce visibility of reducer functions. 2019-09-03 10:09:06 -07:00
Sebastian Kaspari 76063e307a Rename BookmarkStore/State/Action to BookmarkFragmentStore/State/Action. 2019-09-03 10:09:06 -07:00
Colin Lee 709588572a
For #5055: Crash when opening bookmarks (#5058) 2019-08-31 17:41:50 -05:00
Suraj Shah 66a8c04967 Fixes #4488: Shows snackbar on bookmark deletion from edit fragment (#4792)
* Fixes #4488
Updates changelog

* Removes wildcard imports.

* Removes custom label in use, replaces with let
2019-08-28 10:12:39 -07:00
ekager ffbbe119f3 For #3967 - Invoke pending deletion on back pressed 2019-08-23 15:32:27 -04:00
Tiger Oakes c475bc87cf Move classes out of top-level package 2019-08-21 13:52:30 -07:00
Emily Kager c1b1c2f332 For #3967 - Invokes pending deletion with more bookmark actions (#4522) 2019-08-21 08:36:41 -07:00
Mugurell 645674c9bd Closes #4396 - Add a Bookmarks Controller (#4593)
* For #4396 - Rename BookmarkInteractor methods

Following the naming model used in other Interactors this too will use reactive
method names in the form of "on..." instead of the previous imperative model.

Kept the imperative naming model for the methods from `SelectionInteractor` as
they are a new addition and I'm not sure about the future direction.

* For #4396 - Add a BookmarkController

It abstracts the Fragment behavior in a contract through which various
Interactors can inform about the specific View changes and can ask for
modifications in their container Fragment.

This contract and it's implementation - `DefaultBookmarkController` are the
result of extracting the container Fragment's business logic from
`BookmarkFragmentInteractor` in it's own standalone component.

* For #4396 - Refactored Bookmark related tests

Added a new `BookmarkControllerTest` tests class which complements the new
`BookmarkController` to ensure that it properly operates on `BookmarkFragment`

Also refactored the existing `BookmarkFragmentInteractorTest` to accommodate
`BookmarkFragmentInteractor`'s now more specialized behavior.
2019-08-19 08:34:57 -07:00
Grisha Kruglov b38b94ed79 Closes #4671: Fix a potential NPE in BookmarkFragment 2019-08-12 11:16:28 -04:00
Grisha Kruglov 634ee184a6 No issue: add some BookmarkFragmentInteractor tests 2019-08-09 17:27:58 -07:00
Grisha Kruglov f323105163 No issue: reduce code duplication in BookmarkFragmentInteractor 2019-08-09 17:27:58 -07:00
Tiger Oakes 52542708aa Consodilate private browsing code 2019-08-09 11:00:41 -07:00
Sawyer Blatz da06b0fb15
For #4508: Treats warnings as errors (#4543) 2019-08-07 14:00:53 -07:00
Emily Kager 8194e0778e For #4026 - Update BookmarkDiffUtil to update on Title or URL change 2019-08-07 00:37:16 -04:00
Tiger Oakes 3c1ce90f6f Fixes #2379 - Generic library selection 2019-08-06 11:10:50 -07:00
Emily Kager 6f7ae227a8 Closes #4540 - Set correct tint for select bookmark folder icon (#4541) 2019-08-05 14:54:39 -07:00
Sören Hentzschel bfd4849064 For #1427 - enter multi select mode with single click on favicon in library 2019-08-03 16:43:51 -07:00
Nikit Bhandari 671727c3e8 For #4341 use camelCase for views referenced from code 2019-08-03 09:25:55 -07:00
Tiger Oakes 6e2ea0750e Issue #2379 - Use LibrarySiteItemView in history 2019-08-02 17:15:41 -07:00
mihai-adrian bac2e40eb2 fixes #4435 - changed title of menuitem for delete and added content description
setting menu title should also set content description. I added the setContentDescription programmatically in order to ensure that the content description is being set. If content description matches title it won't be read twice
2019-08-02 17:09:24 -07:00
Jonathan Almeida ec96d134ff No issue: Fix breaking AccountObserver API 2019-08-02 13:40:50 -04:00
Colin Lee 33e881ca8a For #1539: Only allow delete when folders multi-selected (#4062) 2019-08-02 10:11:21 -07:00
Tiger Oakes c342a680d8 Fix crash for bookmarks 2019-08-01 18:57:35 -04:00
Emily Kager d42e72fd8b Closes #4462 - Adjust layout params of select bookmark folder view 2019-08-01 13:31:13 -07:00
Tiger Oakes ccae66c08a Issue #2379 - Use LibraryPageView in history 2019-08-01 15:59:55 -04:00
Tiger Oakes 2467588c4a Create shared custom view for library items 2019-07-30 12:26:15 -04:00
Tiger Oakes 88c05a5f43 Use glide-like image loading function 2019-07-29 10:22:23 -07:00
Tiger Oakes c2e6e25bef Fixes #4005 - Move getColorFromAttr to Context 2019-07-26 16:44:11 -04:00
Christian Sadilek 1846a61475 For #4096: Use new A-C API to observe store / state changes
With this we can remove the `whenStarted` workaround. This new API
internally creates (and uses) a scope bound to the fragment's view and
will not invoked the lambda (send state updates) when the view is
detached or the fragment's lifecylce is stopped or destroyed.
2019-07-26 10:40:33 -04:00
Colin Lee 3dc20543e3
For #4128: Migrate Bookmarks to LibState (#4254) 2019-07-25 21:55:51 -05:00
ValentinTimisica 4747f2c165 Fixes #4161: Modified style of bookmark_folders_sign_in button. (#4291)
To make this match the style of the other button I applied the same style to it
and also changed it to be a MaterialButton.
I also decided to extract the margin and padding values of the button.
2019-07-25 14:10:11 -05:00
Emily Kager 8381025ac5 For #2160 - Hide Keyboard in onPause from EditBookmarkFragment 2019-07-17 09:20:28 -07:00
Emily Kager 6b4c160d18 Closes #4080 - Trim New Bookmark Folder Title Text 2019-07-16 11:02:36 -07:00
Tiger Oakes 52d4c43916 Merge some library UIView code for toolbar 2019-07-16 09:27:30 -07:00
Tiger Oakes ef8d9604ae No issue: Normalize license header comment (#3909) 2019-07-12 11:38:15 -07:00
Grisha Kruglov fe51bbcf7b Update FxA integration to new APIs 2019-07-11 13:19:37 +02:00
Emily Kager 9e7282cf18 For #1949 - Fixes bookmark separator appearance, removes menu (#3957) 2019-07-10 14:23:35 -05:00
Emily Kager 21c75ca1bb For #3478 - Add Tab sent snackbar confirmation for device sharing 2019-07-10 14:13:10 -04:00
Tiger Oakes 9901514766 Replace deprecated pxToDp (#3932) 2019-07-08 14:45:07 -05:00
Colin Lee 15d887e41f
For #2251 - Add bookmark adapter diffutil (#3936)
* For #2251 - Add bookmark adapter diffutil

* For #2251 - Fix unit tests for bookmark adapter diffutil
2019-07-08 14:00:25 -05:00
Colin Lee 6bb67a9de7
For #3364: Set bookmark root titles onResume (#3828) 2019-07-03 13:13:53 -05:00
Sawyer Blatz dbe29ebbda
For #3174: Adds telemetry for bookmarks (#3724) 2019-07-02 08:41:20 -07:00
Colin Lee 50052c9b9b
For #3551: Tapping a bookmark/history from Library should open new tab (#3832) 2019-07-01 16:31:30 -05:00