1
0
Fork 0
Commit Graph

10 Commits (1ad9da09b0df0e91da52816c4268a6dcdde626fd)

Author SHA1 Message Date
Kainalu Hagiwara 1ad9da09b0 Remove selection holder from bookmark viewholder constructors.
Now that we're passing the mode to the viewholders in their bind
methods, there's no real need to pass them into their constructors. This
also allows us to remove the indirection of having the adapter implement
the SelectionHolder interface and have the mode implement it directly.
2020-08-14 13:03:08 -07:00
Kainalu Hagiwara b1db1cf976 Add tests for Bookmarks DiffUtil and ViewHolders. 2020-08-14 13:03:08 -07:00
Kainalu Hagiwara 6d8cfe1a50 For #13156, #13280 - Use payloads to bind bookmark viewholders.
Change the DiffUtil callback for bookmarks to use the generated equals()
method instead of only checking the title and url fields. This prevents
the BookmarkNode in our state from getting out of sync with the
BookmarkNode the viewholder is bound to.
2020-08-14 13:03:08 -07:00
ankur dd5bb94f8c For #13301, #13038: hide overflow menu for all bookmark items in selected mode 2020-08-06 09:51:56 -07:00
Kainalu Hagiwara cd2532349d For #12551 - Implement swipe to delete for bookmarks. 2020-07-20 14:54:20 -07:00
Mihai Adrian 167c6dca93 For #2570: Hide 3-dots menu for all library items when in select mode (#5699)
Removed items from RecyclerView cache to allow setting the new visibility
Disabled hidden buttons, otherwise they could still be clicked
2019-10-10 23:02:22 -07:00
Mihai Adrian c8bc144114 For #2570: Hide 3-dots menu when in select mode for bookmarks and history (#5173)
Show or hide overflow menu for entire list is triggered when mode is changed
For bookmarks, due to implementation of selection and diffUtil,
additional check is necessary for current item (last selected) that is redrawn
2019-09-12 13:56:39 -07:00
Tiger Oakes 3c1ce90f6f Fixes #2379 - Generic library selection 2019-08-06 11:10:50 -07:00
Sören Hentzschel bfd4849064 For #1427 - enter multi select mode with single click on favicon in library 2019-08-03 16:43:51 -07:00
Tiger Oakes 6e2ea0750e Issue #2379 - Use LibrarySiteItemView in history 2019-08-02 17:15:41 -07:00