1ab5fe3eb9
Add method to test fragments in roboletric ( #12261 )
2020-07-06 13:04:43 -07:00
ee62297b4c
For #7854 - Update the views only if the bookmark node has changed
...
As the bookmark node data is loaded from storage every time the fragment's view is created, when the user navigates to the SelectFolderFragment and returns, the bookmark is loaded once again from storage, replacing the EditText's content (title and URL) which causes the loss of user input.
Validating that the loaded bookmark is different from the one that is already referenced in the fragment avoids unnecessarily replacing the `EditText`s values.
2020-05-18 13:05:12 -07:00
02bd0cc203
For issue #8648
2020-04-29 09:48:42 -07:00
c4e83367f6
For #6832 - Fix various fragment not attached to a context crashes
2020-04-22 20:56:35 -07:00
b8fba63be4
For #9890 - Do not display full screen snackbar with toolbar padding
2020-04-13 14:56:51 -07:00
e3ed7ed268
Issue #9128 & #9222 & #9499 : Refactors snackbar creation and fixes placement ( #9628 )
2020-04-02 12:30:13 -07:00
e318cd7d15
fix #8135 - remove getColorFromAttr
2020-03-02 15:48:33 -07:00
c0d7bc5bd5
Use navArgs helper in fragments
2020-02-05 16:37:45 -08:00
5e9b753acb
For #7473 , delay inflation of toolbar
...
Improve performance of HomeActivity.onCreate by delaying this inflation.
We use a ViewStub and inflate the first time the actionbar is accessed.
2020-01-24 15:21:42 -08:00
e291c6905c
For #3813 - Create a save button for bookmark editing
2020-01-21 16:03:33 -08:00
9cbc3f7a4a
7410 remove rxjava ( #7426 )
...
* For #7410 : rewrite updateBookmarkFromObservableInput with coroutines
* For 7410: remove RxJava from project. :(
* For 7410: converted updateBookmarkFromTextChanges to Flow per review
2020-01-03 14:37:12 -08:00
c7c4ad051a
For #6413 : Adds more snackbar positioning logic ( #7444 )
...
* For #6413 : Adds more snackbar positioning logic
* Refactor
2020-01-02 14:31:52 -08:00
3fb060f682
For #6413 : Fixes snackbar positionining for bottom toolbar ( #7415 )
...
* For #6413 : Fixes snackbar positionining for bottom toolbar
* For #6413 : Cleans up snackbar usage
2019-12-30 14:43:15 -08:00
8d68317388
4844 fix url elision ( #6588 )
...
* For #4844 : add test cases for url elision
* For 4844: implement toShortUrl to pass test cases
* For 4844: update plumbing to use toShortUrl
* For 4844: adds/handles suggested url elision test case
2019-11-15 14:25:50 -08:00
432d5fbff4
For #5848 Wrong toolbar colour - edit bookmark fragment ( #6047 )
...
- Moved toolbar coloring to extension method
- Refactored classes using it
- Removed selection mode colouring for EditBookmarkFragment toolbar,
making it only black and white (normal mode)
2019-10-25 21:41:48 -07:00
4e3a3665d6
For #3366 - Use one layout for edit/add bookmark ( #5900 )
2019-10-21 10:06:08 -07:00
d5c3433041
Use the new fragment constructor
2019-10-07 11:07:48 -07:00
d028c97112
For #5213 - Use support library attributes
2019-10-06 16:17:00 -07:00
ee1f040e53
No issue: Move signedIn tracking to BookmarksSharedViewModel ( #4755 )
2019-09-27 08:57:38 -07:00
e3c60faf24
Move BookmarkNode extensions to helper class ( #4752 )
2019-09-24 09:17:29 -07:00
4acf48e817
Fixes #5212 - Change tint in onCreateOptionsMenu
...
Also fixes #5213
2019-09-12 10:30:49 -07:00
cd533854e6
No issue: Only use iconTint in XML for bookmark menus ( #5145 )
2019-09-10 09:04:05 -07:00
709588572a
For #5055 : Crash when opening bookmarks ( #5058 )
2019-08-31 17:41:50 -05:00
66a8c04967
Fixes #4488 : Shows snackbar on bookmark deletion from edit fragment ( #4792 )
...
* Fixes #4488
Updates changelog
* Removes wildcard imports.
* Removes custom label in use, replaces with let
2019-08-28 10:12:39 -07:00
671727c3e8
For #4341 use camelCase for views referenced from code
2019-08-03 09:25:55 -07:00
bac2e40eb2
fixes #4435 - changed title of menuitem for delete and added content description
...
setting menu title should also set content description. I added the setContentDescription programmatically in order to ensure that the content description is being set. If content description matches title it won't be read twice
2019-08-02 17:09:24 -07:00
c2e6e25bef
Fixes #4005 - Move getColorFromAttr to Context
2019-07-26 16:44:11 -04:00
8381025ac5
For #2160 - Hide Keyboard in onPause from EditBookmarkFragment
2019-07-17 09:20:28 -07:00
ef8d9604ae
No issue: Normalize license header comment ( #3909 )
2019-07-12 11:38:15 -07:00
6bb67a9de7
For #3364 : Set bookmark root titles onResume ( #3828 )
2019-07-03 13:13:53 -05:00
30930cdc88
Import variables referred to by path
2019-06-25 13:57:34 -07:00
d01bb8c442
Use lifecycleScope for collections fragments
2019-06-25 13:56:15 -07:00
94e99cf877
For #3364 : Edit bookmarks should show corrected bookmarks tree ( #3446 )
2019-06-25 14:19:33 -05:00
2ebe0a2a48
Fixes #3529 - Display "Edit folder" title when editing a bookmark folder ( #3549 )
2019-06-24 13:34:15 -07:00
1e6da54263
For #3238 : fixes race condition crash, nav destination unknown
2019-06-06 15:46:34 -07:00
0b3a8b7a54
For #2316 : Adds confirmation dialog to delete bookmark
2019-06-04 14:47:11 -07:00
7c00c2983b
No issue: Fix crash on bookmark folder selection and Snackbar color
2019-04-20 15:10:24 -05:00
849764d23a
For #974 : Telemetry for Bookmarks
2019-04-17 15:58:58 -07:00
5d6112da05
No issue: Missing clear button in edit bookmarks UI
2019-04-15 13:17:41 -05:00
29832c5e84
For #724 : Consolidates colors
2019-04-15 12:22:03 -05:00
d7272d29de
For #1408 - Set Toolbar titles in code (vs in navgraph)
2019-04-09 16:36:14 -07:00
b54d4d1d58
Closes #1312 , #1236 , #1237 , #1238 , #1239 : Creating, Editing, and Deleting Bookmarks and Bookmark Folders
2019-04-08 14:48:36 -05:00
Tiger Oakes