1
0
Fork 0
Commit Graph

64 Commits (15ff4726a0a90d7be7a89f60e706d543b969ab99)

Author SHA1 Message Date
Jeff Boek a42ad7603b For #5073 - Fixes visual alignment when certificate authority breaks into a new line 2020-02-07 09:10:31 -08:00
Jeff Boek 7a16192fd1 For #5073 - Use string parameter versus concatenating programatically 2020-02-07 09:10:31 -08:00
Kate Glazko 7c00a1ad6b For #5073: View Site Cert 2020-02-07 09:10:31 -08:00
Kadeem f4f93e761e NOISSUE - Renamed a misspelled variable. 2020-02-06 18:25:11 +01:00
Tiger Oakes c0d7bc5bd5 Use navArgs helper in fragments 2020-02-05 16:37:45 -08:00
David Walsh f728cdaf05
Bug 7189 - Provide page title in website information dialog (#7255)
* Bug 7189 - Provide page title in website information dialog

* Update QSFS test

* Fix Tiger's nits
2020-01-30 11:24:53 -08:00
Rushab Kumar e6791b5c08 For #7154 - Fix crash when tapping on "Blocked" in the site info panel (#7404) 2020-01-08 13:51:45 -08:00
David Walsh e727ae5d7e Fix 5366 - Use VectorDrawableCompat for all imagery (#7221)
* Fix 5366 - Use VectorDrawableCompat for all imagery

* Fix detekt lint issues

* Restore previous comment contents
2019-12-16 20:35:36 -08:00
David Walsh c69e72bdba Fix 3809 - Show entire URL in security info view 2019-11-18 14:01:40 -08:00
Emily Kager d9615108ee For #6354 - Removes ETP Experiment, Removes Feature Flags, Sets Strict Default 2019-11-08 08:37:15 -08:00
ekager 18c0525ff6 Use new API for ETP Exceptions 2019-11-05 12:45:58 -08:00
Mugurell c5739df969 For #4126 - Add tests for the new classes resulting from refactoring
Used runBlocking to ensure we wait for the code using coroutines to execute
instead of runBlockingTest and join() since this last option led to failed
tests in CI because of
"java.lang.IllegalStateException: This job has not completed yet".
2019-10-31 17:08:40 -07:00
Mugurell 9f56624788 For #4126 - Document the newly introduced public APIs
Now that the code should be in a ready-to-ship form it would be nice to have
all the major functionalities properly documented.
2019-10-31 17:08:40 -07:00
Mugurell d70afcaa90 For #4126 - Handle all business logic with Interactors and a Controller
Combined all Stores into one for all Views shown in on Fragment.
Used a static `createStore()` which will build the initial state residing
inside the Store and not in the Fragment as to decouple the Fragment from the
business logic needed to build all the needed initial States.
Added Interactors that handle a MVI View's business logic for
TrackingProtectionView and WebsitePermissionsView.
WebsiteInfoView doesn't register any user input events and does not have any
reason to change while it is displayed so it does not have an Interactor.
The two Interactors will delegate Fragment's QuickSettingsController for
complex Android interactions, communication with other app features or for
Store updates.
Also refactored the stubs from the previous commit so that with this commit the
the quicksettings feature should all be working now based on lib-state.
2019-10-31 17:08:40 -07:00
Mugurell f1f74bc3d6 For #4126 - Refactor Views and layouts
Refactored `fragment_quick_settings_dialog_sheet` to now be composed of of
FrameLayouts placeholders in which each independent View will inflate itself.
Refactored the QuickSettingsUIView and Component to 3 standalone Views with
their own lib-state components: Store, State, Actions, Reducer.
2019-10-31 17:08:40 -07:00
shldhll 8e17ac05b1 Optimized imports. Closes #5876 2019-10-10 04:17:43 +05:30
shldhll f907ec52f0 Removed ObsoleteCoroutinesApi in tests. Closes #5876 2019-10-10 04:04:51 +05:30
Tiger Oakes 8c30200ced Only use Context.settings() function (not getter) (#5335)
Remove unused String extensions
2019-09-24 10:33:46 -07:00
Tiger Oakes 05a4faec78 Add tryGetHostFromUrl and update ExceptionDomains 2019-09-19 22:40:35 -04:00
Colin Lee 1aa4f5a519 For #255: Toggle Media Autoplay 2019-09-19 15:13:04 -07:00
Emily Kager 3e132f102c No issue: Update androidx libraries Sept 5 2019 2019-09-17 09:50:31 -07:00
Emily Kager 4485b7f647 Add Tracking Protection Info Panel 2019-09-11 07:47:13 -07:00
Mihai Adrian a31eb1f371 Code Health #4883: Refactored accessing settings by using Context extensions (#4973) 2019-09-10 10:11:58 -07:00
Tiger Oakes aab357845b No issue: Clean up preferences code (#4699) 2019-08-21 08:38:14 -07:00
Tiger Oakes 33f3b14c29 Adds setters and property delegates in `Settings` (#4809)
* Change Settings to use setters

* Add delegate for shared preferences
2019-08-20 10:47:55 -07:00
Tiger Oakes 9ee8c00928 For #4774 - Use vector drawable compat (#4811) 2019-08-20 10:43:02 -07:00
Arturo Mejia 210868f5bc Use Mozilla Android Components 9.0.0-SNAPSHOT. (#4750) 2019-08-19 10:29:10 -07:00
Tiger Oakes 52542708aa Consodilate private browsing code 2019-08-09 11:00:41 -07:00
Colin Lee ef97173cd9
For #4529, #4427: Resuming after restoring instance state breaks UI (#4571)
* For #4529, #4427: Resuming after restoring instance state breaks UI

* Clear up warnings
2019-08-08 11:05:01 -05:00
Nikit Bhandari 46de06d132 For #4339 reduce build warnings (#4340) 2019-07-31 11:43:49 -07:00
Tiger Oakes d1651ecf71 Closes #4012 - Animate quick settings (#4047) 2019-07-30 09:50:50 -07:00
Tiger Oakes 87d8f3b037 Remove redundant super calls 2019-07-29 10:22:53 -07:00
Nikit Bhandari f110ba2861 use synthetic binding instead of findviewbyid 2019-07-19 16:51:26 -04:00
Emily Kager 95367c2b50 For #3521 - Show Quick Settings Dialog Entirely in Landscape 2019-07-17 09:52:01 -07:00
Tiger Oakes ef8d9604ae No issue: Normalize license header comment (#3909) 2019-07-12 11:38:15 -07:00
Arturo Mejia b82340bf1f For #3750: Crash when tapping "Blocked" on Google Maps after disabling
location requests.
2019-06-29 18:39:19 -07:00
Tiger Oakes 55f5c5d049 Use lifecycleScope for settings fragments 2019-06-25 13:56:33 -07:00
Tiger Oakes 82d2a0661b Remove deprecatd support-ktx methods (#3305) 2019-06-10 09:12:11 -05:00
Jeff Boek f9d70dbc92 For #2723 - Creates callbacks to wire up the mode and theme manager together 2019-05-30 16:38:31 -07:00
Emily Kager e0ceb195ff For #2337 - Open Report Site in Browser from Custom Tab 2019-05-28 14:56:01 -07:00
Emily Kager 7492de321d For #2530 - Show report site issue and TP off globally in quick settings 2019-05-23 08:34:24 -07:00
Sören Hentzschel 6bc577eecd For #1800 - "report site issue" should open in a new tab 2019-05-16 22:28:02 -07:00
Emily Kager 855acd5fe2 Closes #2528 - Fixes Dialog navigation 2019-05-16 22:24:09 -07:00
Sawyer Blatz 72d29c2a43
For #2205 & #1578: Integrates tab collection storage (#2478)
* For #2205: Adds TabCollectionStorage

* For #1578: Adds delete to TabCollection
2019-05-16 14:02:24 -07:00
Jeff Boek c5e5ef4b25
Teases apart ViewModel dependencies (#2499)
* No Issue - pulls render outside of the viewmodel

* No Issue - Properly subscribes to the changesObservable

* No Issue - Fixes ViewModel tests
2019-05-14 23:16:48 -07:00
ekager a078f9e48b For #2422 If TP disabled globally disable quicksettings TP exception toggle 2019-05-14 15:38:39 -07:00
Emily Kager e0e7ba5a43 For #2302 - Listen to session to update QuickSettingsSheetDialogFragment 2019-05-14 13:49:59 -07:00
Colin Lee 49ac62ab85 Fix ViewModel States (#2457)
Co-authored-by: Jeff Boek <jeff@jeffboek.com>
2019-05-14 13:49:02 -07:00
Emily Kager 4070941657 No issue: Refactor dialogs to use nav graph 2019-05-10 19:58:48 -07:00
Arturo Mejia 744f1be0a9 Closes #1411: Added disabled style for permissions site info panel. (#2354) 2019-05-10 20:23:18 -05:00