fenix

blallo

fenix

Fork 0

Commit Graph

Author	SHA1	Message	Date
Severin Rudie	dffa61bf16	Closes #4513 : fixes bookmark tests broken by loading change Note that BookmarkFragmentStoreTest changes preserve existing behavior, which in many cases is more expansive than the test name implies	2019-09-26 16:29:14 -07:00
Severin Rudie	96472a533a	Issue #4513 : fix mismatched bookmark listener lifecycles The mismatch here was creating potentially inconsistent states. When first put into a CREATED or STARTED state, the listener would not be active, however after going through onResume it would then stay active until destroyed. We should only be navigating to bookmarks when in a RESUMED state, so this change should be safe. I tried it a few times to verify. But I've been wrong before!	2019-09-26 16:29:14 -07:00
Tiger Oakes	d0ef2d40c2	Move bookmark navigation listener to separate file	2019-09-10 16:53:09 -07:00

Author

SHA1

Message

Date

Severin Rudie

dffa61bf16

Closes #4513 : fixes bookmark tests broken by loading change

Note that BookmarkFragmentStoreTest changes preserve existing behavior, which in many cases is more expansive than the test name implies

2019-09-26 16:29:14 -07:00

Severin Rudie

96472a533a

Issue #4513 : fix mismatched bookmark listener lifecycles

The mismatch here was creating potentially inconsistent states. When first put into a CREATED or STARTED state, the listener would not be active, however after going through onResume it would then stay active until destroyed.

We should only be navigating to bookmarks when in a RESUMED state, so this change should be safe. I tried it a few times to verify. But I've been wrong before!

2019-09-26 16:29:14 -07:00

Tiger Oakes

d0ef2d40c2

Move bookmark navigation listener to separate file

2019-09-10 16:53:09 -07:00

3 Commits (15ff4726a0a90d7be7a89f60e706d543b969ab99)