1
0
Fork 0
Commit Graph

19 Commits (15ff4726a0a90d7be7a89f60e706d543b969ab99)

Author SHA1 Message Date
Sawyer Blatz 1372ed5837 For #7970: Updates snackbars for accessibility 2020-01-31 16:24:36 +01:00
Sawyer Blatz c7c4ad051a
For #6413: Adds more snackbar positioning logic (#7444)
* For #6413: Adds more snackbar positioning logic

* Refactor
2020-01-02 14:31:52 -08:00
Sawyer Blatz 3fb060f682
For #6413: Fixes snackbar positionining for bottom toolbar (#7415)
* For #6413: Fixes snackbar positionining for bottom toolbar

* For #6413: Cleans up snackbar usage
2019-12-30 14:43:15 -08:00
kglazko 300d8317e1
Issue 5366 Vector Drawable Compat (#6904) 2019-12-05 19:54:32 -08:00
Mugurell c5330c6880 For 5092 - Show a Snackbar with retry option if sharing to devices fails (#5158)
* For #5092 - Show a Snackbar with retry option if sharing to devices fails

ShareController will contain all the business logic for checking the result
status of the `share to device` operations. When this fails it will show a
snackbar which also offer the possibility to retry the just failed operation.
To allow this even in the event the user has closed the share fragment we'll
use a GlobalScope's coroutine.
Refactored out the TabsSharedCallback from ShareFragment because otherwise we
would have neede to sent through that the just failed operation. After the
refactor the ShareController is solely responsable for showing the right
snackbar and handling the retry actions.

* For #5092 - Refactor ShareControllerTest

* For #5092: Adds color theming of snackbars
2019-09-26 12:30:28 -07:00
Colin Lee 3dc20543e3
For #4128: Migrate Bookmarks to LibState (#4254) 2019-07-25 21:55:51 -05:00
Tiger Oakes ef8d9604ae No issue: Normalize license header comment (#3909) 2019-07-12 11:38:15 -07:00
Tiger Oakes 30930cdc88 Import variables referred to by path 2019-06-25 13:57:34 -07:00
Grisha Kruglov 5f42a65c2a No issue: improve allowUndo
This patch fixes a few issues:
- it was an extension on a CoroutineScope, but that was quite misleading
since the Main dispatcher would be always used regardless of what dispatcher
the owning CoroutineScope was configured with.
- timing was reliant on exact value of the undocumented Snackbar.LENGTH_LONG duration
- coroutine cancellation relied on cooperation of the 'operation' suspend function,
which we can't depend on

New 'allowUndo' fully controls its timing, doesn't imply a dispatcher to its consumers,
and doesn't rely on cooperation of passed-in suspend blocks for cancellation to work.
2019-05-30 10:48:59 -07:00
Colin Lee 96b68948b5
For #1710: Create scaffolding for Robolectric tests (#2282) 2019-05-07 16:36:37 -05:00
Jeff Boek 4fae36f0af Fixes #1430 - Implements UX feedback for the FenixSnackbar 2019-04-15 13:34:50 -07:00
Jeff Boek 9de120b8ab Fixes #1534 - Fixes snackbar not finding the root layout 2019-04-11 12:40:23 -05:00
Jeff Boek e98db8bfb8 For #1430 - Adds a changelog entry 2019-04-10 09:58:00 -07:00
Jeff Boek b306bc502a For #1430 - Adjust snackbar colors for darkmode 2019-04-10 09:58:00 -07:00
Jeff Boek cd75b28b8f No longer require a viewgroup to use FenixSnackbar 2019-04-10 09:58:00 -07:00
Jeff Boek 943a03d167 For #1430 - Addresses nits 2019-04-05 14:50:54 -07:00
Jeff Boek 26fd32abed For #1430 - Moves magic numbers to constants 2019-04-05 14:50:54 -07:00
Jeff Boek 2ce72139e3 For #1430 - Replaces existing snackbar and adapts text size 2019-04-05 14:50:54 -07:00
Jeff Boek 371fbf7164 For #1430 - Adds a styled Snackbar 2019-04-05 14:50:54 -07:00