1
0
Fork 0
Commit Graph

345 Commits (0777fb3bbeea9e3fb5b64365027b965951d2cb00)

Author SHA1 Message Date
ekager 0777fb3bbe For #5545 For #5542 Closes #6696 Integrate logins API, adds Settings for Autofilling/Saving Logins 2020-01-15 12:14:08 -08:00
ValentinTimisica 7c5c9355ce For #5884: Adds user-specified search engines telemetry
Created events for adding and deleting a custom search engine and for searches
performed with a custom search engine.
2020-01-13 12:31:23 -08:00
Sebastian Kaspari 6419d0cf13 Open "migration FAQ" when selecting "What's new" in a Fennec build. 2020-01-13 17:08:48 +01:00
mcarare a72620ae07 For #7522 Catch IllegalArgumentException when validating search string 2020-01-10 11:26:11 -08:00
Sawyer Blatz 718c211a86
For #1718: Sets accessibility users to top toolbar by default (#7486) 2020-01-09 09:15:02 -08:00
Rushab Kumar e6791b5c08 For #7154 - Fix crash when tapping on "Blocked" in the site info panel (#7404) 2020-01-08 13:51:45 -08:00
mcarare 2bdde48986 For #7522 Ensure correct protocol is used in search string 2020-01-08 11:13:49 -08:00
kglazko 8ed14ac062
Issue 5736 Improve pop behavior after deleting tabs in settings (#7478) 2020-01-08 10:27:14 -08:00
Will Hawkins 9c28cb632c Issue #7425 (et al): Cache the list of installed browsers
Cache the list of installed browsers. Calling `Browsers.all`
the application directly redundantly recalculates the list.
Accessing the list of installed browsers through this cache
will reduce that overhead.
2020-01-07 18:40:07 -08:00
Mihai Branescu ea2411a88b Feature/#220 language menu (#7070)
* For #220
- Added advanced header + locale settings item in the settings fragment

* For #220
- Added locale selection page with lib state + handling of locale changes

* For #220
- Removed registering for locale changes in the manifest, allow system
to restart activity in that scenario

* For #220
- Added unit tests for locale settings page

* For #220: fixed an outdated unit test
ga-a

Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
2020-01-03 18:15:35 -08:00
Sawyer Blatz c7c4ad051a
For #6413: Adds more snackbar positioning logic (#7444)
* For #6413: Adds more snackbar positioning logic

* Refactor
2020-01-02 14:31:52 -08:00
Sawyer Blatz 3fb060f682
For #6413: Fixes snackbar positionining for bottom toolbar (#7415)
* For #6413: Fixes snackbar positionining for bottom toolbar

* For #6413: Cleans up snackbar usage
2019-12-30 14:43:15 -08:00
Emma Malysz 13f73c2d2c
For issue 7192: move unsetOpenLinksInAPrivateTabIfNecessary off main thread. (#7246)
Move method to Settings. There are two instances when we want to call this method: either
processing an intent, or within DefaultBrowserPreference
2019-12-30 14:42:13 -08:00
Josh 593981fa4b Fix parameterized message in search engine (#7302) 2019-12-20 10:27:05 +02:00
Tiger Oakes b85673acac Clean up settings fragments 2019-12-19 14:29:28 -08:00
mcarare 907d96e39f For #6709, for #6849 Handle default engine deletion and undo operation
Uninstall engine immediately and allow reinstall in onCancel.
Set previous list with default engine in onCancel.
Keep default engine change in operation and remove now unnecessary view refresh.
2019-12-18 23:00:42 -08:00
David Walsh e727ae5d7e Fix 5366 - Use VectorDrawableCompat for all imagery (#7221)
* Fix 5366 - Use VectorDrawableCompat for all imagery

* Fix detekt lint issues

* Restore previous comment contents
2019-12-16 20:35:36 -08:00
mcarare bc6b7725e9 For #6968 Close response stream to allow use of caching 2019-12-13 12:35:25 -08:00
mcarare d2abac78eb For #7075 Update passwords preference visibility and string
Set visibility for feature flags before settings screen it's displayed.
Change string for preference to match existing header string.
Update UI Tests
2019-12-13 12:19:14 -08:00
ValentinTimisica b819cb11c9 For #4776: Added Unit tests for About Page. 2019-12-12 11:34:10 +02:00
ValentinTimisica c6c827f693 For #4776: Redesign and refactor the About Page
Added new items to be displayed.
2019-12-12 11:34:10 +02:00
Mihai Adrian 6e9769a81b For #7031 - Hide progress bar when leaving DeleteBrowsingDataFragment (#7056) 2019-12-10 11:17:45 -05:00
Mihai Adrian 45ae8cb35a For #6997 Avoid overwriting empty_search_string error (#6998)
Setting error twice also clips error message
2019-12-09 18:10:24 -08:00
Emily Kager 76e9200304 For #6922 - Check current destination is logins fragment before navigation (#6924) 2019-12-09 15:42:40 -08:00
Jeff Boek eb6e6b774f For #6848 - Sorts the search engine list without case sensitivity
Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
2019-12-04 16:10:26 -08:00
Jeff Boek 1cc496a683 For #6847 - Properly rebuilds the SearchEngineList on undo
Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
2019-12-04 16:10:26 -08:00
ekager d8babadf7f For #6889 - Check current destination before navigating from settings 2019-12-02 10:40:21 -08:00
ekager f5cf0b7e2a For #6890 - Don't crash with no connection when adding custom search engine 2019-12-02 10:37:31 -08:00
Jeff Boek 1b1f9348dc No Issue - Fixes warnings / compiler errors with A-C update 2019-11-28 12:45:45 +01:00
Mihai Branescu 7cf71c8ef3
For #6396 - Added metrics for tracking history/bookmarks account sync toggles (#6601) 2019-11-27 11:16:23 +02:00
Sawyer Blatz 769c1e422d For #5694 & #6054: Allows users to change toolbar position (#6608)
* For #5694 & #6054: Adds preference screen for toolbar

* For #5694: Adds changing toolbar position functionality

* No issue: Updates telemetry links to actually work lol 😬

* For #6054: Adds toolbar position to core ping
2019-11-25 16:43:32 -08:00
Tiger Oakes 422faaf7c0 Add toolbar helpers (#6531) 2019-11-25 15:36:47 -05:00
matthewcmckenna afac413c98 Add ETP accessibility labels 2019-11-21 15:27:35 -08:00
mcarare 1d36098878 For #1019 Add onboarding search suggestion hint panel 2019-11-21 14:36:14 -08:00
mcarare 5543f3272d For #1019 Add option to enable search suggestions in private mode 2019-11-21 14:36:14 -08:00
Jeff Boek 54773afb68
For #2477 - Removes the feature flag for Force Enable Zoom (#6646)
* For #2477 - Removes the feature flag for Force Enable Zoom

* For #2477 - Fixes bug where zoom preference doesnt persist between launches
2019-11-20 10:32:38 -08:00
Jeff Boek 607c3d4c87
Adds custom search engines (#6551)
* For #5577 - Adds button to add a new search engine

* For #5577 - Adds custom engine store

* For #5577 - Creates a custom SearchEngineProvider

* For #5577 - Gives the ability to delete search engines

* For #5577 - Adds the UI to add a custom search engine

* For #5577 - Adds form to create a custom search engine

* For #5577 - Adds the ability to add a custom search engine

*  For #5577 - Adds the ability to delete custom search engines

* For #5577 - Selects the first element on the add custom search engine screen

* For #5577 - Prevents adding a search engine that already exists

* For #5577 - Styles the add search engine preference

* For #5577 - Makes the name check case-insensitive

* For #5577 - Fix bug where home screen doesnt see new search engines

* For #5577 - Moves Search URL validation to its own type

* For #5577 - Fixes linting errors

* For #5577 - Adds the ability to edit a custom search engine

* For #5577 - Allows the user to edit a serach engine even when it is the last item in the list

* For #5577 - Adds an undo snackbar when deleting a search engine

* For #5577 - Moves all of the strings to be translated

* For #5577 - Fixes bug when deleting your default search engine

* For #5577 - Puts adding search engines behind a feature flag

* For #5577 - Navigate to custom search engine SUMO article when tapping learn more

* For #5577 - Fixes nits

* For #5577 - Uses concept-fetch to validate search string

* For #5577 - Adds string resources for the cannot reach error state
2019-11-19 16:30:56 -08:00
David Walsh c69e72bdba Fix 3809 - Show entire URL in security info view 2019-11-18 14:01:40 -08:00
Emily Kager cc318021cc For #5586 - Adds Logins Telemetry (#6352)
* For #5586 - Adds Logins Telemetry

* Adds Logins Sync Telemetry to PreferenceToggled event
2019-11-12 15:55:36 -08:00
RAJESH KUMAR ARUMUGAM 6ee59322b5 Added Vibration Effect On Scanning QR Code (#6129)
* Added Vibration Effect On Scanning QR Code

Added Vibration Feature for the new feature Request
Vibrate phone upon successful pairing #2928

* Added Vibration Effect On Scanning QR Code

Added Vibration Feature for the new feature Request
Vibrate phone upon successful pairing #2928

* Update PairFragment.kt

Removed unwanted blank lines

* Update PairFragment.kt

Removed the Casting with !!
2019-11-08 13:37:36 -08:00
Emily Kager d9615108ee For #6354 - Removes ETP Experiment, Removes Feature Flags, Sets Strict Default 2019-11-08 08:37:15 -08:00
Grisha Kruglov 40047315c2 For #6490 - track abnormal FxA behaviour via Sentry 2019-11-07 15:11:41 -08:00
Sawyer Blatz 4183dea591 For #5547: Reuse biometricPrompt when authenticating
This fixes an issue with Samsung devices where an invisible DeviceCredentialHandler because the executor was "null" (it wasn't actually)

You *must* reuse the biometric object instead of creating a new one.
2019-11-07 13:45:41 -08:00
Emily Kager 3e2b88cc91 For #5547 - Add top level auth when accessing passwords 2019-11-07 13:45:41 -08:00
ekager 18c0525ff6 Use new API for ETP Exceptions 2019-11-05 12:45:58 -08:00
Emily Kager 1ee0703bc3 For #6441 - Only enable experiments for Beta/Prod 2019-11-04 16:45:35 -08:00
Mugurell c5739df969 For #4126 - Add tests for the new classes resulting from refactoring
Used runBlocking to ensure we wait for the code using coroutines to execute
instead of runBlockingTest and join() since this last option led to failed
tests in CI because of
"java.lang.IllegalStateException: This job has not completed yet".
2019-10-31 17:08:40 -07:00
Mugurell 9f56624788 For #4126 - Document the newly introduced public APIs
Now that the code should be in a ready-to-ship form it would be nice to have
all the major functionalities properly documented.
2019-10-31 17:08:40 -07:00
Mugurell d70afcaa90 For #4126 - Handle all business logic with Interactors and a Controller
Combined all Stores into one for all Views shown in on Fragment.
Used a static `createStore()` which will build the initial state residing
inside the Store and not in the Fragment as to decouple the Fragment from the
business logic needed to build all the needed initial States.
Added Interactors that handle a MVI View's business logic for
TrackingProtectionView and WebsitePermissionsView.
WebsiteInfoView doesn't register any user input events and does not have any
reason to change while it is displayed so it does not have an Interactor.
The two Interactors will delegate Fragment's QuickSettingsController for
complex Android interactions, communication with other app features or for
Store updates.
Also refactored the stubs from the previous commit so that with this commit the
the quicksettings feature should all be working now based on lib-state.
2019-10-31 17:08:40 -07:00
Mugurell f1f74bc3d6 For #4126 - Refactor Views and layouts
Refactored `fragment_quick_settings_dialog_sheet` to now be composed of of
FrameLayouts placeholders in which each independent View will inflate itself.
Refactored the QuickSettingsUIView and Component to 3 standalone Views with
their own lib-state components: Store, State, Actions, Reducer.
2019-10-31 17:08:40 -07:00