From fa8199f429c9f5dde6d025bb868d3d324405a50d Mon Sep 17 00:00:00 2001 From: mihai-adrian Date: Thu, 25 Jul 2019 16:53:03 +0300 Subject: [PATCH] fixes #4221 - The tap area for Open tabs' new tab and 3 dot menu buttons is too small changed size of buttons to 48X48 following Material Design Accessibility guidelines. removed margins from end of layout and spaces between buttons to provide consistency with the buttons from the top --- app/src/main/res/layout/tab_header.xml | 66 +++++++++++++------------- 1 file changed, 33 insertions(+), 33 deletions(-) diff --git a/app/src/main/res/layout/tab_header.xml b/app/src/main/res/layout/tab_header.xml index fb1d36ed1..d71d73364 100644 --- a/app/src/main/res/layout/tab_header.xml +++ b/app/src/main/res/layout/tab_header.xml @@ -3,45 +3,45 @@ - License, v. 2.0. If a copy of the MPL was not distributed with this - file, You can obtain one at http://mozilla.org/MPL/2.0/. --> + xmlns:android="http://schemas.android.com/apk/res/android" + xmlns:app="http://schemas.android.com/apk/res-auto" + android:id="@+id/tabs_header" + android:layout_marginBottom="8dp" + android:layout_width="match_parent" + android:layout_height="wrap_content"> + android:id="@+id/header_text" + android:layout_width="wrap_content" + android:layout_height="wrap_content" + android:layout_marginStart="4.5dp" + android:text="@string/tab_header_label" + android:textAppearance="@style/HeaderTextStyle" + app:layout_constraintBottom_toBottomOf="parent" + app:layout_constraintStart_toStartOf="parent" + app:layout_constraintTop_toTopOf="parent" /> + android:layout_width="wrap_content" + android:layout_height="wrap_content" + android:orientation="horizontal" + app:layout_constraintBottom_toBottomOf="parent" + app:layout_constraintTop_toTopOf="parent" + app:layout_constraintEnd_toEndOf="parent"> + android:id="@+id/add_tab_button" + android:layout_width="48dp" + android:layout_height="48dp" + android:background="?android:attr/selectableItemBackgroundBorderless" + android:contentDescription="@string/add_tab" + android:src="@drawable/ic_new"/> + android:id="@+id/tabs_overflow_button" + android:layout_width="48dp" + android:layout_height="48dp" + android:background="?android:attr/selectableItemBackgroundBorderless" + android:contentDescription="@string/open_tabs_menu" + android:src="@drawable/ic_menu" /> \ No newline at end of file