From f3ed207bdbe422998027d4ba5e4676bc9cc4814b Mon Sep 17 00:00:00 2001 From: Michael Comella Date: Wed, 15 Apr 2020 11:14:53 -0700 Subject: [PATCH] For #8803 - review: Add clarifying comments to onAppInit capture methods. --- app/src/main/java/org/mozilla/fenix/FenixApplication.kt | 4 +++- app/src/main/java/org/mozilla/fenix/perf/StartupTimeline.kt | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/org/mozilla/fenix/FenixApplication.kt b/app/src/main/java/org/mozilla/fenix/FenixApplication.kt index dad8eb95d..3d607eb7a 100644 --- a/app/src/main/java/org/mozilla/fenix/FenixApplication.kt +++ b/app/src/main/java/org/mozilla/fenix/FenixApplication.kt @@ -374,6 +374,8 @@ open class FenixApplication : LocaleAwareApplication() { protected fun recordOnInit() { // This gets called by more than one process. Ideally we'd only run this in the main process // but the code to check which process we're in crashes because the Context isn't valid yet. - StartupTimeline.onApplicationInit() + // + // This method is not covered by our internal crash reporting: be very careful when modifying it. + StartupTimeline.onApplicationInit() // DO NOT MOVE ANYTHING ABOVE HERE: the timing is critical. } } diff --git a/app/src/main/java/org/mozilla/fenix/perf/StartupTimeline.kt b/app/src/main/java/org/mozilla/fenix/perf/StartupTimeline.kt index a761520ba..8a8f45cfa 100644 --- a/app/src/main/java/org/mozilla/fenix/perf/StartupTimeline.kt +++ b/app/src/main/java/org/mozilla/fenix/perf/StartupTimeline.kt @@ -46,6 +46,8 @@ object StartupTimeline { fun onApplicationInit() { // This gets called from multiple processes: don't do anything expensive. See call site for details. + // + // This method also gets called multiple times if there are multiple Application implementations. frameworkStartMeasurement.onApplicationInit() }