diff --git a/app/src/main/java/org/mozilla/fenix/addons/AddonsManagementFragment.kt b/app/src/main/java/org/mozilla/fenix/addons/AddonsManagementFragment.kt index 40ec6127e..ac7ee10e6 100644 --- a/app/src/main/java/org/mozilla/fenix/addons/AddonsManagementFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/addons/AddonsManagementFragment.kt @@ -13,21 +13,21 @@ import androidx.navigation.Navigation import androidx.recyclerview.widget.LinearLayoutManager import kotlinx.android.synthetic.main.fragment_add_ons_management.* import kotlinx.android.synthetic.main.fragment_add_ons_management.view.* +import kotlinx.coroutines.CoroutineScope import kotlinx.coroutines.Dispatchers import kotlinx.coroutines.Dispatchers.IO -import kotlinx.coroutines.launch -import kotlinx.coroutines.flow.collect -import kotlinx.coroutines.CoroutineScope -import mozilla.components.lib.state.ext.flowScoped -import mozilla.components.support.ktx.kotlinx.coroutines.flow.ifChanged import kotlinx.coroutines.ExperimentalCoroutinesApi import kotlinx.coroutines.cancel +import kotlinx.coroutines.flow.collect +import kotlinx.coroutines.launch import mozilla.components.feature.addons.Addon import mozilla.components.feature.addons.AddonManagerException import mozilla.components.feature.addons.ui.AddonsManagerAdapter import mozilla.components.feature.addons.ui.AddonsManagerAdapterDelegate import mozilla.components.feature.addons.ui.PermissionsDialogFragment import mozilla.components.feature.addons.ui.translatedName +import mozilla.components.lib.state.ext.flowScoped +import mozilla.components.support.ktx.kotlinx.coroutines.flow.ifChanged import org.mozilla.fenix.R import org.mozilla.fenix.ext.components import org.mozilla.fenix.ext.getRootView diff --git a/app/src/main/java/org/mozilla/fenix/collections/CollectionCreationView.kt b/app/src/main/java/org/mozilla/fenix/collections/CollectionCreationView.kt index e10a06415..7135924ce 100644 --- a/app/src/main/java/org/mozilla/fenix/collections/CollectionCreationView.kt +++ b/app/src/main/java/org/mozilla/fenix/collections/CollectionCreationView.kt @@ -11,6 +11,7 @@ import android.view.LayoutInflater import android.view.View import android.view.ViewGroup import android.view.inputmethod.EditorInfo +import androidx.appcompat.content.res.AppCompatResources import androidx.constraintlayout.widget.ConstraintSet import androidx.core.content.ContextCompat import androidx.recyclerview.widget.LinearLayoutManager @@ -18,7 +19,6 @@ import androidx.recyclerview.widget.RecyclerView import androidx.transition.AutoTransition import androidx.transition.Transition import androidx.transition.TransitionManager -import androidx.appcompat.content.res.AppCompatResources import kotlinx.android.extensions.LayoutContainer import kotlinx.android.synthetic.main.component_collection_creation.* import kotlinx.android.synthetic.main.component_collection_creation.view.* diff --git a/app/src/main/java/org/mozilla/fenix/components/AccountAbnormalities.kt b/app/src/main/java/org/mozilla/fenix/components/AccountAbnormalities.kt index e52718539..bc040160f 100644 --- a/app/src/main/java/org/mozilla/fenix/components/AccountAbnormalities.kt +++ b/app/src/main/java/org/mozilla/fenix/components/AccountAbnormalities.kt @@ -17,7 +17,6 @@ import mozilla.components.concept.sync.OAuthAccount import mozilla.components.lib.crash.CrashReporter import mozilla.components.service.fxa.manager.FxaAccountManager import mozilla.components.support.base.log.logger.Logger -import java.lang.Exception import kotlin.coroutines.CoroutineContext /** diff --git a/app/src/main/java/org/mozilla/fenix/components/FirebasePushService.kt b/app/src/main/java/org/mozilla/fenix/components/FirebasePushService.kt index ec3ad6c54..0f0c6d062 100644 --- a/app/src/main/java/org/mozilla/fenix/components/FirebasePushService.kt +++ b/app/src/main/java/org/mozilla/fenix/components/FirebasePushService.kt @@ -5,12 +5,12 @@ package org.mozilla.fenix.components import android.annotation.SuppressLint -import com.google.firebase.messaging.RemoteMessage import com.google.firebase.messaging.FirebaseMessagingService +import com.google.firebase.messaging.RemoteMessage import com.leanplum.LeanplumPushFirebaseMessagingService import mozilla.components.concept.push.PushService -import mozilla.components.lib.push.firebase.AbstractFirebasePushService import mozilla.components.feature.push.AutoPushFeature +import mozilla.components.lib.push.firebase.AbstractFirebasePushService /** * A wrapper class that only exists to delegate to [FirebaseMessagingService] instances. diff --git a/app/src/main/java/org/mozilla/fenix/components/InflationAwareFeature.kt b/app/src/main/java/org/mozilla/fenix/components/InflationAwareFeature.kt index a065ef2aa..79375c77b 100644 --- a/app/src/main/java/org/mozilla/fenix/components/InflationAwareFeature.kt +++ b/app/src/main/java/org/mozilla/fenix/components/InflationAwareFeature.kt @@ -3,8 +3,8 @@ package org.mozilla.fenix.components import android.view.View import android.view.ViewStub import androidx.annotation.UiThread -import mozilla.components.support.base.feature.UserInteractionHandler import mozilla.components.support.base.feature.LifecycleAwareFeature +import mozilla.components.support.base.feature.UserInteractionHandler import java.lang.ref.WeakReference /** diff --git a/app/src/main/java/org/mozilla/fenix/components/IntentProcessorType.kt b/app/src/main/java/org/mozilla/fenix/components/IntentProcessorType.kt index 2df23f295..5127f3331 100644 --- a/app/src/main/java/org/mozilla/fenix/components/IntentProcessorType.kt +++ b/app/src/main/java/org/mozilla/fenix/components/IntentProcessorType.kt @@ -7,8 +7,8 @@ package org.mozilla.fenix.components import android.content.Intent import mozilla.components.feature.intent.processing.IntentProcessor import org.mozilla.fenix.HomeActivity -import org.mozilla.fenix.migration.MigrationProgressActivity import org.mozilla.fenix.customtabs.ExternalAppBrowserActivity +import org.mozilla.fenix.migration.MigrationProgressActivity enum class IntentProcessorType { EXTERNAL_APP, NEW_TAB, MIGRATION, OTHER; diff --git a/app/src/main/java/org/mozilla/fenix/components/metrics/ActivationPing.kt b/app/src/main/java/org/mozilla/fenix/components/metrics/ActivationPing.kt index bdd51efe8..0101b2b9c 100644 --- a/app/src/main/java/org/mozilla/fenix/components/metrics/ActivationPing.kt +++ b/app/src/main/java/org/mozilla/fenix/components/metrics/ActivationPing.kt @@ -8,16 +8,16 @@ import android.content.Context import android.content.SharedPreferences import android.util.Base64 import androidx.annotation.VisibleForTesting -import mozilla.components.support.base.log.logger.Logger -import org.mozilla.fenix.GleanMetrics.Activation -import org.mozilla.fenix.GleanMetrics.Pings import com.google.android.gms.ads.identifier.AdvertisingIdClient import com.google.android.gms.common.GooglePlayServicesNotAvailableException import com.google.android.gms.common.GooglePlayServicesRepairableException import kotlinx.coroutines.CoroutineScope import kotlinx.coroutines.Dispatchers -import kotlinx.coroutines.withContext import kotlinx.coroutines.launch +import kotlinx.coroutines.withContext +import mozilla.components.support.base.log.logger.Logger +import org.mozilla.fenix.GleanMetrics.Activation +import org.mozilla.fenix.GleanMetrics.Pings import java.io.IOException import java.security.NoSuchAlgorithmException import java.security.spec.InvalidKeySpecException diff --git a/app/src/main/java/org/mozilla/fenix/components/metrics/GleanMetricsService.kt b/app/src/main/java/org/mozilla/fenix/components/metrics/GleanMetricsService.kt index 927b765ad..c791d6a54 100644 --- a/app/src/main/java/org/mozilla/fenix/components/metrics/GleanMetricsService.kt +++ b/app/src/main/java/org/mozilla/fenix/components/metrics/GleanMetricsService.kt @@ -6,8 +6,8 @@ package org.mozilla.fenix.components.metrics import android.content.Context import kotlinx.coroutines.Job -import kotlinx.coroutines.launch import kotlinx.coroutines.MainScope +import kotlinx.coroutines.launch import mozilla.components.service.glean.Glean import mozilla.components.service.glean.private.NoExtraKeys import mozilla.components.support.base.log.logger.Logger diff --git a/app/src/main/java/org/mozilla/fenix/components/metrics/LeanplumMetricsService.kt b/app/src/main/java/org/mozilla/fenix/components/metrics/LeanplumMetricsService.kt index 88d0bd71c..957d5617e 100644 --- a/app/src/main/java/org/mozilla/fenix/components/metrics/LeanplumMetricsService.kt +++ b/app/src/main/java/org/mozilla/fenix/components/metrics/LeanplumMetricsService.kt @@ -10,15 +10,15 @@ import com.leanplum.Leanplum import com.leanplum.LeanplumActivityHelper import com.leanplum.annotations.Parser import com.leanplum.internal.LeanplumInternal -import kotlinx.coroutines.launch -import kotlinx.coroutines.withContext -import kotlinx.coroutines.Job import kotlinx.coroutines.CoroutineScope import kotlinx.coroutines.Dispatchers import kotlinx.coroutines.Dispatchers.Main +import kotlinx.coroutines.Job +import kotlinx.coroutines.launch +import kotlinx.coroutines.withContext import mozilla.components.support.locale.LocaleManager -import org.mozilla.fenix.components.metrics.MozillaProductDetector.MozillaProducts import org.mozilla.fenix.BuildConfig +import org.mozilla.fenix.components.metrics.MozillaProductDetector.MozillaProducts import org.mozilla.fenix.ext.settings import java.util.Locale import java.util.UUID.randomUUID diff --git a/app/src/main/java/org/mozilla/fenix/components/searchengine/CustomSearchEngineStore.kt b/app/src/main/java/org/mozilla/fenix/components/searchengine/CustomSearchEngineStore.kt index 93fd030e1..a5fbf5ad4 100644 --- a/app/src/main/java/org/mozilla/fenix/components/searchengine/CustomSearchEngineStore.kt +++ b/app/src/main/java/org/mozilla/fenix/components/searchengine/CustomSearchEngineStore.kt @@ -15,7 +15,6 @@ import mozilla.components.browser.search.provider.SearchEngineProvider import mozilla.components.support.ktx.android.content.PreferencesHolder import mozilla.components.support.ktx.android.content.stringSetPreference import org.mozilla.fenix.ext.components -import java.lang.Exception /** * SearchEngineProvider implementation to load user entered custom search engines. diff --git a/app/src/main/java/org/mozilla/fenix/components/searchengine/SearchEngineWriter.kt b/app/src/main/java/org/mozilla/fenix/components/searchengine/SearchEngineWriter.kt index 048acfa38..7366942e8 100644 --- a/app/src/main/java/org/mozilla/fenix/components/searchengine/SearchEngineWriter.kt +++ b/app/src/main/java/org/mozilla/fenix/components/searchengine/SearchEngineWriter.kt @@ -5,8 +5,10 @@ package org.mozilla.fenix.components.searchengine import android.graphics.Bitmap +import android.util.Base64 import android.util.Log import org.w3c.dom.Document +import java.io.ByteArrayOutputStream import java.io.StringWriter import javax.xml.parsers.DocumentBuilderFactory import javax.xml.parsers.ParserConfigurationException @@ -16,8 +18,6 @@ import javax.xml.transform.TransformerException import javax.xml.transform.TransformerFactory import javax.xml.transform.dom.DOMSource import javax.xml.transform.stream.StreamResult -import android.util.Base64 -import java.io.ByteArrayOutputStream private const val BITMAP_COMPRESS_QUALITY = 100 private fun Bitmap.toBase64(): String { diff --git a/app/src/main/java/org/mozilla/fenix/components/toolbar/DefaultToolbarMenu.kt b/app/src/main/java/org/mozilla/fenix/components/toolbar/DefaultToolbarMenu.kt index 525d97452..2a9fd99bf 100644 --- a/app/src/main/java/org/mozilla/fenix/components/toolbar/DefaultToolbarMenu.kt +++ b/app/src/main/java/org/mozilla/fenix/components/toolbar/DefaultToolbarMenu.kt @@ -22,6 +22,7 @@ import mozilla.components.browser.menu.item.BrowserMenuItemToolbar import mozilla.components.browser.session.Session import mozilla.components.browser.session.SessionManager import mozilla.components.concept.storage.BookmarksStorage +import mozilla.components.support.ktx.android.content.getColorFromAttr import org.mozilla.fenix.Config import org.mozilla.fenix.HomeActivity import org.mozilla.fenix.R @@ -29,7 +30,6 @@ import org.mozilla.fenix.ReleaseChannel import org.mozilla.fenix.browser.browsingmode.BrowsingMode import org.mozilla.fenix.ext.asActivity import org.mozilla.fenix.ext.components -import org.mozilla.fenix.ext.getColorFromAttr import org.mozilla.fenix.theme.ThemeManager import org.mozilla.fenix.utils.Settings diff --git a/app/src/main/java/org/mozilla/fenix/ext/Context.kt b/app/src/main/java/org/mozilla/fenix/ext/Context.kt index 921a1a257..7dd2c93f8 100644 --- a/app/src/main/java/org/mozilla/fenix/ext/Context.kt +++ b/app/src/main/java/org/mozilla/fenix/ext/Context.kt @@ -15,14 +15,11 @@ import android.content.Intent.FLAG_ACTIVITY_NEW_TASK import android.view.ContextThemeWrapper import android.view.View import android.view.ViewGroup -import androidx.annotation.AttrRes -import androidx.annotation.ColorInt import androidx.annotation.StringRes import androidx.fragment.app.FragmentActivity import mozilla.components.browser.search.SearchEngineManager import mozilla.components.support.base.log.Log import mozilla.components.support.base.log.Log.Priority.WARN -import mozilla.components.support.ktx.android.content.getColorFromAttr import org.mozilla.fenix.BuildConfig import org.mozilla.fenix.Config import org.mozilla.fenix.FenixApplication @@ -101,11 +98,5 @@ fun Context.share(text: String, subject: String = ""): Boolean { fun Context.getRootView(): View? = asActivity()?.window?.decorView?.findViewById(android.R.id.content) as? ViewGroup -/** - * Returns the color int corresponding to the attribute. - */ -@ColorInt -fun Context.getColorFromAttr(@AttrRes attr: Int) = getColorFromAttr(attr) - fun Context.settings(isCrashReportEnabledInBuild: Boolean = BuildConfig.CRASH_REPORTING && Config.channel.isReleased) = Settings.getInstance(this, isCrashReportEnabledInBuild) diff --git a/app/src/main/java/org/mozilla/fenix/ext/Fragment.kt b/app/src/main/java/org/mozilla/fenix/ext/Fragment.kt index d27000e01..e8e920b37 100644 --- a/app/src/main/java/org/mozilla/fenix/ext/Fragment.kt +++ b/app/src/main/java/org/mozilla/fenix/ext/Fragment.kt @@ -12,7 +12,6 @@ import androidx.navigation.NavDirections import androidx.navigation.NavOptions import androidx.navigation.Navigator import androidx.navigation.fragment.NavHostFragment.findNavController -import kotlinx.android.synthetic.main.fragment_home.* import org.mozilla.fenix.HomeActivity import org.mozilla.fenix.components.Components diff --git a/app/src/main/java/org/mozilla/fenix/ext/Resources.kt b/app/src/main/java/org/mozilla/fenix/ext/Resources.kt index 496c0e98a..ccfe19c4b 100644 --- a/app/src/main/java/org/mozilla/fenix/ext/Resources.kt +++ b/app/src/main/java/org/mozilla/fenix/ext/Resources.kt @@ -12,8 +12,6 @@ import android.text.SpannableString import android.text.Spanned.SPAN_EXCLUSIVE_EXCLUSIVE import androidx.annotation.StringRes import java.util.Formatter -import kotlin.collections.ArrayList -import kotlin.collections.HashMap // Credit to Michael Spitsin https://medium.com/@programmerr47/working-with-spans-in-android-ca4ab1327bc4 @Suppress("SpreadOperator") diff --git a/app/src/main/java/org/mozilla/fenix/home/HomeMenu.kt b/app/src/main/java/org/mozilla/fenix/home/HomeMenu.kt index 51484de68..e41dad3ec 100644 --- a/app/src/main/java/org/mozilla/fenix/home/HomeMenu.kt +++ b/app/src/main/java/org/mozilla/fenix/home/HomeMenu.kt @@ -12,9 +12,9 @@ import mozilla.components.browser.menu.item.BrowserMenuCategory import mozilla.components.browser.menu.item.BrowserMenuDivider import mozilla.components.browser.menu.item.BrowserMenuHighlightableItem import mozilla.components.browser.menu.item.BrowserMenuImageText +import mozilla.components.support.ktx.android.content.getColorFromAttr import org.mozilla.fenix.R import org.mozilla.fenix.ext.components -import org.mozilla.fenix.ext.getColorFromAttr import org.mozilla.fenix.theme.ThemeManager import org.mozilla.fenix.utils.Settings import org.mozilla.fenix.whatsnew.WhatsNew diff --git a/app/src/main/java/org/mozilla/fenix/home/PrivateBrowsingButtonView.kt b/app/src/main/java/org/mozilla/fenix/home/PrivateBrowsingButtonView.kt index 7a148e2c0..fc05d7987 100644 --- a/app/src/main/java/org/mozilla/fenix/home/PrivateBrowsingButtonView.kt +++ b/app/src/main/java/org/mozilla/fenix/home/PrivateBrowsingButtonView.kt @@ -6,9 +6,9 @@ package org.mozilla.fenix.home import android.view.View import androidx.annotation.StringRes +import org.mozilla.fenix.R import org.mozilla.fenix.browser.browsingmode.BrowsingMode import org.mozilla.fenix.browser.browsingmode.BrowsingModeManager -import org.mozilla.fenix.R /** * Sets up the private browsing toggle button on the [HomeFragment]. diff --git a/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SwipeToDeleteCallback.kt b/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SwipeToDeleteCallback.kt index e41ea5871..1b33e4ebe 100644 --- a/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SwipeToDeleteCallback.kt +++ b/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SwipeToDeleteCallback.kt @@ -10,8 +10,8 @@ import android.graphics.drawable.Drawable import androidx.appcompat.content.res.AppCompatResources import androidx.recyclerview.widget.ItemTouchHelper import androidx.recyclerview.widget.RecyclerView +import mozilla.components.support.ktx.android.content.getColorFromAttr import org.mozilla.fenix.R -import org.mozilla.fenix.ext.getColorFromAttr import org.mozilla.fenix.home.sessioncontrol.viewholders.TabInCollectionViewHolder import org.mozilla.fenix.home.sessioncontrol.viewholders.TabViewHolder diff --git a/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/CollectionViewHolder.kt b/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/CollectionViewHolder.kt index e556c55e1..e5afaeddb 100644 --- a/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/CollectionViewHolder.kt +++ b/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/CollectionViewHolder.kt @@ -17,11 +17,11 @@ import mozilla.components.browser.menu.BrowserMenuBuilder import mozilla.components.browser.menu.item.SimpleBrowserMenuItem import mozilla.components.feature.tab.collections.TabCollection import org.mozilla.fenix.R -import org.mozilla.fenix.theme.ThemeManager import org.mozilla.fenix.components.description import org.mozilla.fenix.ext.getIconColor import org.mozilla.fenix.ext.increaseTapArea import org.mozilla.fenix.home.sessioncontrol.CollectionInteractor +import org.mozilla.fenix.theme.ThemeManager class CollectionViewHolder( val view: View, diff --git a/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/NoContentMessageWithActionViewHolder.kt b/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/NoContentMessageWithActionViewHolder.kt index 9d32ac83e..d84393010 100644 --- a/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/NoContentMessageWithActionViewHolder.kt +++ b/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/NoContentMessageWithActionViewHolder.kt @@ -8,9 +8,7 @@ import android.view.View import androidx.annotation.DrawableRes import androidx.annotation.StringRes import androidx.core.view.isVisible -import kotlinx.android.synthetic.main.no_content_message_with_action.view.button_icon -import kotlinx.android.synthetic.main.no_content_message_with_action.view.button_layout -import kotlinx.android.synthetic.main.no_content_message_with_action.view.button_text +import kotlinx.android.synthetic.main.no_content_message_with_action.view.* import org.mozilla.fenix.R class NoContentMessageWithActionViewHolder( diff --git a/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/TabInCollectionViewHolder.kt b/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/TabInCollectionViewHolder.kt index 8fe9e0c33..0fd2808be 100644 --- a/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/TabInCollectionViewHolder.kt +++ b/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/TabInCollectionViewHolder.kt @@ -12,10 +12,10 @@ import androidx.recyclerview.widget.RecyclerView import kotlinx.android.extensions.LayoutContainer import kotlinx.android.synthetic.main.tab_in_collection.* import mozilla.components.feature.tab.collections.TabCollection +import mozilla.components.support.ktx.android.content.getColorFromAttr import mozilla.components.support.ktx.android.util.dpToFloat import org.mozilla.fenix.R import org.mozilla.fenix.ext.components -import org.mozilla.fenix.ext.getColorFromAttr import org.mozilla.fenix.ext.increaseTapArea import org.mozilla.fenix.ext.loadIntoView import org.mozilla.fenix.ext.toShortUrl diff --git a/app/src/main/java/org/mozilla/fenix/library/LibraryPageView.kt b/app/src/main/java/org/mozilla/fenix/library/LibraryPageView.kt index 42dcdb322..3f5eecfb7 100644 --- a/app/src/main/java/org/mozilla/fenix/library/LibraryPageView.kt +++ b/app/src/main/java/org/mozilla/fenix/library/LibraryPageView.kt @@ -10,9 +10,9 @@ import androidx.appcompat.widget.Toolbar import androidx.core.content.ContextCompat import androidx.recyclerview.widget.RecyclerView import kotlinx.android.extensions.LayoutContainer +import mozilla.components.support.ktx.android.content.getColorFromAttr import org.mozilla.fenix.R import org.mozilla.fenix.ext.asActivity -import org.mozilla.fenix.ext.getColorFromAttr import org.mozilla.fenix.ext.setToolbarColors open class LibraryPageView( diff --git a/app/src/main/java/org/mozilla/fenix/library/bookmarks/BookmarkItemMenu.kt b/app/src/main/java/org/mozilla/fenix/library/bookmarks/BookmarkItemMenu.kt index ba6f2c8c9..7473ef740 100644 --- a/app/src/main/java/org/mozilla/fenix/library/bookmarks/BookmarkItemMenu.kt +++ b/app/src/main/java/org/mozilla/fenix/library/bookmarks/BookmarkItemMenu.kt @@ -10,8 +10,8 @@ import mozilla.components.browser.menu.item.SimpleBrowserMenuItem import mozilla.components.concept.storage.BookmarkNode import mozilla.components.concept.storage.BookmarkNodeType import org.mozilla.fenix.R -import org.mozilla.fenix.theme.ThemeManager import org.mozilla.fenix.library.LibraryItemMenu +import org.mozilla.fenix.theme.ThemeManager class BookmarkItemMenu( private val context: Context, diff --git a/app/src/main/java/org/mozilla/fenix/library/bookmarks/edit/EditBookmarkFragment.kt b/app/src/main/java/org/mozilla/fenix/library/bookmarks/edit/EditBookmarkFragment.kt index d633141bd..56ac535b3 100644 --- a/app/src/main/java/org/mozilla/fenix/library/bookmarks/edit/EditBookmarkFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/library/bookmarks/edit/EditBookmarkFragment.kt @@ -20,11 +20,7 @@ import androidx.lifecycle.lifecycleScope import androidx.navigation.Navigation import androidx.navigation.fragment.findNavController import androidx.navigation.fragment.navArgs -import kotlinx.android.synthetic.main.fragment_edit_bookmark.bookmarkNameEdit -import kotlinx.android.synthetic.main.fragment_edit_bookmark.bookmarkParentFolderSelector -import kotlinx.android.synthetic.main.fragment_edit_bookmark.bookmarkUrlEdit -import kotlinx.android.synthetic.main.fragment_edit_bookmark.bookmarkUrlLabel -import kotlinx.android.synthetic.main.fragment_edit_bookmark.progress_bar_bookmark +import kotlinx.android.synthetic.main.fragment_edit_bookmark.* import kotlinx.coroutines.Dispatchers.IO import kotlinx.coroutines.Dispatchers.Main import kotlinx.coroutines.launch diff --git a/app/src/main/java/org/mozilla/fenix/library/bookmarks/selectfolder/SelectBookmarkFolderAdapter.kt b/app/src/main/java/org/mozilla/fenix/library/bookmarks/selectfolder/SelectBookmarkFolderAdapter.kt index e6ae7c045..ad9aca6e9 100644 --- a/app/src/main/java/org/mozilla/fenix/library/bookmarks/selectfolder/SelectBookmarkFolderAdapter.kt +++ b/app/src/main/java/org/mozilla/fenix/library/bookmarks/selectfolder/SelectBookmarkFolderAdapter.kt @@ -6,11 +6,11 @@ package org.mozilla.fenix.library.bookmarks.selectfolder import android.view.View import android.view.ViewGroup +import androidx.appcompat.content.res.AppCompatResources import androidx.core.content.ContextCompat import androidx.recyclerview.widget.DiffUtil import androidx.recyclerview.widget.ListAdapter import androidx.recyclerview.widget.RecyclerView -import androidx.appcompat.content.res.AppCompatResources import kotlinx.android.extensions.LayoutContainer import mozilla.components.concept.storage.BookmarkNode import mozilla.components.concept.storage.BookmarkNodeType diff --git a/app/src/main/java/org/mozilla/fenix/library/bookmarks/viewholders/BookmarkFolderViewHolder.kt b/app/src/main/java/org/mozilla/fenix/library/bookmarks/viewholders/BookmarkFolderViewHolder.kt index de1057890..2973c243a 100644 --- a/app/src/main/java/org/mozilla/fenix/library/bookmarks/viewholders/BookmarkFolderViewHolder.kt +++ b/app/src/main/java/org/mozilla/fenix/library/bookmarks/viewholders/BookmarkFolderViewHolder.kt @@ -5,8 +5,8 @@ package org.mozilla.fenix.library.bookmarks.viewholders import android.view.View -import androidx.core.content.ContextCompat import androidx.appcompat.content.res.AppCompatResources +import androidx.core.content.ContextCompat import mozilla.components.concept.storage.BookmarkNode import org.mozilla.fenix.R import org.mozilla.fenix.ext.hideAndDisable diff --git a/app/src/main/java/org/mozilla/fenix/library/history/HistoryItemMenu.kt b/app/src/main/java/org/mozilla/fenix/library/history/HistoryItemMenu.kt index 8d243aed2..aeb0489bb 100644 --- a/app/src/main/java/org/mozilla/fenix/library/history/HistoryItemMenu.kt +++ b/app/src/main/java/org/mozilla/fenix/library/history/HistoryItemMenu.kt @@ -8,8 +8,8 @@ import android.content.Context import mozilla.components.browser.menu.BrowserMenuBuilder import mozilla.components.browser.menu.item.SimpleBrowserMenuItem import org.mozilla.fenix.R -import org.mozilla.fenix.theme.ThemeManager import org.mozilla.fenix.library.LibraryItemMenu +import org.mozilla.fenix.theme.ThemeManager class HistoryItemMenu( private val context: Context, diff --git a/app/src/main/java/org/mozilla/fenix/library/history/HistoryViewModel.kt b/app/src/main/java/org/mozilla/fenix/library/history/HistoryViewModel.kt index 37e9bb3d9..8c758d780 100644 --- a/app/src/main/java/org/mozilla/fenix/library/history/HistoryViewModel.kt +++ b/app/src/main/java/org/mozilla/fenix/library/history/HistoryViewModel.kt @@ -7,8 +7,8 @@ package org.mozilla.fenix.library.history import androidx.lifecycle.LiveData import androidx.lifecycle.MutableLiveData import androidx.lifecycle.ViewModel -import androidx.paging.PagedList import androidx.paging.LivePagedListBuilder +import androidx.paging.PagedList import org.mozilla.fenix.components.history.PagedHistoryProvider class HistoryViewModel(historyProvider: PagedHistoryProvider) : ViewModel() { diff --git a/app/src/main/java/org/mozilla/fenix/library/history/viewholders/HistoryListItemViewHolder.kt b/app/src/main/java/org/mozilla/fenix/library/history/viewholders/HistoryListItemViewHolder.kt index 2ad5894aa..526144d1f 100644 --- a/app/src/main/java/org/mozilla/fenix/library/history/viewholders/HistoryListItemViewHolder.kt +++ b/app/src/main/java/org/mozilla/fenix/library/history/viewholders/HistoryListItemViewHolder.kt @@ -12,11 +12,11 @@ import org.mozilla.fenix.R import org.mozilla.fenix.ext.hideAndDisable import org.mozilla.fenix.ext.showAndEnable import org.mozilla.fenix.library.SelectionHolder +import org.mozilla.fenix.library.history.HistoryFragmentState import org.mozilla.fenix.library.history.HistoryInteractor import org.mozilla.fenix.library.history.HistoryItem import org.mozilla.fenix.library.history.HistoryItemMenu import org.mozilla.fenix.library.history.HistoryItemTimeGroup -import org.mozilla.fenix.library.history.HistoryFragmentState class HistoryListItemViewHolder( view: View, diff --git a/app/src/main/java/org/mozilla/fenix/onboarding/FenixOnboarding.kt b/app/src/main/java/org/mozilla/fenix/onboarding/FenixOnboarding.kt index 8e2047ebc..2ee112163 100644 --- a/app/src/main/java/org/mozilla/fenix/onboarding/FenixOnboarding.kt +++ b/app/src/main/java/org/mozilla/fenix/onboarding/FenixOnboarding.kt @@ -7,8 +7,8 @@ package org.mozilla.fenix.onboarding import android.content.Context import android.content.SharedPreferences import androidx.core.content.edit -import org.mozilla.fenix.ext.components import org.mozilla.fenix.components.metrics.Event +import org.mozilla.fenix.ext.components class FenixOnboarding(context: Context) { private val metrics = context.components.analytics.metrics diff --git a/app/src/main/java/org/mozilla/fenix/perf/StartupTaskManager.kt b/app/src/main/java/org/mozilla/fenix/perf/StartupTaskManager.kt index 271edfc67..58d7eb203 100644 --- a/app/src/main/java/org/mozilla/fenix/perf/StartupTaskManager.kt +++ b/app/src/main/java/org/mozilla/fenix/perf/StartupTaskManager.kt @@ -5,7 +5,6 @@ package org.mozilla.fenix.utils import org.mozilla.gecko.util.ThreadUtils -import java.lang.IllegalStateException typealias StartupTask = () -> Unit diff --git a/app/src/main/java/org/mozilla/fenix/search/awesomebar/ShortcutsSuggestionProvider.kt b/app/src/main/java/org/mozilla/fenix/search/awesomebar/ShortcutsSuggestionProvider.kt index 2e598bf97..a81f8bd82 100644 --- a/app/src/main/java/org/mozilla/fenix/search/awesomebar/ShortcutsSuggestionProvider.kt +++ b/app/src/main/java/org/mozilla/fenix/search/awesomebar/ShortcutsSuggestionProvider.kt @@ -5,8 +5,8 @@ package org.mozilla.fenix.search.awesomebar import android.content.Context -import androidx.core.graphics.drawable.toBitmap import androidx.appcompat.content.res.AppCompatResources +import androidx.core.graphics.drawable.toBitmap import mozilla.components.browser.search.SearchEngine import mozilla.components.concept.awesomebar.AwesomeBar import org.mozilla.fenix.R diff --git a/app/src/main/java/org/mozilla/fenix/search/toolbar/ToolbarView.kt b/app/src/main/java/org/mozilla/fenix/search/toolbar/ToolbarView.kt index 683fa4a81..0d1504a6a 100644 --- a/app/src/main/java/org/mozilla/fenix/search/toolbar/ToolbarView.kt +++ b/app/src/main/java/org/mozilla/fenix/search/toolbar/ToolbarView.kt @@ -24,10 +24,10 @@ import mozilla.components.browser.toolbar.BrowserToolbar import mozilla.components.browser.toolbar.behavior.BrowserToolbarBottomBehavior import mozilla.components.concept.storage.HistoryStorage import mozilla.components.feature.toolbar.ToolbarAutocompleteFeature +import mozilla.components.support.ktx.android.content.getColorFromAttr import mozilla.components.support.ktx.android.util.dpToPx import org.mozilla.fenix.FeatureFlags import org.mozilla.fenix.R -import org.mozilla.fenix.ext.getColorFromAttr import org.mozilla.fenix.ext.settings import org.mozilla.fenix.search.SearchFragmentState import org.mozilla.fenix.theme.ThemeManager diff --git a/app/src/main/java/org/mozilla/fenix/settings/SupportUtils.kt b/app/src/main/java/org/mozilla/fenix/settings/SupportUtils.kt index df83bd05f..c34ddbc7b 100644 --- a/app/src/main/java/org/mozilla/fenix/settings/SupportUtils.kt +++ b/app/src/main/java/org/mozilla/fenix/settings/SupportUtils.kt @@ -9,11 +9,11 @@ import android.content.Intent import androidx.browser.customtabs.CustomTabsIntent import androidx.core.net.toUri import mozilla.components.support.ktx.android.content.appVersionName +import mozilla.components.support.ktx.android.content.getColorFromAttr import org.mozilla.fenix.BuildConfig import org.mozilla.fenix.Config import org.mozilla.fenix.IntentReceiverActivity import org.mozilla.fenix.R -import org.mozilla.fenix.ext.getColorFromAttr import org.mozilla.fenix.settings.account.AuthIntentReceiverActivity import java.io.UnsupportedEncodingException import java.net.URLEncoder diff --git a/app/src/main/java/org/mozilla/fenix/settings/advanced/LocaleAdapter.kt b/app/src/main/java/org/mozilla/fenix/settings/advanced/LocaleAdapter.kt index 1965bb48f..4020893ed 100644 --- a/app/src/main/java/org/mozilla/fenix/settings/advanced/LocaleAdapter.kt +++ b/app/src/main/java/org/mozilla/fenix/settings/advanced/LocaleAdapter.kt @@ -11,9 +11,7 @@ import androidx.annotation.VisibleForTesting import androidx.core.view.isVisible import androidx.recyclerview.widget.DiffUtil import androidx.recyclerview.widget.RecyclerView -import kotlinx.android.synthetic.main.locale_settings_item.view.locale_selected_icon -import kotlinx.android.synthetic.main.locale_settings_item.view.locale_subtitle_text -import kotlinx.android.synthetic.main.locale_settings_item.view.locale_title_text +import kotlinx.android.synthetic.main.locale_settings_item.view.* import mozilla.components.support.locale.LocaleManager import org.mozilla.fenix.R import java.util.Locale diff --git a/app/src/main/java/org/mozilla/fenix/settings/advanced/LocaleSettingsFragment.kt b/app/src/main/java/org/mozilla/fenix/settings/advanced/LocaleSettingsFragment.kt index 1448c3f37..37ab0f053 100644 --- a/app/src/main/java/org/mozilla/fenix/settings/advanced/LocaleSettingsFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/settings/advanced/LocaleSettingsFragment.kt @@ -9,7 +9,7 @@ import android.view.LayoutInflater import android.view.View import android.view.ViewGroup import androidx.fragment.app.Fragment -import kotlinx.android.synthetic.main.fragment_locale_settings.view.locale_container +import kotlinx.android.synthetic.main.fragment_locale_settings.view.* import kotlinx.coroutines.ExperimentalCoroutinesApi import mozilla.components.lib.state.ext.consumeFrom import mozilla.components.support.ktx.android.view.hideKeyboard diff --git a/app/src/main/java/org/mozilla/fenix/settings/advanced/LocaleSettingsView.kt b/app/src/main/java/org/mozilla/fenix/settings/advanced/LocaleSettingsView.kt index 0a204f5ee..17e37cc56 100644 --- a/app/src/main/java/org/mozilla/fenix/settings/advanced/LocaleSettingsView.kt +++ b/app/src/main/java/org/mozilla/fenix/settings/advanced/LocaleSettingsView.kt @@ -9,8 +9,7 @@ import android.view.View import android.view.ViewGroup import android.widget.SearchView import androidx.recyclerview.widget.LinearLayoutManager -import kotlinx.android.synthetic.main.component_locale_settings.view.locale_list -import kotlinx.android.synthetic.main.component_locale_settings.view.toolbar_container +import kotlinx.android.synthetic.main.component_locale_settings.view.* import org.mozilla.fenix.R import java.util.Locale diff --git a/app/src/main/java/org/mozilla/fenix/settings/search/AddSearchEngineFragment.kt b/app/src/main/java/org/mozilla/fenix/settings/search/AddSearchEngineFragment.kt index 525126695..4efdf59ad 100644 --- a/app/src/main/java/org/mozilla/fenix/settings/search/AddSearchEngineFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/settings/search/AddSearchEngineFragment.kt @@ -7,7 +7,6 @@ package org.mozilla.fenix.settings.search import android.content.res.Resources import android.graphics.drawable.BitmapDrawable import android.os.Bundle -import androidx.fragment.app.Fragment import android.view.LayoutInflater import android.view.Menu import android.view.MenuInflater @@ -17,6 +16,7 @@ import android.view.ViewGroup import android.widget.CompoundButton import androidx.appcompat.app.AppCompatActivity import androidx.constraintlayout.widget.ConstraintLayout +import androidx.fragment.app.Fragment import androidx.lifecycle.lifecycleScope import androidx.navigation.fragment.findNavController import kotlinx.android.synthetic.main.custom_search_engine.* diff --git a/app/src/main/java/org/mozilla/fenix/settings/search/SearchEngineFragment.kt b/app/src/main/java/org/mozilla/fenix/settings/search/SearchEngineFragment.kt index 75b0b337c..7893054c9 100644 --- a/app/src/main/java/org/mozilla/fenix/settings/search/SearchEngineFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/settings/search/SearchEngineFragment.kt @@ -6,8 +6,8 @@ package org.mozilla.fenix.settings.search import android.os.Bundle import androidx.navigation.fragment.findNavController -import androidx.preference.Preference import androidx.preference.CheckBoxPreference +import androidx.preference.Preference import androidx.preference.PreferenceFragmentCompat import androidx.preference.SwitchPreference import org.mozilla.fenix.R diff --git a/app/src/main/java/org/mozilla/fenix/share/ShareFragment.kt b/app/src/main/java/org/mozilla/fenix/share/ShareFragment.kt index 552e57f26..9dc1d93b6 100644 --- a/app/src/main/java/org/mozilla/fenix/share/ShareFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/share/ShareFragment.kt @@ -16,11 +16,7 @@ import androidx.lifecycle.lifecycleScope import androidx.lifecycle.observe import androidx.navigation.fragment.findNavController import androidx.navigation.fragment.navArgs -import kotlinx.android.synthetic.main.fragment_share.view.appsShareLayout -import kotlinx.android.synthetic.main.fragment_share.view.closeSharingContent -import kotlinx.android.synthetic.main.fragment_share.view.closeSharingScrim -import kotlinx.android.synthetic.main.fragment_share.view.devicesShareLayout -import kotlinx.android.synthetic.main.fragment_share.view.shareWrapper +import kotlinx.android.synthetic.main.fragment_share.view.* import mozilla.components.browser.state.action.ContentAction import mozilla.components.browser.state.selector.findTabOrCustomTab import mozilla.components.concept.engine.prompt.PromptRequest diff --git a/app/src/main/java/org/mozilla/fenix/share/ShareToAppsView.kt b/app/src/main/java/org/mozilla/fenix/share/ShareToAppsView.kt index aa70aac28..415fa0ad5 100644 --- a/app/src/main/java/org/mozilla/fenix/share/ShareToAppsView.kt +++ b/app/src/main/java/org/mozilla/fenix/share/ShareToAppsView.kt @@ -8,10 +8,7 @@ import android.view.LayoutInflater import android.view.View import android.view.ViewGroup import kotlinx.android.extensions.LayoutContainer -import kotlinx.android.synthetic.main.share_to_apps.appsList -import kotlinx.android.synthetic.main.share_to_apps.progressBar -import kotlinx.android.synthetic.main.share_to_apps.recentAppsContainer -import kotlinx.android.synthetic.main.share_to_apps.recentAppsList +import kotlinx.android.synthetic.main.share_to_apps.* import org.mozilla.fenix.R import org.mozilla.fenix.share.listadapters.AppShareAdapter import org.mozilla.fenix.share.listadapters.AppShareOption diff --git a/app/src/main/java/org/mozilla/fenix/theme/ThemeManager.kt b/app/src/main/java/org/mozilla/fenix/theme/ThemeManager.kt index bea000346..5f2400131 100644 --- a/app/src/main/java/org/mozilla/fenix/theme/ThemeManager.kt +++ b/app/src/main/java/org/mozilla/fenix/theme/ThemeManager.kt @@ -15,10 +15,10 @@ import android.util.TypedValue import android.view.View import android.view.Window import androidx.annotation.StyleRes +import mozilla.components.support.ktx.android.content.getColorFromAttr import org.mozilla.fenix.HomeActivity import org.mozilla.fenix.R import org.mozilla.fenix.browser.browsingmode.BrowsingMode -import org.mozilla.fenix.ext.getColorFromAttr abstract class ThemeManager { diff --git a/app/src/main/java/org/mozilla/fenix/utils/ClearableEditText.kt b/app/src/main/java/org/mozilla/fenix/utils/ClearableEditText.kt index fcf35d13c..aad4bf7ce 100644 --- a/app/src/main/java/org/mozilla/fenix/utils/ClearableEditText.kt +++ b/app/src/main/java/org/mozilla/fenix/utils/ClearableEditText.kt @@ -13,9 +13,9 @@ import androidx.appcompat.content.res.AppCompatResources import androidx.appcompat.widget.AppCompatEditText import androidx.core.graphics.BlendModeColorFilterCompat.createBlendModeColorFilterCompat import androidx.core.graphics.BlendModeCompat.SRC_IN +import mozilla.components.support.ktx.android.content.getColorFromAttr import mozilla.components.support.ktx.android.view.putCompoundDrawablesRelativeWithIntrinsicBounds import org.mozilla.fenix.R -import org.mozilla.fenix.ext.getColorFromAttr /** * An [AppCompatEditText] that shows a clear button to the user.