parent
ece0e30655
commit
dbe29ebbda
|
@ -561,6 +561,17 @@ bookmarks_management:
|
||||||
notification_emails:
|
notification_emails:
|
||||||
- fenix-core@mozilla.com
|
- fenix-core@mozilla.com
|
||||||
expires: "2020-03-01"
|
expires: "2020-03-01"
|
||||||
|
folder_remove:
|
||||||
|
type: event
|
||||||
|
description: >
|
||||||
|
A user removed a bookmark folder.
|
||||||
|
bugs:
|
||||||
|
- 3174
|
||||||
|
data_reviews:
|
||||||
|
- https://github.com/mozilla-mobile/fenix/pull/3724
|
||||||
|
notification_emails:
|
||||||
|
- fenix-core@mozilla.com
|
||||||
|
expires: "2020-03-01"
|
||||||
|
|
||||||
custom_tab:
|
custom_tab:
|
||||||
closed:
|
closed:
|
||||||
|
|
|
@ -154,6 +154,9 @@ private val Event.wrapper
|
||||||
is Event.AddBookmarkFolder -> EventWrapper<NoExtraKeys>(
|
is Event.AddBookmarkFolder -> EventWrapper<NoExtraKeys>(
|
||||||
{ BookmarksManagement.folderAdd.record(it) }
|
{ BookmarksManagement.folderAdd.record(it) }
|
||||||
)
|
)
|
||||||
|
is Event.RemoveBookmarkFolder -> EventWrapper<NoExtraKeys>(
|
||||||
|
{ BookmarksManagement.folderRemove.record(it) }
|
||||||
|
)
|
||||||
is Event.CustomTabsMenuOpened -> EventWrapper<NoExtraKeys>(
|
is Event.CustomTabsMenuOpened -> EventWrapper<NoExtraKeys>(
|
||||||
{ CustomTab.menu.record(it) }
|
{ CustomTab.menu.record(it) }
|
||||||
)
|
)
|
||||||
|
|
|
@ -65,6 +65,7 @@ sealed class Event {
|
||||||
object ShareBookmark : Event()
|
object ShareBookmark : Event()
|
||||||
object CopyBookmark : Event()
|
object CopyBookmark : Event()
|
||||||
object AddBookmarkFolder : Event()
|
object AddBookmarkFolder : Event()
|
||||||
|
object RemoveBookmarkFolder : Event()
|
||||||
object RemoveBookmarks : Event()
|
object RemoveBookmarks : Event()
|
||||||
object QuickActionSheetOpened : Event()
|
object QuickActionSheetOpened : Event()
|
||||||
object QuickActionSheetClosed : Event()
|
object QuickActionSheetClosed : Event()
|
||||||
|
|
|
@ -298,7 +298,11 @@ class BookmarkFragment : Fragment(), BackHandler, AccountObserver {
|
||||||
|
|
||||||
val deleteOperation: (suspend () -> Unit) = {
|
val deleteOperation: (suspend () -> Unit) = {
|
||||||
bookmarkStorage?.deleteNode(bookmarkNode.guid)
|
bookmarkStorage?.deleteNode(bookmarkNode.guid)
|
||||||
metrics()?.track(Event.RemoveBookmark)
|
when (bookmarkNode.type) {
|
||||||
|
BookmarkNodeType.FOLDER -> metrics()?.track(Event.RemoveBookmarkFolder)
|
||||||
|
BookmarkNodeType.ITEM -> metrics()?.track(Event.RemoveBookmark)
|
||||||
|
else -> { }
|
||||||
|
}
|
||||||
pendingBookmarkDeletionJob = null
|
pendingBookmarkDeletionJob = null
|
||||||
refreshBookmarks()
|
refreshBookmarks()
|
||||||
}
|
}
|
||||||
|
|
|
@ -435,6 +435,15 @@ tracking_protection</td>
|
||||||
<td></td>
|
<td></td>
|
||||||
<td>2020-03-01</td>
|
<td>2020-03-01</td>
|
||||||
</tr>
|
</tr>
|
||||||
|
|
||||||
|
<tr>
|
||||||
|
<td>folder_remove</td>
|
||||||
|
<td>event</td>
|
||||||
|
<td>A user removed a bookmark folder.</td>
|
||||||
|
<td> <a href="https://github.com/mozilla-mobile/fenix/pull/3724">link</a></td>
|
||||||
|
<td></td>
|
||||||
|
<td>2020-03-01</td>
|
||||||
|
</tr>
|
||||||
</table>
|
</table>
|
||||||
</pre>
|
</pre>
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue