From d8ef0722e341c544b4d38613585d75050d9b2cb8 Mon Sep 17 00:00:00 2001
From: Jeff Boek <jeff@jeffboek.com>
Date: Tue, 9 Jun 2020 09:08:21 -0700
Subject: [PATCH] For #11175 - Moves tab tray strings to be translated, fixes
 description of the fab string

---
 .../fenix/tabtray/TabTrayDialogFragment.kt       |  2 +-
 app/src/main/res/values/static_strings.xml       | 16 ----------------
 app/src/main/res/values/strings.xml              | 16 +++++++++++++++-
 3 files changed, 16 insertions(+), 18 deletions(-)

diff --git a/app/src/main/java/org/mozilla/fenix/tabtray/TabTrayDialogFragment.kt b/app/src/main/java/org/mozilla/fenix/tabtray/TabTrayDialogFragment.kt
index 2e463f738..b8eded202 100644
--- a/app/src/main/java/org/mozilla/fenix/tabtray/TabTrayDialogFragment.kt
+++ b/app/src/main/java/org/mozilla/fenix/tabtray/TabTrayDialogFragment.kt
@@ -39,7 +39,7 @@ import org.mozilla.fenix.ext.sessionsOfType
 import org.mozilla.fenix.utils.allowUndo
 import org.mozilla.fenix.components.TabCollectionStorage
 
-@SuppressWarnings("TooManyFunctions")
+@SuppressWarnings("TooManyFunctions", "LargeClass")
 class TabTrayDialogFragment : AppCompatDialogFragment(), TabTrayInteractor {
     private var tabsFeature: TabsFeature? = null
     private var _tabTrayView: TabTrayView? = null
diff --git a/app/src/main/res/values/static_strings.xml b/app/src/main/res/values/static_strings.xml
index 4fe788087..3c2ccfb7e 100644
--- a/app/src/main/res/values/static_strings.xml
+++ b/app/src/main/res/values/static_strings.xml
@@ -28,22 +28,6 @@
     <!-- Application Services abbreviation used in AboutFragment -->
     <string name="app_services_abbreviation" translatable="false">AS</string>
 
-    <!-- WIP: Tab Tray -->
-    <!-- Text shown as the title of the open tab tray -->
-    <string name="tab_tray_title" translatable="false">Open Tabs</string>
-    <!-- Text shown in the menu for saving tabs to a collection -->
-    <string name="tab_tray_menu_item_save" translatable="false">Save to collection</string>
-    <!-- Text shown in the menu for sharing all tabs -->
-    <string name="tab_tray_menu_item_share" translatable="false">Share all tabs</string>
-    <!-- Text shown in the menu for closing all tabs -->
-    <string name="tab_tray_menu_item_close" translatable="false">Close all tabs</string>
-    <!-- Shortcut action to open new tab -->
-    <string name="tab_tray_menu_open_new_tab" translatable="false">New tab</string>
-    <!-- Shortcut action to open the home screen -->
-    <string name="tab_tray_menu_home" translatable="false">Go home</string>
-    <!-- Shortcut action to toggle private mode -->
-    <string name="tab_tray_menu_toggle" translatable="false">Toggle tab mode</string>
-
     <!-- Label for the secret settings preference -->
     <string name="preferences_debug_settings">Secret Settings</string>
     <string name="preferences_debug_settings_enable_tab_tray">Use New Tab Tray</string>
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 5a7f3e53a..66b256dbb 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -444,8 +444,22 @@
     <string name="add_tab">Add tab</string>
     <!-- Content description (not visible, for screen readers etc.): Add tab button. Adds a news tab when pressed -->
     <string name="add_private_tab">Add private tab</string>
-    <!-- Content for FAB when looking at private tabs in the tab drawer -->
+    <!-- Text for the new tab button to indicate adding a new private tab in the tab -->
     <string name="tab_drawer_fab_content">Private</string>
+    <!-- Text shown as the title of the open tab tray -->
+    <string name="tab_tray_title">Open Tabs</string>
+    <!-- Text shown in the menu for saving tabs to a collection -->
+    <string name="tab_tray_menu_item_save">Save to collection</string>
+    <!-- Text shown in the menu for sharing all tabs -->
+    <string name="tab_tray_menu_item_share">Share all tabs</string>
+    <!-- Text shown in the menu for closing all tabs -->
+    <string name="tab_tray_menu_item_close">Close all tabs</string>
+    <!-- Shortcut action to open new tab -->
+    <string name="tab_tray_menu_open_new_tab">New tab</string>
+    <!-- Shortcut action to open the home screen -->
+    <string name="tab_tray_menu_home">Go home</string>
+    <!-- Shortcut action to toggle private mode -->
+    <string name="tab_tray_menu_toggle">Toggle tab mode</string>
     <!-- Content description (not visible, for screen readers etc.): Removes tab from collection button. Removes the selected tab from collection when pressed -->
     <string name="remove_tab_from_collection">Remove tab from collection</string>
     <!-- Content description (not visible, for screen readers etc.): Close tab button. Closes the current session when pressed -->