blallo
/
fenix
1
0
Fork 0
Code Releases Activity

For #9626: Delay cloning ConstraintSet to only when needed for updating.

master
mcarare 2020-05-27 14:54:39 +03:00 committed by Jeff Boek
parent d0e2d02b34
commit d706b085a9
1 changed files with 17 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
app/src/main/java/org/mozilla/fenix/collections/CollectionCreationView.kt
View File

@ -68,16 +68,6 @@ class CollectionCreationView(
transition.duration = TRANSITION_DURATION transition.duration = TRANSITION_DURATION
transition.excludeTarget(back_button, true) transition.excludeTarget(back_button, true)
selectTabsConstraints.clone(collection_constraint_layout)
selectCollectionConstraints.clone(
view.context,
R.layout.component_collection_creation_select_collection
)
nameCollectionConstraints.clone(
view.context,
R.layout.component_collection_creation_name_collection
)
view.bottom_bar_icon_button.apply { view.bottom_bar_icon_button.apply {
increaseTapArea(increaseButtonByDps) increaseTapArea(increaseButtonByDps)
} }
@ -160,9 +150,8 @@ class CollectionCreationView(
view.bottom_bar_icon_button.setOnClickListener { view.bottom_bar_icon_button.setOnClickListener {
interactor.close() interactor.close()
} }
selectTabsConstraints.clone(collection_constraint_layout)
val constraint = selectTabsConstraints selectTabsConstraints.applyTo(view.collection_constraint_layout)
constraint.applyTo(view.collection_constraint_layout)
collectionCreationTabListAdapter.updateData(state.tabs, state.selectedTabs) collectionCreationTabListAdapter.updateData(state.tabs, state.selectedTabs)
@ -224,8 +213,11 @@ class CollectionCreationView(
view.collection_constraint_layout, view.collection_constraint_layout,
transition transition
) )
val constraint = selectCollectionConstraints selectCollectionConstraints.clone(
constraint.applyTo(view.collection_constraint_layout) view.context,
R.layout.component_collection_creation_select_collection
)
selectCollectionConstraints.applyTo(view.collection_constraint_layout)
back_button.text = back_button.text =
view.context.getString(R.string.create_collection_select_collection) view.context.getString(R.string.create_collection_select_collection)
} }
@ -243,8 +235,11 @@ class CollectionCreationView(
} }
view.name_collection_edittext.showKeyboard() view.name_collection_edittext.showKeyboard()
val constraint = nameCollectionConstraints nameCollectionConstraints.clone(
constraint.applyTo(view.collection_constraint_layout) view.context,
R.layout.component_collection_creation_name_collection
)
nameCollectionConstraints.applyTo(view.collection_constraint_layout)
name_collection_edittext.setText( name_collection_edittext.setText(
view.context.getString( view.context.getString(
R.string.create_collection_default_name, R.string.create_collection_default_name,
@ -272,8 +267,11 @@ class CollectionCreationView(
collectionCreationTabListAdapter.updateData(tabs, tabs.toSet(), true) collectionCreationTabListAdapter.updateData(tabs, tabs.toSet(), true)
} }
} }
val constraint = nameCollectionConstraints nameCollectionConstraints.clone(
constraint.applyTo(view.collection_constraint_layout) view.context,
R.layout.component_collection_creation_name_collection
)
nameCollectionConstraints.applyTo(view.collection_constraint_layout)
name_collection_edittext.setText(state.selectedTabCollection?.title) name_collection_edittext.setText(state.selectedTabCollection?.title)
name_collection_edittext.setSelection(0, name_collection_edittext.text.length) name_collection_edittext.setSelection(0, name_collection_edittext.text.length)