From ce46a9674228904ff63ed64a8ca87c89f7a4b458 Mon Sep 17 00:00:00 2001 From: mcarare Date: Mon, 25 May 2020 15:16:45 +0300 Subject: [PATCH] For #10706: Update copy of deleting open tabs preference. --- .../ui/robots/SettingsSubMenuDeleteBrowsingDataOnQuitRobot.kt | 2 +- .../fenix/ui/robots/SettingsSubMenuDeleteBrowsingDataRobot.kt | 4 ++-- app/src/main/res/layout/fragment_delete_browsing_data.xml | 2 +- app/src/main/res/values/strings.xml | 2 +- .../main/res/xml/delete_browsing_data_quit_preferences.xml | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/app/src/androidTest/java/org/mozilla/fenix/ui/robots/SettingsSubMenuDeleteBrowsingDataOnQuitRobot.kt b/app/src/androidTest/java/org/mozilla/fenix/ui/robots/SettingsSubMenuDeleteBrowsingDataOnQuitRobot.kt index ddc265b00..7e2dfd5af 100644 --- a/app/src/androidTest/java/org/mozilla/fenix/ui/robots/SettingsSubMenuDeleteBrowsingDataOnQuitRobot.kt +++ b/app/src/androidTest/java/org/mozilla/fenix/ui/robots/SettingsSubMenuDeleteBrowsingDataOnQuitRobot.kt @@ -80,7 +80,7 @@ private fun assertDeleteBrowsingOnQuitButtonSwitchDefault() = onView(withResourc .check(matches(isChecked(false))) private fun assertAllTheCheckBoxesText() { - onView(withText(R.string.preferences_delete_browsing_data_tabs_title)) + onView(withText(R.string.preferences_delete_browsing_data_tabs_title_2)) .check(matches(withEffectiveVisibility(Visibility.VISIBLE))) onView(withText(R.string.preferences_delete_browsing_data_on_quit_browsing_history)) diff --git a/app/src/androidTest/java/org/mozilla/fenix/ui/robots/SettingsSubMenuDeleteBrowsingDataRobot.kt b/app/src/androidTest/java/org/mozilla/fenix/ui/robots/SettingsSubMenuDeleteBrowsingDataRobot.kt index 645ea2da7..32ab7c4f2 100644 --- a/app/src/androidTest/java/org/mozilla/fenix/ui/robots/SettingsSubMenuDeleteBrowsingDataRobot.kt +++ b/app/src/androidTest/java/org/mozilla/fenix/ui/robots/SettingsSubMenuDeleteBrowsingDataRobot.kt @@ -120,7 +120,7 @@ private fun assertCancelButtonInDialogBox() = private fun assertAllTheCheckBoxesText() { - onView(withText(R.string.preferences_delete_browsing_data_tabs_title)) + onView(withText(R.string.preferences_delete_browsing_data_tabs_title_2)) .check(matches(withEffectiveVisibility(Visibility.VISIBLE))) onView(withText("0 tabs")) @@ -149,7 +149,7 @@ private fun assertAllTheCheckBoxesText() { } private fun assertAllTheCheckBoxesChecked() { - onView(allOf(withId(R.id.checkbox), hasSibling(withText("Open Tabs")))).assertIsChecked(true) + onView(allOf(withId(R.id.checkbox), hasSibling(withText("Open tabs")))).assertIsChecked(true) onView(allOf(withId(R.id.checkbox), hasSibling(withText("Browsing history and site data")))).assertIsChecked(true) diff --git a/app/src/main/res/layout/fragment_delete_browsing_data.xml b/app/src/main/res/layout/fragment_delete_browsing_data.xml index ff3d4cbeb..5c5dd8b07 100644 --- a/app/src/main/res/layout/fragment_delete_browsing_data.xml +++ b/app/src/main/res/layout/fragment_delete_browsing_data.xml @@ -36,7 +36,7 @@ android:background="?android:attr/selectableItemBackground" android:clickable="true" android:focusable="true" - app:deleteBrowsingDataItemTitle="@string/preferences_delete_browsing_data_tabs_title" + app:deleteBrowsingDataItemTitle="@string/preferences_delete_browsing_data_tabs_title_2" app:deleteBrowsingDataItemSubtitle="@string/preferences_delete_browsing_data_tabs_subtitle" /> Delete browsing data - Open Tabs + Open tabs %d tabs diff --git a/app/src/main/res/xml/delete_browsing_data_quit_preferences.xml b/app/src/main/res/xml/delete_browsing_data_quit_preferences.xml index e16db8579..3e09f77b4 100644 --- a/app/src/main/res/xml/delete_browsing_data_quit_preferences.xml +++ b/app/src/main/res/xml/delete_browsing_data_quit_preferences.xml @@ -19,7 +19,7 @@ + android:title="@string/preferences_delete_browsing_data_tabs_title_2" />