From ccc7c70967bba75bc1bc57b5c37e4e15e1aac346 Mon Sep 17 00:00:00 2001 From: Christian Sadilek Date: Tue, 11 Jun 2019 15:09:12 -0400 Subject: [PATCH] For #3252: Reader mode appearance buttons are not visible in PB Co-authored-by: Jonathan Almeida Co-authored-by: Sawyer Blatz --- .../mozilla/fenix/browser/BrowserFragment.kt | 29 +++++++++++++++++++ .../color/readerview_private_button_color.xml | 8 +++++ .../color/readerview_private_radio_color.xml | 8 +++++ app/src/main/res/values/colors.xml | 1 + 4 files changed, 46 insertions(+) create mode 100644 app/src/main/res/color/readerview_private_button_color.xml create mode 100644 app/src/main/res/color/readerview_private_radio_color.xml diff --git a/app/src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt b/app/src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt index 11c5e5a39..55038ec56 100644 --- a/app/src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt @@ -13,8 +13,11 @@ import android.view.Gravity import android.view.LayoutInflater import android.view.View import android.view.ViewGroup +import android.widget.Button +import android.widget.RadioButton import androidx.appcompat.app.AppCompatActivity import androidx.coordinatorlayout.widget.CoordinatorLayout +import androidx.core.content.ContextCompat import androidx.core.content.getSystemService import androidx.core.net.toUri import androidx.fragment.app.Fragment @@ -356,6 +359,12 @@ class BrowserFragment : Fragment(), BackHandler, CoroutineScope { view.swipeRefresh.setOnChildScrollUpCallback { _, _ -> true } } + if ((activity as HomeActivity).browsingModeManager.isPrivate) { + // We need to update styles for private mode programmatically for now: + // https://github.com/mozilla-mobile/android-components/issues/3400 + themeReaderViewControlsForPrivateMode(view.readerViewControlsBar) + } + readerViewFeature.set( feature = ReaderViewFeature( requireContext(), @@ -399,6 +408,26 @@ class BrowserFragment : Fragment(), BackHandler, CoroutineScope { } } + private fun themeReaderViewControlsForPrivateMode(view: View) = with(view) { + listOf( + R.id.mozac_feature_readerview_font_size_decrease, + R.id.mozac_feature_readerview_font_size_increase + ).map { + findViewById