From ba6bb916e412c689080e2338ea51efc4e9a7f2f0 Mon Sep 17 00:00:00 2001 From: Arturo Mejia Date: Sat, 25 May 2019 10:58:51 -0400 Subject: [PATCH] Closes #2789: Custom tabs is not covering the full screen size. --- CHANGELOG.md | 1 + .../mozilla/fenix/browser/BrowserFragment.kt | 19 +++++++++++-------- 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 308b00799..09aa22cd3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -60,4 +60,5 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - #1994 - Made app state persist better when rotating the screen - #654 - Updated Refresh button to turn into Stop button while menu is open. - [AC #2725](https://github.com/mozilla-mobile/android-components/issues/2725) Updated tracking protectionPolicy to [recommend](https://github.com/mozilla-mobile/android-components/blob/master/components/concept/engine/src/main/java/mozilla/components/concept/engine/EngineSession.kt#L156) +- #2789 Custom tabs is not covering the full screen size. ### Removed diff --git a/app/src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt b/app/src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt index 06cc412ff..f2acee370 100644 --- a/app/src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt @@ -162,14 +162,17 @@ class BrowserFragment : Fragment(), BackHandler, CoroutineScope { } } - view.engineView.asView().apply { - (layoutParams as CoordinatorLayout.LayoutParams).apply { - setMargins( - 0, - 0, - 0, - (resources.displayMetrics.density * TOOLBAR_HEIGHT).toInt() + - QUICK_ACTION_SHEET_HANDLE_HEIGHT) + if (customTabSessionId == null) { + view.engineView.asView().apply { + (layoutParams as CoordinatorLayout.LayoutParams).apply { + setMargins( + 0, + 0, + 0, + (resources.displayMetrics.density * TOOLBAR_HEIGHT).toInt() + + QUICK_ACTION_SHEET_HANDLE_HEIGHT + ) + } } }