From ba54080177cf1797f60e93f2012983423dfe99a9 Mon Sep 17 00:00:00 2001 From: Sebastian Kaspari Date: Thu, 13 Feb 2020 16:17:28 +0100 Subject: [PATCH] Issue #8277: Reuse app icon in widget layout. This patch refactors the widget layouts so that we can reuse the app icon and do not have to have another logo resource with different constraints. This will also make it easier to update the branding in #8277 and #8278. --- .../gecko/search/SearchWidgetProvider.kt | 8 ++-- app/src/main/res/drawable/ic_logo_widget.xml | 26 ----------- .../layout/search_widget_extra_small_v1.xml | 24 +++++----- .../layout/search_widget_extra_small_v2.xml | 9 ++-- .../main/res/layout/search_widget_large.xml | 7 ++- .../main/res/layout/search_widget_medium.xml | 7 ++- .../main/res/layout/search_widget_small.xml | 44 +++++++------------ 7 files changed, 47 insertions(+), 78 deletions(-) delete mode 100644 app/src/main/res/drawable/ic_logo_widget.xml diff --git a/app/src/main/java/org/mozilla/gecko/search/SearchWidgetProvider.kt b/app/src/main/java/org/mozilla/gecko/search/SearchWidgetProvider.kt index c76edc2cb..f933b7c4f 100644 --- a/app/src/main/java/org/mozilla/gecko/search/SearchWidgetProvider.kt +++ b/app/src/main/java/org/mozilla/gecko/search/SearchWidgetProvider.kt @@ -17,7 +17,7 @@ import android.view.View import android.widget.RemoteViews import androidx.annotation.Dimension import androidx.annotation.Dimension.DP -import androidx.appcompat.widget.AppCompatDrawableManager +import androidx.appcompat.content.res.AppCompatResources import androidx.core.graphics.drawable.toBitmap import org.mozilla.fenix.HomeActivity import org.mozilla.fenix.IntentReceiverActivity @@ -168,13 +168,13 @@ class SearchWidgetProvider : AppWidgetProvider() { if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) { setImageViewResource( R.id.button_search_widget_new_tab_icon, - R.drawable.ic_logo_widget) + R.drawable.ic_launcher_foreground) } else { setImageViewBitmap( R.id.button_search_widget_new_tab_icon, - AppCompatDrawableManager.get().getDrawable( + AppCompatResources.getDrawable( context, - R.drawable.ic_logo_widget + R.drawable.ic_launcher_foreground )?.toBitmap()) } } diff --git a/app/src/main/res/drawable/ic_logo_widget.xml b/app/src/main/res/drawable/ic_logo_widget.xml deleted file mode 100644 index 4f07b2fdc..000000000 --- a/app/src/main/res/drawable/ic_logo_widget.xml +++ /dev/null @@ -1,26 +0,0 @@ - - - - - - - - - - - - - diff --git a/app/src/main/res/layout/search_widget_extra_small_v1.xml b/app/src/main/res/layout/search_widget_extra_small_v1.xml index 59aeb64cc..4dd9c31de 100644 --- a/app/src/main/res/layout/search_widget_extra_small_v1.xml +++ b/app/src/main/res/layout/search_widget_extra_small_v1.xml @@ -4,15 +4,19 @@ - file, You can obtain one at http://mozilla.org/MPL/2.0/. --> + xmlns:tools="http://schemas.android.com/tools" + android:id="@id/button_search_widget_new_tab" + android:layout_width="match_parent" + android:layout_height="50dp" + android:background="@drawable/rounded_white_corners" + android:layout_gravity="center"> - \ No newline at end of file + android:id="@+id/button_search_widget_new_tab_icon" + android:layout_width="50dp" + android:layout_height="50dp" + android:scaleType="centerInside" + tools:src="@drawable/ic_launcher_foreground" + android:layout_gravity="center"/> + + diff --git a/app/src/main/res/layout/search_widget_extra_small_v2.xml b/app/src/main/res/layout/search_widget_extra_small_v2.xml index eca312a68..e61a0fde2 100644 --- a/app/src/main/res/layout/search_widget_extra_small_v2.xml +++ b/app/src/main/res/layout/search_widget_extra_small_v2.xml @@ -4,6 +4,7 @@ - file, You can obtain one at http://mozilla.org/MPL/2.0/. --> - \ No newline at end of file + diff --git a/app/src/main/res/layout/search_widget_large.xml b/app/src/main/res/layout/search_widget_large.xml index 5faa8a0ce..fe596e90b 100644 --- a/app/src/main/res/layout/search_widget_large.xml +++ b/app/src/main/res/layout/search_widget_large.xml @@ -12,11 +12,10 @@ + android:scaleType="centerInside" /> + android:scaleType="centerInside" /> + - - - - - - - - - + android:scaleType="centerInside" /> + +