blallo
/
fenix
1
0
Fork 0
Code Releases Activity

No issue: Updates crash report back press and string (#1773)

master
Sawyer Blatz 2019-04-22 14:05:23 -07:00 committed by GitHub
parent 6199d31924
commit b996acdb35
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
app/src/main/java/org/mozilla/fenix/crashes/CrashReporterFragment.kt
View File

@ -33,7 +33,7 @@ class CrashReporterFragment : Fragment() {
val crash = Crash.fromIntent(CrashReporterFragmentArgs.fromBundle(arguments!!).crashIntent)
view.findViewById<TextView>(R.id.title).text =
getString(R.string.tab_crash_title, context!!.getString(R.string.app_name))
getString(R.string.tab_crash_title_2, context!!.getString(R.string.app_name))
requireContext().components.analytics.metrics.track(Event.CrashReporterOpened)
@ -75,7 +75,6 @@ class CrashReporterFragment : Fragment() {
}
private fun navigateHome(fromView: View) {
val directions = CrashReporterFragmentDirections.actionCrashReporterFragmentToHomeFragment()
Navigation.findNavController(fromView).navigate(directions)
Navigation.findNavController(fromView).popBackStack(R.id.browserFragment, true)
}
}

3
app/src/main/res/values/strings.xml
View File

@ -278,7 +278,8 @@
<!-- Crashes -->
<!-- Title text displayed on the tab crash page. This first parameter is the name of the application (For example: Fenix) -->
<string name="tab_crash_title">Sorry. %1$s can’t get that tab back</string>
<string name="tab_crash_title_2">Sorry. %1$s can’t load that page.</string>
<!-- Description text displayed on the tab crash page -->
<string name="tab_crash_description">You can attempt to restore or close this tab below.</string>
<!-- Send crash report checkbox text on the tab crash page -->