From b6e6e36ccd0fe2c7f623b904e98ebd1db95f1f36 Mon Sep 17 00:00:00 2001 From: Sawyer Blatz Date: Wed, 25 Sep 2019 08:44:03 -0700 Subject: [PATCH] For #561: Fix stutter of search icon & text when animating --- app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt | 4 ---- app/src/main/java/org/mozilla/fenix/utils/Undo.kt | 2 +- app/src/main/res/layout/fragment_home.xml | 4 ++-- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt b/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt index e7fadef8f..a45d67463 100644 --- a/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt @@ -239,10 +239,6 @@ class HomeFragment : Fragment() { } } - view.wordmark.setOnClickListener { - showSavedSnackbar(2) - } - view.menuButton.setOnClickListener { homeMenu?.menuBuilder?.build(requireContext())?.show( anchor = it, diff --git a/app/src/main/java/org/mozilla/fenix/utils/Undo.kt b/app/src/main/java/org/mozilla/fenix/utils/Undo.kt index b21d1bf8e..5d5d109a0 100644 --- a/app/src/main/java/org/mozilla/fenix/utils/Undo.kt +++ b/app/src/main/java/org/mozilla/fenix/utils/Undo.kt @@ -25,7 +25,7 @@ internal const val UNDO_DELAY = 3000L * @param undoActionTitle Label for the action associated with the [FenixSnackbar]. * @param onCancel A suspend block to execute in case of cancellation. * @param operation A suspend block to execute if user doesn't cancel via the displayed [FenixSnackbar]. - * @param anchorView A view to anchor the undo [FenixSnackbar] to + * @param anchorView A [View] to which [FenixSnackbar] should be anchored. */ @Suppress("LongParameterList") fun CoroutineScope.allowUndo( diff --git a/app/src/main/res/layout/fragment_home.xml b/app/src/main/res/layout/fragment_home.xml index 8a4e6ebdd..cafd7f919 100644 --- a/app/src/main/res/layout/fragment_home.xml +++ b/app/src/main/res/layout/fragment_home.xml @@ -91,7 +91,7 @@ android:id="@+id/search_engine_icon" android:layout_width="24dp" android:layout_height="24dp" - android:layout_marginStart="8dp" + android:layout_marginStart="12dp" android:layout_gravity="center_vertical" android:clickable="false" android:focusable="false" @@ -102,7 +102,7 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:layout_gravity="center_vertical" - android:layout_marginStart="40dp" + android:layout_marginStart="44dp" android:clickable="false" android:focusable="false" android:importantForAccessibility="no"