diff --git a/app/build.gradle b/app/build.gradle index 2f9f9b769..48a5fa8fa 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -18,6 +18,7 @@ android { targetSdkVersion Config.targetSdkVersion versionCode 1 versionName Config.generateDebugVersionName() + vectorDrawables.useSupportLibrary = true testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner" testInstrumentationRunnerArguments clearPackageData: 'true' manifestPlaceholders.isRaptorEnabled = "false" diff --git a/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/onboarding/OnboardingFirefoxAccountViewHolder.kt b/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/onboarding/OnboardingFirefoxAccountViewHolder.kt index 46439e178..1525175e9 100644 --- a/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/onboarding/OnboardingFirefoxAccountViewHolder.kt +++ b/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/onboarding/OnboardingFirefoxAccountViewHolder.kt @@ -5,6 +5,7 @@ package org.mozilla.fenix.home.sessioncontrol.viewholders.onboarding import android.view.View +import androidx.appcompat.content.res.AppCompatResources import androidx.navigation.Navigation import androidx.recyclerview.widget.RecyclerView import kotlinx.android.synthetic.main.onboarding_firefox_account.view.* @@ -12,6 +13,13 @@ import org.mozilla.fenix.R import org.mozilla.fenix.home.HomeFragmentDirections class OnboardingFirefoxAccountViewHolder(private val view: View) : RecyclerView.ViewHolder(view) { + private val avatarAnonymousDrawable by lazy { + AppCompatResources.getDrawable(view.context, R.drawable.ic_onboarding_avatar_anonymous) + } + private val firefoxAccountsDrawable by lazy { + AppCompatResources.getDrawable(view.context, R.drawable.ic_onboarding_firefox_accounts) + } + init { view.turn_on_sync_button.setOnClickListener { val directions = HomeFragmentDirections.actionHomeFragmentToTurnOnSyncFragment() @@ -31,13 +39,10 @@ class OnboardingFirefoxAccountViewHolder(private val view: View) : RecyclerView. } private fun updateHeaderText(autoSignedIn: Boolean) { - val appName = view.context.getString(R.string.app_name) - - val icon = - if (autoSignedIn) view.context.getDrawable(R.drawable.ic_onboarding_avatar_anonymous) - else view.context.getDrawable(R.drawable.ic_onboarding_firefox_accounts) - + val icon = if (autoSignedIn) avatarAnonymousDrawable else firefoxAccountsDrawable view.header_text.setCompoundDrawablesRelativeWithIntrinsicBounds(icon, null, null, null) + + val appName = view.context.getString(R.string.app_name) view.header_text.text = if (autoSignedIn) view.context.getString(R.string.onboarding_firefox_account_auto_signin_header) else view.context.getString(R.string.onboarding_firefox_account_header, appName) diff --git a/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/onboarding/OnboardingPrivacyNoticeViewHolder.kt b/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/onboarding/OnboardingPrivacyNoticeViewHolder.kt index 3fbd5f44a..95148a003 100644 --- a/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/onboarding/OnboardingPrivacyNoticeViewHolder.kt +++ b/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/onboarding/OnboardingPrivacyNoticeViewHolder.kt @@ -5,10 +5,9 @@ package org.mozilla.fenix.home.sessioncontrol.viewholders.onboarding import android.view.View +import androidx.appcompat.content.res.AppCompatResources import androidx.recyclerview.widget.RecyclerView import kotlinx.android.synthetic.main.onboarding_privacy_notice.view.* -import kotlinx.android.synthetic.main.onboarding_privacy_notice.view.description_text -import kotlinx.android.synthetic.main.onboarding_privacy_notice.view.header_text import org.jetbrains.anko.dimen import org.mozilla.fenix.R import org.mozilla.fenix.settings.SupportUtils @@ -16,7 +15,7 @@ import org.mozilla.fenix.settings.SupportUtils class OnboardingPrivacyNoticeViewHolder(view: View) : RecyclerView.ViewHolder(view) { init { - val icon = view.context.getDrawable(R.drawable.ic_onboarding_privacy_notice) + val icon = AppCompatResources.getDrawable(view.context, R.drawable.ic_onboarding_privacy_notice) val size = view.context.dimen(R.dimen.onboarding_header_icon_height_width) icon?.setBounds(0, 0, size, size) diff --git a/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/onboarding/OnboardingPrivateBrowsingViewHolder.kt b/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/onboarding/OnboardingPrivateBrowsingViewHolder.kt index 3220ff5a3..1a309a6b7 100644 --- a/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/onboarding/OnboardingPrivateBrowsingViewHolder.kt +++ b/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/onboarding/OnboardingPrivateBrowsingViewHolder.kt @@ -10,6 +10,7 @@ import android.text.SpannableString import android.text.Spanned import android.text.style.ImageSpan import android.view.View +import androidx.appcompat.content.res.AppCompatResources import androidx.recyclerview.widget.RecyclerView import kotlinx.android.synthetic.main.onboarding_private_browsing.view.* import org.mozilla.fenix.R @@ -17,7 +18,7 @@ import org.mozilla.fenix.R class OnboardingPrivateBrowsingViewHolder(view: View) : RecyclerView.ViewHolder(view) { init { - val iconDrawable = view.context.getDrawable(R.drawable.ic_private_browsing)!! + val iconDrawable = AppCompatResources.getDrawable(view.context, R.drawable.ic_private_browsing)!! iconDrawable.setBounds(0, 0, view.description_text.lineHeight, view.description_text.lineHeight) val icon = object : ImageSpan(iconDrawable) { diff --git a/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/onboarding/OnboardingTrackingProtectionViewHolder.kt b/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/onboarding/OnboardingTrackingProtectionViewHolder.kt index 3e2092949..e46b654a8 100644 --- a/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/onboarding/OnboardingTrackingProtectionViewHolder.kt +++ b/app/src/main/java/org/mozilla/fenix/home/sessioncontrol/viewholders/onboarding/OnboardingTrackingProtectionViewHolder.kt @@ -5,6 +5,7 @@ package org.mozilla.fenix.home.sessioncontrol.viewholders.onboarding import android.view.View +import androidx.appcompat.content.res.AppCompatResources import androidx.recyclerview.widget.RecyclerView import kotlinx.android.synthetic.main.onboarding_tracking_protection.view.* import org.jetbrains.anko.dimen @@ -15,7 +16,7 @@ import org.mozilla.fenix.utils.Settings class OnboardingTrackingProtectionViewHolder(val view: View) : RecyclerView.ViewHolder(view) { init { - val icon = view.context.getDrawable(R.drawable.ic_onboarding_tracking_protection) + val icon = AppCompatResources.getDrawable(view.context, R.drawable.ic_onboarding_tracking_protection) val size = view.context.dimen(R.dimen.onboarding_header_icon_height_width) icon?.setBounds(0, 0, size, size) diff --git a/app/src/main/res/drawable/ic_fx_accounts_avatar.xml b/app/src/main/res/drawable/ic_fx_accounts_avatar.xml index 267152d05..f839750a5 100644 --- a/app/src/main/res/drawable/ic_fx_accounts_avatar.xml +++ b/app/src/main/res/drawable/ic_fx_accounts_avatar.xml @@ -1,7 +1,7 @@ + - - @@ -34,20 +34,20 @@ android:strokeAlpha="0.3" android:fillAlpha="0.3"> - - - - + + + @@ -56,7 +56,7 @@ android:fillColor="#FBFBFE"/> @@ -65,20 +65,20 @@ android:strokeAlpha="0.3" android:fillAlpha="0.3"> - - - - + + + @@ -92,14 +92,14 @@ - - - + + diff --git a/app/src/main/res/drawable/ic_onboarding_avatar_anonymous.xml b/app/src/main/res/drawable/ic_onboarding_avatar_anonymous.xml index 56e804fb8..5d4bd8248 100644 --- a/app/src/main/res/drawable/ic_onboarding_avatar_anonymous.xml +++ b/app/src/main/res/drawable/ic_onboarding_avatar_anonymous.xml @@ -17,11 +17,11 @@ android:endY="-6.155523" android:endX="18.457676" android:type="linear"> - - - - - + + + + + @@ -34,11 +34,11 @@ android:endY="-13.936461" android:endX="26.325832" android:type="linear"> - - - - - + + + + + diff --git a/app/src/main/res/drawable/ic_onboarding_firefox_accounts.xml b/app/src/main/res/drawable/ic_onboarding_firefox_accounts.xml index 14ccf67a0..935ff22eb 100644 --- a/app/src/main/res/drawable/ic_onboarding_firefox_accounts.xml +++ b/app/src/main/res/drawable/ic_onboarding_firefox_accounts.xml @@ -5,33 +5,29 @@ - + - - - - - + + + + + - + - - - - - - - + + + + + + + diff --git a/app/src/main/res/drawable/ic_onboarding_privacy_notice.xml b/app/src/main/res/drawable/ic_onboarding_privacy_notice.xml index 236f06f97..e836da928 100644 --- a/app/src/main/res/drawable/ic_onboarding_privacy_notice.xml +++ b/app/src/main/res/drawable/ic_onboarding_privacy_notice.xml @@ -8,11 +8,7 @@ android:height="24dp" android:viewportWidth="24" android:viewportHeight="24"> - + - - + + diff --git a/app/src/main/res/drawable/ic_onboarding_private_browsing.xml b/app/src/main/res/drawable/ic_onboarding_private_browsing.xml index 7f5915082..8a0376e96 100644 --- a/app/src/main/res/drawable/ic_onboarding_private_browsing.xml +++ b/app/src/main/res/drawable/ic_onboarding_private_browsing.xml @@ -19,8 +19,8 @@ android:startY="-0.94" android:endX="1.81" android:endY="16.33"> - - + + diff --git a/app/src/main/res/layout/onboarding_firefox_account.xml b/app/src/main/res/layout/onboarding_firefox_account.xml index 6633f5870..e388e53d7 100644 --- a/app/src/main/res/layout/onboarding_firefox_account.xml +++ b/app/src/main/res/layout/onboarding_firefox_account.xml @@ -10,12 +10,12 @@ android:layout_height="wrap_content" android:orientation="vertical"> - - \ No newline at end of file + diff --git a/app/src/main/res/layout/onboarding_private_browsing.xml b/app/src/main/res/layout/onboarding_private_browsing.xml index c93bc8401..b71ff7ba4 100644 --- a/app/src/main/res/layout/onboarding_private_browsing.xml +++ b/app/src/main/res/layout/onboarding_private_browsing.xml @@ -9,11 +9,12 @@ android:layout_width="match_parent" android:layout_height="wrap_content"> - \ No newline at end of file + diff --git a/app/src/main/res/layout/onboarding_theme_picker.xml b/app/src/main/res/layout/onboarding_theme_picker.xml index 35f0a4ce7..cbed61406 100644 --- a/app/src/main/res/layout/onboarding_theme_picker.xml +++ b/app/src/main/res/layout/onboarding_theme_picker.xml @@ -144,6 +144,7 @@ android:layout_marginStart="16dp" android:layout_marginTop="16dp" android:layout_marginBottom="16dp" + android:paddingStart="0dp" android:paddingEnd="8dp" app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintStart_toStartOf="parent" diff --git a/app/src/main/res/layout/onboarding_tracking_protection.xml b/app/src/main/res/layout/onboarding_tracking_protection.xml index e0ab8ba94..67a8b8554 100644 --- a/app/src/main/res/layout/onboarding_tracking_protection.xml +++ b/app/src/main/res/layout/onboarding_tracking_protection.xml @@ -13,7 +13,7 @@ android:id="@+id/header_text" android:layout_width="0dp" android:layout_height="wrap_content" - android:drawableStart="@drawable/ic_onboarding_tracking_protection" + app:drawableStartCompat="@drawable/ic_onboarding_tracking_protection" android:drawablePadding="12dp" android:text="@string/onboarding_tracking_protection_header" android:textAppearance="@style/HeaderTextStyle" @@ -36,4 +36,4 @@ app:layout_constraintStart_toStartOf="parent" app:layout_constraintTop_toBottomOf="@id/header_text" app:layout_constraintBottom_toBottomOf="parent"/> - \ No newline at end of file + diff --git a/app/src/main/res/layout/sign_in_preference.xml b/app/src/main/res/layout/sign_in_preference.xml index 454e8414d..fa2777afb 100644 --- a/app/src/main/res/layout/sign_in_preference.xml +++ b/app/src/main/res/layout/sign_in_preference.xml @@ -4,6 +4,7 @@ - file, You can obtain one at http://mozilla.org/MPL/2.0/. --> @@ -31,7 +32,7 @@ android:ellipsize="none" android:scrollHorizontally="false" android:singleLine="true" - android:text="Title" + tools:text="Title" android:textAppearance="@style/Header16TextStyle" app:layout_constraintBottom_toTopOf="@android:id/summary" app:layout_constraintEnd_toEndOf="parent" @@ -47,11 +48,11 @@ android:layout_marginBottom="8dp" android:ellipsize="none" android:scrollHorizontally="false" - android:text="Summary" + tools:text="Summary" android:textAppearance="?android:attr/textAppearanceSmall" android:textColor="?android:attr/textColorSecondary" android:textSize="16sp" app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toEndOf="@+id/imageView" /> - \ No newline at end of file +