From a75c2f7cfb64c1ccaeb136ff8f55b36ed773105f Mon Sep 17 00:00:00 2001 From: Jeff Boek Date: Wed, 31 Jul 2019 17:37:17 -0700 Subject: [PATCH] No Issue - Fixes the offset key to prevent endless history bug --- .../org/mozilla/fenix/library/history/HistoryDataSource.kt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/org/mozilla/fenix/library/history/HistoryDataSource.kt b/app/src/main/java/org/mozilla/fenix/library/history/HistoryDataSource.kt index 7c8c48289..8fae4de9d 100644 --- a/app/src/main/java/org/mozilla/fenix/library/history/HistoryDataSource.kt +++ b/app/src/main/java/org/mozilla/fenix/library/history/HistoryDataSource.kt @@ -43,7 +43,9 @@ class HistoryDataSource( ?: visit.url.getHostFromUrl() ?: visit.url - HistoryItem(offset + id, title, visit.url, visit.visitTime) + // We want IDs to start at 1, not 0 to be able to send the correct offset + // to the `historyProvider.getHistory` call. + HistoryItem(offset + id + 1, title, visit.url, visit.visitTime) } } }