blallo
/
fenix
1
0
Fork 0
Code Releases Activity

For #747: Fix memory leak with HomeMenu

master
Colin Lee 2019-03-01 11:25:35 -06:00 committed by Jeff Boek
parent 28e2a62683
commit 9d3ef76929
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt
View File

@ -58,7 +58,7 @@ fun SessionBundleStorage.archive(sessionManager: SessionManager) {
class HomeFragment : Fragment() { class HomeFragment : Fragment() {
private val bus = ActionBusFactory.get(this) private val bus = ActionBusFactory.get(this)
private var sessionObserver: SessionManager.Observer? = null private var sessionObserver: SessionManager.Observer? = null
private lateinit var homeMenu: HomeMenu private var homeMenu: HomeMenu? = null
private lateinit var tabsComponent: TabsComponent private lateinit var tabsComponent: TabsComponent
private lateinit var sessionsComponent: SessionsComponent private lateinit var sessionsComponent: SessionsComponent
@ -114,7 +114,7 @@ class HomeFragment : Fragment() {
} }
view.menuButton.setOnClickListener { view.menuButton.setOnClickListener {
homeMenu.menuBuilder.build(requireContext()).show( homeMenu?.menuBuilder?.build(requireContext())?.show(
anchor = it, anchor = it,
orientation = BrowserMenu.Orientation.DOWN) orientation = BrowserMenu.Orientation.DOWN)
} }
@ -166,6 +166,11 @@ class HomeFragment : Fragment() {
} }
} }
override fun onDestroyView() {
super.onDestroyView()
homeMenu = null
}
override fun onResume() { override fun onResume() {
super.onResume() super.onResume()
(activity as AppCompatActivity).supportActionBar?.hide() (activity as AppCompatActivity).supportActionBar?.hide()