diff --git a/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt b/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt index e47362137..7380ff65f 100644 --- a/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt @@ -260,7 +260,7 @@ class HomeFragment : Fragment() { view.resources.getDimensionPixelSize(R.dimen.search_bar_search_engine_icon_padding) view.toolbar_wrapper.setOnClickListener { invokePendingDeleteJobs() - onboarding.finish() + hideOnboardingIfNeeded() val directions = HomeFragmentDirections.actionHomeFragmentToSearchFragment( sessionId = null ) @@ -274,7 +274,7 @@ class HomeFragment : Fragment() { view.add_tab_button.setOnClickListener { invokePendingDeleteJobs() - onboarding.finish() + hideOnboardingIfNeeded() val directions = HomeFragmentDirections.actionHomeFragmentToSearchFragment( sessionId = null ) diff --git a/app/src/main/java/org/mozilla/fenix/onboarding/FenixOnboarding.kt b/app/src/main/java/org/mozilla/fenix/onboarding/FenixOnboarding.kt index dbcfb42e5..8e2047ebc 100644 --- a/app/src/main/java/org/mozilla/fenix/onboarding/FenixOnboarding.kt +++ b/app/src/main/java/org/mozilla/fenix/onboarding/FenixOnboarding.kt @@ -8,6 +8,7 @@ import android.content.Context import android.content.SharedPreferences import androidx.core.content.edit import org.mozilla.fenix.ext.components +import org.mozilla.fenix.components.metrics.Event class FenixOnboarding(context: Context) { private val metrics = context.components.analytics.metrics @@ -22,9 +23,7 @@ class FenixOnboarding(context: Context) { fun finish() { onboardingPrefs.onboardedVersion = CURRENT_ONBOARDING_VERSION - - // To be fixed in #4824 - // metrics.track(Event.DismissedOnboarding) + metrics.track(Event.DismissedOnboarding) } fun userHasBeenOnboarded() = onboardingPrefs.onboardedVersion == CURRENT_ONBOARDING_VERSION