blallo
/
fenix
1
0
Fork 0
Code Releases Activity

For #10193 - Remove page title when sharing links

master
person808 2020-06-03 09:42:02 -07:00 committed by Kainalu Hagiwara
parent a7e74e308b
commit 9272026b7e
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/src/main/java/org/mozilla/fenix/share/ShareController.kt
View File

@ -172,7 +172,7 @@ class DefaultShareController(
@VisibleForTesting @VisibleForTesting
fun getShareText() = shareData.joinToString("\n\n") { data -> fun getShareText() = shareData.joinToString("\n\n") { data ->
listOfNotNull(data.title, data.url).joinToString("\n") data.url.orEmpty()
} }
// Navigation between app fragments uses ShareTab as arguments. SendTabUseCases uses TabData. // Navigation between app fragments uses ShareTab as arguments. SendTabUseCases uses TabData.

4
app/src/test/java/org/mozilla/fenix/share/ShareControllerTest.kt
View File

@ -39,8 +39,8 @@ import org.mozilla.fenix.components.metrics.Event
import org.mozilla.fenix.components.metrics.MetricController import org.mozilla.fenix.components.metrics.MetricController
import org.mozilla.fenix.ext.metrics import org.mozilla.fenix.ext.metrics
import org.mozilla.fenix.ext.nav import org.mozilla.fenix.ext.nav
import org.mozilla.fenix.share.listadapters.AppShareOption
import org.mozilla.fenix.helpers.FenixRobolectricTestRunner import org.mozilla.fenix.helpers.FenixRobolectricTestRunner
import org.mozilla.fenix.share.listadapters.AppShareOption
@RunWith(FenixRobolectricTestRunner::class) @RunWith(FenixRobolectricTestRunner::class)
@ExperimentalCoroutinesApi @ExperimentalCoroutinesApi
@ -57,7 +57,7 @@ class ShareControllerTest {
TabData("title0", "url0"), TabData("title0", "url0"),
TabData("title1", "url1") TabData("title1", "url1")
) )
private val textToShare = "${shareData[0].title}\n${shareData[0].url}\n\n${shareData[1].title}\n${shareData[1].url}" private val textToShare = "${shareData[0].url}\n\n${shareData[1].url}"
private val testCoroutineScope = TestCoroutineScope() private val testCoroutineScope = TestCoroutineScope()
private val sendTabUseCases = mockk<SendTabUseCases>(relaxed = true) private val sendTabUseCases = mockk<SendTabUseCases>(relaxed = true)
private val snackbar = mockk<FenixSnackbar>(relaxed = true) private val snackbar = mockk<FenixSnackbar>(relaxed = true)