From 88f01731d7dd6fb9820190e05c35d98c728ef4d0 Mon Sep 17 00:00:00 2001 From: Arturo Mejia Date: Fri, 14 Aug 2020 10:29:37 -0400 Subject: [PATCH] For issue #13827: "Set as default browser" option disappears from Settings. --- .../main/java/org/mozilla/fenix/settings/SettingsFragment.kt | 3 ++- app/src/main/res/xml/preferences.xml | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt b/app/src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt index ee9bc6fb6..f74e27bb4 100644 --- a/app/src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt +++ b/app/src/main/java/org/mozilla/fenix/settings/SettingsFragment.kt @@ -302,7 +302,8 @@ class SettingsFragment : PreferenceFragmentCompat() { private fun setupPreferences() { val leakKey = getPreferenceKey(R.string.pref_key_leakcanary) val debuggingKey = getPreferenceKey(R.string.pref_key_remote_debugging) - val preferenceExternalDownloadManager = requirePreference(R.string.pref_key_make_default_browser) + val preferenceExternalDownloadManager = + requirePreference(R.string.pref_key_external_download_manager) val preferenceLeakCanary = findPreference(leakKey) val preferenceRemoteDebugging = findPreference(debuggingKey) val preferenceMakeDefaultBrowser = requirePreference(R.string.pref_key_make_default_browser) diff --git a/app/src/main/res/xml/preferences.xml b/app/src/main/res/xml/preferences.xml index 04de02720..f3bf4c39b 100644 --- a/app/src/main/res/xml/preferences.xml +++ b/app/src/main/res/xml/preferences.xml @@ -136,7 +136,8 @@ android:defaultValue="false" android:icon="@drawable/ic_download" android:key="@string/pref_key_external_download_manager" - android:title="@string/preferences_external_download_manager" /> + android:title="@string/preferences_external_download_manager" + app:isPreferenceVisible="false"/>