blallo
/
fenix
1
0
Fork 0
Code Releases Activity

For #3615: Long pressing the address bar should not copy link (#4083)

master
Colin Lee 2019-07-16 13:42:05 -05:00 committed by GitHub
parent 6b4c160d18
commit 8855af2234
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 0 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
app/src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt
View File

@ -489,21 +489,6 @@ class BrowserFragment : Fragment(), BackHandler {
trackToolbarItemInteraction(it) trackToolbarItemInteraction(it)
handleToolbarItemInteraction(it) handleToolbarItemInteraction(it)
} }
is SearchAction.ToolbarLongClicked -> {
getSessionById()?.let { session ->
session.copyUrl(requireContext())
view?.let {
val snackbar = FenixSnackbar.make(it, Snackbar.LENGTH_LONG)
.setText(resources.getString(R.string.url_copied))
if (!session.isCustomTabSession()) {
snackbar.anchorView = nestedScrollQuickAction
}
snackbar.show()
}
}
}
} }
} }

1
app/src/main/java/org/mozilla/fenix/components/toolbar/ToolbarComponent.kt
View File

@ -82,7 +82,6 @@ sealed class SearchAction : Action {
data class UrlCommitted(val url: String, val session: String?, val engine: SearchEngine? = null) : SearchAction() data class UrlCommitted(val url: String, val session: String?, val engine: SearchEngine? = null) : SearchAction()
data class TextChanged(val query: String) : SearchAction() data class TextChanged(val query: String) : SearchAction()
object ToolbarClicked : SearchAction() object ToolbarClicked : SearchAction()
object ToolbarLongClicked : SearchAction()
data class ToolbarMenuItemTapped(val item: ToolbarMenu.Item) : SearchAction() data class ToolbarMenuItemTapped(val item: ToolbarMenu.Item) : SearchAction()
object EditingCanceled : SearchAction() object EditingCanceled : SearchAction()
} }

5
app/src/main/java/org/mozilla/fenix/components/toolbar/ToolbarUIView.kt
View File

@ -86,11 +86,6 @@ class ToolbarUIView(
actionEmitter.onNext(SearchAction.TextChanged(text)) actionEmitter.onNext(SearchAction.TextChanged(text))
} }
}) })
setOnUrlLongClickListener {
actionEmitter.onNext(SearchAction.ToolbarLongClicked)
true
}
} }
with(view.context) { with(view.context) {